refactor: remove long deprecated things. (#1799)

Author: igalklebanov

src/dialect/database-introspector.ts

@@ -11,13 +11,6 @@ export interface DatabaseIntrospector {
    * Get tables and views metadata.
    */
   getTables(options?: DatabaseMetadataOptions): Promise<TableMetadata[]>
-
-  /**
-   * Get the database metadata such as table and column names.
-   *
-   * @deprecated Use getTables() instead.
-   */
-  getMetadata(options?: DatabaseMetadataOptions): Promise<DatabaseMetadata>
 }
 
 export interface DatabaseMetadataOptions {
@@ -32,14 +25,6 @@ export interface SchemaMetadata {
   readonly name: string
 }
 
-export interface DatabaseMetadata {
-  /**
-   * The tables and views found in the database.
-   * The propery isView can be used to tell them apart.
-   */
-  readonly tables: TableMetadata[]
-}
-
 export interface TableMetadata {
   readonly name: string
   readonly isView: boolean

src/dialect/mssql/mssql-dialect-config.ts

@@ -1,5 +1,3 @@
-import type { KyselyTypeError } from '../../util/type-error.js'
-
 export interface MssqlDialectConfig {
   /**
    * When `true`, connections are reset to their initial states when released
@@ -79,11 +77,6 @@ export interface Tedious {
   connectionFactory: () => TediousConnection | Promise<TediousConnection>
   ISOLATION_LEVEL: TediousIsolationLevel
   Request: TediousRequestClass
-  // TODO: remove in v0.29.0
-  /**
-   * @deprecated use {@link MssqlDialectConfig.resetConnectionsOnRelease} instead.
-   */
-  resetConnectionOnRelease?: KyselyTypeError<'deprecated: use `MssqlDialectConfig.resetConnectionsOnRelease` instead'>
   TYPES: TediousTypes
 }
 
@@ -180,13 +173,7 @@ export interface Tarn {
    * Tarn.js' pool options, excluding `create`, `destroy` and `validate` functions,
    * which must be implemented by this dialect.
    */
-  options: Omit<TarnPoolOptions<any>, 'create' | 'destroy' | 'validate'> & {
-    // TODO: remove in v0.29.0
-    /**
-     * @deprecated use {@link MssqlDialectConfig.validateConnections} instead.
-     */
-    validateConnections?: KyselyTypeError<'deprecated: use `MssqlDialectConfig.validateConnections` instead'>
-  }
+  options: Omit<TarnPoolOptions<any>, 'create' | 'destroy' | 'validate'>
 
   /**
    * Tarn.js' Pool class.

src/dialect/mssql/mssql-driver.ts

@@ -43,13 +43,9 @@ export class MssqlDriver implements Driver {
     this.#config = freeze({ ...config })
 
     const { tarn, tedious, validateConnections } = this.#config
-    const {
-      validateConnections: deprecatedValidateConnections,
-      ...poolOptions
-    } = tarn.options
 
     this.#pool = new tarn.Pool({
-      ...poolOptions,
+      ...tarn.options,
       create: async () => {
         const connection = await tedious.connectionFactory()
 
@@ -61,8 +57,7 @@ export class MssqlDriver implements Driver {
       // @ts-ignore `tarn` accepts a function that returns a promise here, but
       // the types are not aligned and it type errors.
       validate:
-        validateConnections === false ||
-        (deprecatedValidateConnections as any) === false
+        validateConnections === false
           ? undefined
           : (connection) => connection[PRIVATE_VALIDATE_METHOD](),
     })
@@ -106,10 +101,7 @@ export class MssqlDriver implements Driver {
   }
 
   async releaseConnection(connection: MssqlConnection): Promise<void> {
-    if (
-      this.#config.resetConnectionsOnRelease ||
-      this.#config.tedious.resetConnectionOnRelease
-    ) {
+    if (this.#config.resetConnectionsOnRelease) {
       await connection[PRIVATE_RESET_METHOD]()
     }
 
@@ -126,7 +118,6 @@ class MssqlConnection implements DatabaseConnection {
   #hasSocketError: boolean
   readonly #tedious: Tedious
   #inflightRequest: MssqlRequest<any> | undefined
-  #sessionId: unknown
 
   constructor(connection: TediousConnection, tedious: Tedious) {
     this.#connection = connection

src/dialect/mssql/mssql-introspector.ts

@@ -1,7 +1,6 @@
 import type { Kysely } from '../../kysely.js'
 import type {
   DatabaseIntrospector,
-  DatabaseMetadata,
   DatabaseMetadataOptions,
   SchemaMetadata,
   TableMetadata,
@@ -169,14 +168,6 @@ export class MssqlIntrospector implements DatabaseIntrospector {
 
     return Object.values(tableDictionary)
   }
-
-  async getMetadata(
-    options?: DatabaseMetadataOptions,
-  ): Promise<DatabaseMetadata> {
-    return {
-      tables: await this.getTables(options),
-    }
-  }
 }
 
 interface MssqlSysTables {

src/dialect/mysql/mysql-introspector.ts

@@ -1,6 +1,5 @@
 import type {
   DatabaseIntrospector,
-  DatabaseMetadata,
   DatabaseMetadataOptions,
   SchemaMetadata,
   TableMetadata,
@@ -68,14 +67,6 @@ export class MysqlIntrospector implements DatabaseIntrospector {
     return this.#parseTableMetadata(rawColumns)
   }
 
-  async getMetadata(
-    options?: DatabaseMetadataOptions,
-  ): Promise<DatabaseMetadata> {
-    return {
-      tables: await this.getTables(options),
-    }
-  }
-
   #parseTableMetadata(columns: RawColumnMetadata[]): TableMetadata[] {
     return columns.reduce<TableMetadata[]>((tables, it) => {
       let table = tables.find((tbl) => tbl.name === it.TABLE_NAME)

src/dialect/postgres/postgres-driver.ts

@@ -7,10 +7,7 @@ import type { Driver, TransactionSettings } from '../../driver/driver.js'
 import { parseSavepointCommand } from '../../parser/savepoint-parser.js'
 import { CompiledQuery } from '../../query-compiler/compiled-query.js'
 import type { QueryCompiler } from '../../query-compiler/query-compiler.js'
-import type {
-  AbortableOperationOptions,
-  AbortableQueryOptions,
-} from '../../util/abort.js'
+import type { AbortableOperationOptions } from '../../util/abort.js'
 import { isFunction, freeze } from '../../util/object-utils.js'
 import { createQueryId, type QueryId } from '../../util/query-id.js'
 import { extendStackTrace } from '../../util/stack-trace-utils.js'

src/dialect/postgres/postgres-introspector.ts

@@ -1,6 +1,5 @@
 import type {
   DatabaseIntrospector,
-  DatabaseMetadata,
   DatabaseMetadataOptions,
   SchemaMetadata,
   TableMetadata,
@@ -97,14 +96,6 @@ export class PostgresIntrospector implements DatabaseIntrospector {
     return this.#parseTableMetadata(rawColumns)
   }
 
-  async getMetadata(
-    options?: DatabaseMetadataOptions,
-  ): Promise<DatabaseMetadata> {
-    return {
-      tables: await this.getTables(options),
-    }
-  }
-
   #parseTableMetadata(columns: RawColumnMetadata[]): TableMetadata[] {
     const tableDictionary: Map<string, TableMetadata> = new Map()
 

src/dialect/sqlite/sqlite-introspector.ts

@@ -1,6 +1,5 @@
 import type {
   DatabaseIntrospector,
-  DatabaseMetadata,
   DatabaseMetadataOptions,
   SchemaMetadata,
   TableMetadata,
@@ -55,14 +54,6 @@ export class SqliteIntrospector implements DatabaseIntrospector {
     return await this.#getTableMetadata(options)
   }
 
-  async getMetadata(
-    options?: DatabaseMetadataOptions,
-  ): Promise<DatabaseMetadata> {
-    return {
-      tables: await this.getTables(options),
-    }
-  }
-
   #tablesQuery(
     qb: QueryCreator<SqliteSystemDatabase> | Kysely<SqliteSystemDatabase>,
     options: DatabaseMetadataOptions,

src/expression/expression-builder.ts

@@ -8,7 +8,6 @@ import {
   type TableExpressionOrList,
   parseTable,
 } from '../parser/table-parser.js'
-import { WithSchemaPlugin } from '../plugin/with-schema/with-schema-plugin.js'
 import { createQueryId } from '../util/query-id.js'
 import {
   createFunctionModule,
@@ -1144,13 +1143,6 @@ export interface ExpressionBuilder<DB, TB extends keyof DB> {
     expr: RE,
     dataType: DataTypeExpression,
   ): ExpressionWrapper<DB, TB, T>
-
-  /**
-   * See {@link QueryCreator.withSchema}
-   *
-   * @deprecated Will be removed in kysely 0.25.0.
-   */
-  withSchema(schema: string): ExpressionBuilder<DB, TB>
 }
 
 export function createExpressionBuilder<DB, TB extends keyof DB>(
@@ -1369,12 +1361,6 @@ export function createExpressionBuilder<DB, TB extends keyof DB>(
         ),
       )
     },
-
-    withSchema(schema: string): ExpressionBuilder<DB, TB> {
-      return createExpressionBuilder(
-        executor.withPluginAtFront(new WithSchemaPlugin(schema)),
-      )
-    },
   })
 
   eb.fn = createFunctionModule()

src/operation-node/drop-table-node.ts

@@ -2,10 +2,14 @@ import { freeze } from '../util/object-utils.js'
 import type { OperationNode } from './operation-node.js'
 import type { TableNode } from './table-node.js'
 
-export type DropTablexNodeParams = Omit<
-  Partial<DropTableNode>,
-  'kind' | 'table'
->
+export type DropTableNodeParams = Omit<Partial<DropTableNode>, 'kind' | 'table'>
+
+// TODO: remove in 0.30
+/**
+ * @deprecated use {@link DropTableNodeParams} instead.
+ */
+export type DropTablexNodeParams = DropTableNodeParams
+
 export interface DropTableNode extends OperationNode {
   readonly kind: 'DropTableNode'
   readonly table: TableNode
@@ -18,11 +22,11 @@ type DropTableNodeFactory = Readonly<{
   is(node: OperationNode): node is DropTableNode
   create(
     table: TableNode,
-    params?: DropTablexNodeParams,
+    params?: DropTableNodeParams,
   ): Readonly<DropTableNode>
   cloneWith(
     dropIndex: DropTableNode,
-    params: DropTablexNodeParams,
+    params: DropTableNodeParams,
   ): Readonly<DropTableNode>
 }>