Commit 5b83c0a
Laksh/rebase main (#92)
* add CI for windows dev branch
* ci: rename images workflow (microsoft#1627)
# Description
Having this action be named as image is confusing since it does Image +
E2E
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* feat(ebpfwindows-Plugin): ebpf Windows Plugin using a custom parser (microsoft#1633)
# Description
This PR adds a new Retina Plugin to read Metrics Map events from Windows
eBPF
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [x] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [x] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [x] I have correctly attributed the author(s) of the code.
- [x] I have tested the changes locally.
- [x] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [x] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* ci: windows image workqueue dispatch (microsoft#1670)
# Description
Generate images and manifests for windows dev branch
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* update retinaebpfapi version (microsoft#1683)
# Description
Pulling in latest retinaepfapi package from nuget.org.
## Checklist
- [x] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [x] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [x] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [x] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
NA
## Additional Notes
NA
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* ci: update ci for dev/v0.0.33-windows (microsoft#1687)
# Description
Update dev/v0.0.33 branch to push images alongside main
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* Added handling for CiliumOnWindows Registry Values in Hns and EbpfWin… (microsoft#1684)
# Description
Added registry check for CiliumOnWindows in Hns and EbpfWindows plugins
to support CoExistence in Mixed Mode clusters
Please provide a brief description of the changes made in this pull
request.
Added a common function to check for the Registry value.
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [x] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [x] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [x] I have correctly attributed the author(s) of the code.
- [x] I have tested the changes locally.
I have manually deployed the image on AKS cluster with --set
enabledPlugin_win="[ebpfwindows\,hnsstats\]" `
and verified through logs either ebpfwindows or hnsttats are running
based on CiliumOnWindows Registry value
- [x] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* (test): Retina Windows eBPF e2e Tests (microsoft#1721)
# Description
Added e2e tests for Windows ebpf scenario.
Please provide a brief description of the changes made in this pull
request.
1. Creates a daemon set to install ebpf on windows nodes
2. Installs a test ebpf program which generates the events
3. The generated events are verified by the test jobs
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [x] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [x] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [x] I have correctly attributed the author(s) of the code.
- [x] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
successful run with this change
https://github.com/kumarvin123/retina/actions/runs/15951308276
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* Consume latest RetinaEbpfApi; Add lost events API; Update struct processing due to latest RetinaEbpfApi changes (microsoft#1768)
# Description
- Updates RetinaEbpfApi version
- Updates processing of Metrics Map due to API changes
- Adds processing for lost events API
- Updates tests to utilize added windows_metrics map
## Related Issue
## Checklist
- [X] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [X] I have correctly attributed the author(s) of the code.
- [X] I have tested the changes locally.
- [X] I have followed the project's style guidelines.
- [X] I have updated the documentation, if necessary.
- [X] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
---------
Signed-off-by: Matthew Ige <matthewige1@gmail.com>
Co-authored-by: Vinod K L Swamy <vinodko@microsoft.com>
* Update e2e-test-event-writer yml to trigger on dev branch (microsoft#1782)
# Description
e2e-test-event-writer.yml was not triggering on dev branches
## Related Issue
n/a
## Checklist
- [X] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [X] I have correctly attributed the author(s) of the code.
- [X] I have tested the changes locally.
- [X] I have followed the project's style guidelines.
- [X] I have updated the documentation, if necessary.
- [X] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
n/a
## Additional Notes
n/a
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* Cherry picking locactx fix form main branch (microsoft#1810)
Cherry picking following fix from main branch: fix(localctx+win): Fix
the helm insatll command for localCtx
(microsoft#1807)
# Description
- Disable operator installation for `localCtx` (not needed)
- Windows configmap is missing `enableAnnotations` config
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [X] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [X] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [X] I have followed the project's style guidelines.
- [X] I have updated the documentation, if necessary.
- [X] I have added tests, if applicable.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
Signed-off-by: Anubhab Majumdar <anmajumdar@microsoft.com>
Co-authored-by: Anubhab Majumdar <anmajumdar@microsoft.com>
* fix enable annotation (microsoft#1818)
# Description
enableAnnotations got defined twice in windows configmap due to [this
pr](microsoft#1810).
Removed extra occurrence of enableAnnotations.
## Checklist
- [X] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [X] I have correctly attributed the author(s) of the code.
- [X] I have tested the changes locally.
- [X] I have followed the project's style guidelines.
- [X] I have updated the documentation, if necessary.
- [X] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* [SFI - Service Tags] Retina Virtual Tags (microsoft#1819)
# Description
Run E2e Tests pipeline is failing during cluster creation with the
following error:
```bash
#################### CreateNPMCluster ###################################################################
2025/08/14 18:58:11 when the cluster is ready, use the below command to access and debug
2025/08/14 18:58:11 az aks get-credentials --resource-group runner-e2e-netobs-1755197881 --name runner-e2e-netobs-1755197881 --subscription ***
2025/08/14 18:58:11 creating cluster "runner-e2e-netobs-1755197881" in resource group "runner-e2e-netobs-1755197881"...
2025/08/14 18:58:40 failed to create cluster: GET https://management.azure.com/subscriptions/***/providers/Microsoft.ContainerService/locations/eastus2/operations/fd882d18-319b-4200-aa9e-a2934886e35b
--------------------------------------------------------------------------------
RESPONSE 200: 200 OK
ERROR CODE: RequestDisallowedByPolicy
--------------------------------------------------------------------------------
{
"name": "fd882d18-319b-4200-aa9e-a2934886e35b",
"status": "Failed",
"startTime": "2025-08-14T18:58:30.3284728Z",
"endTime": "2025-08-14T18:58:38.5566866Z",
"error": {
"code": "RequestDisallowedByPolicy",
"message": "Create or update public IP failed: Subscription: ***; resource group: MC_runner-e2e-netobs-1755197881_runner-e2e-netobs-1755197881_eastus2; public IP name: c1debc4c-7910-4441-b0ce-30b64f37b43c. Resource 'c1debc4c-7910-4441-b0ce-30b64f37b43c' was disallowed by policy. Reasons: 'The public ip needs to be tagged with either a service or virtual tag.'. See error details for policy resource IDs.",
"details": [
{
"code": "RequestDisallowedByPolicy",
"message": "Resource 'c1debc4c-7910-4441-b0ce-30b64f37b43c' was disallowed by policy. Reasons: 'The public ip needs to be tagged with either a service or virtual tag.'. See error details for policy resource IDs.",
"target": "c1debc4c-7910-4441-b0ce-30b64f37b43c"
}
]
}
}
--------------------------------------------------------------------------------
runner.go:38:
Error Trace: /home/runner/work/retina/retina/test/e2e/framework/types/runner.go:38
/home/runner/work/retina/retina/test/e2e/infra/azure_temp_infra_setup.go:47
/home/runner/work/retina/retina/test/e2e/retina_e2e_test.go:38
Error: Received unexpected error:
did not expect error from step CreateNPMCluster but got error: received notification, failed to create cluster: GET https://management.azure.com/subscriptions/***/providers/Microsoft.ContainerService/locations/eastus2/operations/fd882d18-319b-4200-aa9e-a2934886e35b
--------------------------------------------------------------------------------
RESPONSE 200: 200 OK
ERROR CODE: RequestDisallowedByPolicy
--------------------------------------------------------------------------------
{
"name": "fd882d18-319b-4200-aa9e-a2934886e35b",
"status": "Failed",
"startTime": "2025-08-14T18:58:30.3284728Z",
"endTime": "2025-08-14T18:58:38.5566866Z",
"error": {
"code": "RequestDisallowedByPolicy",
"message": "Create or update public IP failed: Subscription: ***; resource group: MC_runner-e2e-netobs-1755197881_runner-e2e-netobs-1755197881_eastus2; public IP name: c1debc4c-7910-4441-b0ce-30b64f37b43c. Resource 'c1debc4c-7910-4441-b0ce-30b64f37b43c' was disallowed by policy. Reasons: 'The public ip needs to be tagged with either a service or virtual tag.'. See error details for policy resource IDs.",
"details": [
{
"code": "RequestDisallowedByPolicy",
"message": "Resource 'c1debc4c-7910-4441-b0ce-30b64f37b43c' was disallowed by policy. Reasons: 'The public ip needs to be tagged with either a service or virtual tag.'. See error details for policy resource IDs.",
"target": "c1debc4c-7910-4441-b0ce-30b64f37b43c"
}
]
}
}
--------------------------------------------------------------------------------
```
Cherry-picked changes from this [draft
pr](https://github.com/microsoft/retina/pull/1796/files) which adds a
public IP address with the required tags to the load balancer. This
should fix the above issue.
## Checklist
- [X] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [X] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [X] I have followed the project's style guidelines.
- [X] I have updated the documentation, if necessary.
- [X] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
Co-authored-by: Keerthana Routhu <krouthu@microsoft.com>
* Revert sfi changes (microsoft#1840)
# Description
The SFI related changes introduced in the pr microsoft#1819 causes failure in e2e
runs. This pr reverts those changes.
## Checklist
- [X] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [X] I have correctly attributed the author(s) of the code.
- [X] I have tested the changes locally.
- [X] I have followed the project's style guidelines.
- [X] I have updated the documentation, if necessary.
- [X] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* Merging PR from main- refactor: add dockerfile for windows build and make build-binaries microsoft#1720 (microsoft#1842)
# Description
Merging PR from main- refactor: add dockerfile for windows build and
make build-binaries microsoft#1720
We want to separate the windows build into 2 steps
Build the binaries needed for the final image
Build the final image including the binaries built in step 1
For step 1, add a build-binaries task to the Makefile that builds the
binaries needed for the final image.
For step 2, add a Dockerfile for the windows build that builds the final
image including the binaries built in step 1
## Related Issue
Make window's build branch compatible with release pipeline
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* Add pktmon parsing (microsoft#1875)
# Description
This pull request adds support for parsing and handling "Pktmon Drop"
events in the Windows eBPF datapath plugin. It introduces new structures
and logic to decode these events, integrates them into the event
handling and parsing pipeline, and adds tests to ensure correct
processing.
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [X] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [X] I have correctly attributed the author(s) of the code.
- [X] I have tested the changes locally.
- [X] I have followed the project's style guidelines.
- [X] I have updated the documentation, if necessary.
- [X] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* Update windows base image (microsoft#1883)
---------
# Description
Updated Docker file to pull latest windows base image to resolve
security vulnerabilities.
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [X] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [X] I have correctly attributed the author(s) of the code.
- [X] I have tested the changes locally.
- [X] I have followed the project's style guidelines.
- [X] I have updated the documentation, if necessary.
- [X] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* fix(pipeline): Add space character to create fresh commit hash (microsoft#1911)
# Description
Please provide a brief description of the changes made in this pull
request.
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* Return error when ip is nil (microsoft#1908)
# Description
Retina pods crash when a nil ip is passed to the enricher. Returning
error in handleTraceEvent so that nil ip is not sent to enricher.
## Checklist
- [X] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [X] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* latest windows base image (microsoft#1931)
# Description
Updated Docker file to pull latest windows base image to resolve
security vulnerabilities.
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [X] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [X] I have correctly attributed the author(s) of the code.
- [X] I have tested the changes locally.
- [X] I have followed the project's style guidelines.
- [X] I have updated the documentation, if necessary.
- [X] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* chore: update dockerfile for shell in Windows CI (microsoft#1932)
# Description
This action is failing regularly on `dev/v0.0.33-windows`
https://github.com/microsoft/retina/actions/runs/19348996959/job/55361017859
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* fix windows build timeout (microsoft#1935)
# Description
Please provide a brief description of the changes made in this pull
request.
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
---------
Signed-off-by: Mathew Merrick <matmerr@users.noreply.github.com>
* latest windows base image (01/13/26) (microsoft#1998)
# Description
New windows base images were published on 1/13. Updated Docker file to
pull latest windows base image to resolve security vulnerabilities.
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [x] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [x] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [x] I have correctly attributed the author(s) of the code.
- [x] I have tested the changes locally.
- [x] I have followed the project's style guidelines.
- [x] I have updated the documentation, if necessary.
- [x] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* Gracefully Handle the abscence of retinaebpfapi.dll (microsoft#2143)
# Description
This change makes the Windows eBPF plugin fail open when
retinaebpfapi.dll is not installed or does not expose the expected
entrypoints. Instead of deferring the failure until the first native
call, startup now validates the DLL up front, logs a warning, and skips
plugin initialization cleanly. It also adds a unit test covering the
missing-DLL path.
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [ x] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [x ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [x ] I have correctly attributed the author(s) of the code.
- [x ] I have tested the changes locally.
- [x ] I have followed the project's style guidelines.
- [x ] I have updated the documentation, if necessary.
- [ x] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* ebpf xdp version bump (microsoft#2267)
# Description
Remove retinaebpfapi.dll from retina image.
Bumped the version of following:
ebpf 0.21.0 -> 1.1.0
xdp 1.1.0 -> 1.3.0
Microsoft.Wcn.Observability.eBPF.Retina (retinaebpfapi.dll)
0.1.0-prerelease.11 -> 1.3.0
servercore base images
## Checklist
- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* Fix xdp install in retina test (microsoft#2283)
# Description
Made the following fixes to the install-ebpf-xdp.ps1 script which is
used to setup node for e2e tests.
- Add xdp cert to cert store to resolve installation errors.
- Download and install retinaebpfapi on the node since it is no longer
packaged with retina image
- Install vc++ runtime needed for retinaebpfapi.dll
- Copy ebpfapi.dll to the dir where retinaebpfapi.dll is (this can be
updated when retinaebpfapi can find the dll from path)
## Checklist
- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [X] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* Bump retinaebpfapi version (microsoft#2358)
# Description
Consuming latest available retinaebpfapi version and windows base
images.
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [X] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
* ci: remove krew-index update step on dev/v0.0.33-windows (microsoft#2390)
The krew-release-bot step in goreleaser.yaml triggers on every tag
pushed from this branch, including pre-release tags like
`v0.0.33-windows-rc.2`, opening spurious PRs against
[krew-index](https://github.com/kubernetes-sigs/krew-index) (e.g.
#5787).
Main has microsoft#2107 which gates the step on final release tags, but this dev
branch forked before that landed. Since this branch only produces
pre-release/windows-dev tags that should never publish to krew, removing
the step entirely is the simplest fix.
The new tag `v0.0.33-windows-rc.2` already points to a commit with this
change applied, so the in-flight release is unaffected.
---------
Signed-off-by: Mathew Merrick <matmerr@microsoft.com>
* Laksh/cherry pick specific (microsoft#2425)
# Description
Problem
The OB pipeline for tag v0.0.33-windows-rc.2 fails with two errors:
1. kubectl_shell: docker build fails because target shell-target not
found in cli/Dockerfile
2. agent_win: output/windows_amd64/*.exe not found
Root cause: branch dev/v0.0.33-windows was created from commit 82d621c
(May 7, 2025) and is missing upstream changes that restructured the
Windows build pipeline.
Cherry-picked following commits to resolve the issue:
[59c1655](microsoft@59c1655)
(1946) and
[fd482c0](microsoft@fd482c0)
(microsoft#1997)
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
---------
Signed-off-by: Kamil <kamil.prz@gmail.com>
Signed-off-by: Laksh Kotian <lakshkotian98@gmail.com>
Co-authored-by: carlotaarvela <67275927+carlotaarvela@users.noreply.github.com>
Co-authored-by: Kamil <kamil.prz@gmail.com>
Co-authored-by: kamilprz <36544756+kamilprz@users.noreply.github.com>
Co-authored-by: Simone Rodigari <32323373+SRodi@users.noreply.github.com>
* Bump Go toolchain and dependencies to resolve security vulnerabilities (microsoft#2538)
# Description
Problem
The `retina-agent` image built from `dev/v0.0.33-windows` is flagged by
container image vulnerability scanning known Go CVEs (`stdlib` plus
modules such as `containerd`, `grpc`, `golang.org/x/net`,
`mapstructure/v2`, `runc` and `aws-sdk-go-v2`)
Since branch `dev/v0.0.33-windows` was created from commit `82d621c`
(May 2025, ~500 commits behind), so Go toolchain/dependencies are
frozen. `main` is already patched, so we are fixing staleness.
Aligned the branch's Go toolchain and dependencies with the patched
versions `main` already uses:
- Go builder `mcr.microsoft.com/oss/go/microsoft/golang` `1.24.x ->
1.26.5` across the controller/operator/cli/test Dockerfiles (Linux
`azurelinux3.0`, Windows `windowsservercore-ltsc2022`; operator-windows
moves `cbl-mariner2.0 -> azurelinux3.0` since there's no 1.26 Mariner
tag). Building with 1.26.5 clears the `stdlib` advisories (the scanner
reads the Go version baked into the binary).
- `go` directive `1.24.3 -> 1.26.0`.
- `mapstructure/v2 -> 2.5.0`, `containerd -> 1.7.33`, `runc -> 1.2.8` +
`selinux -> 1.13.1`, `grpc -> 1.79.3`, `golang.org/x/net -> 0.57.0`,
`aws-sdk-go-v2/.../eventstream -> 1.7.14`, `docker/docker -> 28.5.2`.
**note**
left out cilium, inspektor-gadget, and docker as their patched versions
dropped/moved the exact packages we import (or the fix lives in a
totally different module), so bumping them breaks the build and needs
the code refactors main already did (everything else was a clean
version bump)
## Related Issue
If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.
## Checklist
- [ ] I have read the [contributing
documentation](https://retina.sh/docs/Contributing/overview).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.
## Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes
made.
## Additional Notes
Add any additional notes or context about the pull request here.
---
Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
---------
Signed-off-by: Christelle Chatelain <cchatelain@microsoft.com>
Signed-off-by: chrcha1 <97578958+chrcha1@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Align rebased history with squash goal state
Discard superseded upstream cherry-picks and intermediate Windows branch changes so the expanded history produces the same final tree as laksh/squash-and-rebase.
* resolve comments
---------
Signed-off-by: Matthew Ige <matthewige1@gmail.com>
Signed-off-by: Anubhab Majumdar <anmajumdar@microsoft.com>
Signed-off-by: Mathew Merrick <matmerr@users.noreply.github.com>
Signed-off-by: Mathew Merrick <matmerr@microsoft.com>
Signed-off-by: Kamil <kamil.prz@gmail.com>
Signed-off-by: Laksh Kotian <lakshkotian98@gmail.com>
Signed-off-by: Christelle Chatelain <cchatelain@microsoft.com>
Signed-off-by: chrcha1 <97578958+chrcha1@users.noreply.github.com>
Co-authored-by: Mathew Merrick <matmerr@microsoft.com>
Co-authored-by: Mathew Merrick <matmerr@users.noreply.github.com>
Co-authored-by: VINOD KLSWAMY <50496432+kumarvin123@users.noreply.github.com>
Co-authored-by: Matthew Ige <matthewige1@gmail.com>
Co-authored-by: Vinod K L Swamy <vinodko@microsoft.com>
Co-authored-by: Anubhab Majumdar <anmajumdar@microsoft.com>
Co-authored-by: Keerthana Routhu <krouthu@microsoft.com>
Co-authored-by: Iti Agrawal <agrawaliti0107@gmail.com>
Co-authored-by: Beegii Khurelsukh <72892628+BeegiiK@users.noreply.github.com>
Co-authored-by: carlotaarvela <67275927+carlotaarvela@users.noreply.github.com>
Co-authored-by: Kamil <kamil.prz@gmail.com>
Co-authored-by: kamilprz <36544756+kamilprz@users.noreply.github.com>
Co-authored-by: Simone Rodigari <32323373+SRodi@users.noreply.github.com>
Co-authored-by: Christelle Chatelain <97578958+chrcha1@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 20e0aa5 commit 5b83c0a
41 files changed
Lines changed: 9274 additions & 2453 deletions
File tree
- .github/workflows
- deploy/standard/manifests/controller/helm/retina
- templates
- pkg
- plugin
- common
- ebpfwindows
- hnsstats
- utils
- test/e2e
- framework
- kubernetes
- prometheus
- jobs
- scenarios
- drop
- windows
- tools/event-writer
- yaml/windows
- windows/manifests
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | | - | |
| 5 | + | |
5 | 6 | | |
6 | | - | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| 20 | + | |
| 21 | + | |
18 | 22 | | |
19 | 23 | | |
20 | 24 | | |
21 | 25 | | |
22 | 26 | | |
23 | | - | |
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
| |||
33 | 36 | | |
34 | 37 | | |
35 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | | - | |
63 | | - | |
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
56 | 57 | | |
57 | 58 | | |
58 | 59 | | |
| |||
96 | 97 | | |
97 | 98 | | |
98 | 99 | | |
99 | | - | |
| 100 | + | |
100 | 101 | | |
101 | 102 | | |
102 | 103 | | |
| |||
312 | 313 | | |
313 | 314 | | |
314 | 315 | | |
315 | | - | |
| 316 | + | |
316 | 317 | | |
317 | 318 | | |
318 | 319 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
0 commit comments