Skip to content

Commit bb4dab5

Browse files
nddqlakshk98
authored andcommitted
fix(ci): run perf tests only after E2E passes (microsoft#2185)
# Description Currently `perf-test-basic` and `perf-test-advanced` in `images.yaml` run in parallel with the `e2e` job. If E2E is already failing, both perf jobs still spin up AKS clusters, wasting ~2 hours of compute and 2 additional resource groups. This adds `e2e` to the `needs` list for both perf jobs so they only run after E2E passes. ## Related Issue N/A ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/Contributing/overview). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Workflow-only change. Verified YAML syntax is correct. ## Additional Notes N/A Signed-off-by: Quang Nguyen <nguyenquang@microsoft.com>
1 parent 08610cb commit bb4dab5

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/images.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ jobs:
427427
428428
perf-test-basic:
429429
if: ${{ github.event_name == 'merge_group'}}
430-
needs: [manifests, get-tag]
430+
needs: [manifests, get-tag, e2e]
431431
uses: ./.github/workflows/perf-template.yaml
432432
with:
433433
image-registry: ${{ vars.ACR_NAME }}
@@ -443,7 +443,7 @@ jobs:
443443

444444
perf-test-advanced:
445445
if: ${{ github.event_name == 'merge_group'}}
446-
needs: [manifests, get-tag]
446+
needs: [manifests, get-tag, e2e]
447447
uses: ./.github/workflows/perf-template.yaml
448448
with:
449449
image-registry: ${{ vars.ACR_NAME }}

0 commit comments

Comments
 (0)