You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Comments should explain non-obvious "why" reasoning, not restate what the code does.
63
63
- Remove debug prints (`println!`, `dbg!`, `print()`) before merging — use `tracing` or logging frameworks.
64
64
- Extract logic repeated in 2+ places into a shared helper; inline single-use logic at its call site.
65
+
- Think carefully before adding a helper: only introduce one when it materially reduces cognitive load or eliminates substantial duplication, and do not add thin wrappers that only rename or forward existing calls.
65
66
- Keep PRs focused — no drive-by refactors, reformatting, or cosmetic changes.
66
67
- Be mindful of memory use: avoid collecting streams of `RecordBatch` into memory; use `RoaringBitmap` instead of `HashSet<u32>`.
0 commit comments