perf(dir-catalog): rewrite manifest mutations with copy-on-write#7176
Open
jackye1995 wants to merge 1 commit into
Open
perf(dir-catalog): rewrite manifest mutations with copy-on-write#7176jackye1995 wants to merge 1 commit into
jackye1995 wants to merge 1 commit into
Conversation
2a96c17 to
2f1b29a
Compare
2f1b29a to
7aa7936
Compare
7aa7936 to
06ad0be
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
06ad0be to
d8c90da
Compare
LuQQiu
approved these changes
Jun 11, 2026
LuQQiu
left a comment
Contributor
There was a problem hiding this comment.
Curious about the performance number with this new approach
Contributor
|
Oh see the performance numbers.... lolll skip reviewing the PR descriptions fully |
Contributor
|
Why |
Contributor
Author
I think it's because in general just fewer files to read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__manifestmerge-insert/delete maintenance with streaming copy-on-write rewrites.object_id,object_type, andbase_objects; delete table-version ranges without expanding every version id.This PR is the cleaned-up, production implementation of the copy-on-write approach prototyped in #6794.
Expected performance
From the #6794 prototype benchmark (S3, multi-process, 1K manifest entries):