Skip to content

fix: reserve main branch name#7180

Open
majin1102 wants to merge 5 commits into
lance-format:mainfrom
majin1102:codex/reserve-main-branch
Open

fix: reserve main branch name#7180
majin1102 wants to merge 5 commits into
lance-format:mainfrom
majin1102:codex/reserve-main-branch

Conversation

@majin1102

@majin1102 majin1102 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Close #7167

@github-actions github-actions Bot added the bug Something isn't working label Jun 9, 2026
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/dataset.rs 88.88% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@jackye1995

Copy link
Copy Markdown
Contributor

I think this likely deserve a vote and also update the format spec accordingly?

@majin1102

Copy link
Copy Markdown
Contributor Author

I think this likely deserve a vote and also update the format spec accordingly?

Yeah, sure.
I will update the format spec. This is actually an experience optimiziation. The real sematics has been established in earlier PRs. But I agree we coud have a vote to make this formal.

@github-actions

Copy link
Copy Markdown
Contributor

Important

This PR touches the Lance format specification.

Substantive changes to the format specification — the .proto definitions
and the spec docs under docs/src/format/ — require a PMC vote before merge.
Minor edits such as typo fixes, wording, or formatting are excluded; use your
judgment.

If this is a meaningful format change:

  • Start a vote following the Lance community voting process.
    Format specification modifications need 3 binding +1 votes (excluding the
    proposer), held on GitHub Discussions, with a minimum voting period of 1 week.
  • Once the vote passes, link the completed vote in this PR. It should not be
    merged until the vote is linked.

@github-actions github-actions Bot added A-format On-disk format: protos and format spec docs A-python Python bindings A-java Java bindings + JNI labels Jun 11, 2026
@majin1102

Copy link
Copy Markdown
Contributor Author

Related vote: #7229

@majin1102 majin1102 force-pushed the codex/reserve-main-branch branch from 5a96d06 to 26350af Compare June 11, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-format On-disk format: protos and format spec docs A-java Java bindings + JNI A-python Python bindings bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark main a reserved branch name for the main branch

3 participants