Skip to content

Commit 11f6889

Browse files
committed
fix(ci): add missing lfx build step to cross-platform workflow_dispatch
The build-if-needed job (used by workflow_dispatch) was missing the lfx package build, causing all cross-platform tests to fail with: 'No solution found: lfx>=0.4.0 required but only <=0.3.4 available' Changes: - Build lfx wheel in build-if-needed job - Upload lfx artifact (adhoc-dist-lfx) - Add lfx-artifact-name to job outputs - Update all test jobs to fallback to build-if-needed outputs for lfx artifact (matching existing base/main pattern)
1 parent 2f6400d commit 11f6889

1 file changed

Lines changed: 21 additions & 10 deletions

File tree

.github/workflows/cross-platform-test.yml

Lines changed: 21 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ jobs:
4040
outputs:
4141
base-artifact-name: ${{ steps.set-names.outputs.base-artifact-name }}
4242
main-artifact-name: ${{ steps.set-names.outputs.main-artifact-name }}
43+
lfx-artifact-name: ${{ steps.set-names.outputs.lfx-artifact-name }}
4344
steps:
4445
- name: Checkout code
4546
uses: actions/checkout@v6
@@ -62,8 +63,17 @@ jobs:
6263
# Base package builds to dist/ but should be in src/backend/base/dist/
6364
mkdir -p src/backend/base/dist
6465
mv dist/langflow_base*.whl src/backend/base/dist/
66+
- name: Build LFX package
67+
run: |
68+
cd src/lfx
69+
uv build --wheel --out-dir dist
6570
- name: Build main package
6671
run: make build_langflow args="--wheel"
72+
- name: Upload lfx artifact
73+
uses: actions/upload-artifact@v6
74+
with:
75+
name: adhoc-dist-lfx
76+
path: src/lfx/dist
6777
- name: Upload base artifact
6878
uses: actions/upload-artifact@v6
6979
with:
@@ -79,6 +89,7 @@ jobs:
7989
run: |
8090
echo "base-artifact-name=adhoc-dist-base" >> $GITHUB_OUTPUT
8191
echo "main-artifact-name=adhoc-dist-main" >> $GITHUB_OUTPUT
92+
echo "lfx-artifact-name=adhoc-dist-lfx" >> $GITHUB_OUTPUT
8293
8394
test-installation-stable:
8495
name: Install & Run - ${{ matrix.os }} ${{ matrix.arch }} ${{ matrix.python-version }}
@@ -173,10 +184,10 @@ jobs:
173184
path: ./sdk-dist
174185

175186
- name: Download LFX package artifact
176-
if: steps.install-method.outputs.method == 'wheel' && inputs.lfx-artifact-name != ''
187+
if: steps.install-method.outputs.method == 'wheel' && (inputs.lfx-artifact-name != '' || needs.build-if-needed.outputs.lfx-artifact-name != '')
177188
uses: actions/download-artifact@v7
178189
with:
179-
name: ${{ inputs.lfx-artifact-name }}
190+
name: ${{ inputs.lfx-artifact-name || needs.build-if-needed.outputs.lfx-artifact-name || 'adhoc-dist-lfx' }}
180191
path: ./lfx-dist
181192

182193
- name: Download base package artifact
@@ -229,7 +240,7 @@ jobs:
229240
shell: bash
230241

231242
- name: Install LFX package from wheel (Windows)
232-
if: steps.install-method.outputs.method == 'wheel' && matrix.os == 'windows' && inputs.lfx-artifact-name != '' && inputs.sdk-artifact-name == ''
243+
if: steps.install-method.outputs.method == 'wheel' && matrix.os == 'windows' && (inputs.lfx-artifact-name != '' || needs.build-if-needed.outputs.lfx-artifact-name != '') && inputs.sdk-artifact-name == ''
233244
run: |
234245
ls -la ./lfx-dist/
235246
find ./lfx-dist -name "*.whl" -type f
@@ -300,7 +311,7 @@ jobs:
300311
shell: bash
301312

302313
- name: Install LFX package from wheel (Unix)
303-
if: steps.install-method.outputs.method == 'wheel' && matrix.os != 'windows' && inputs.lfx-artifact-name != '' && inputs.sdk-artifact-name == ''
314+
if: steps.install-method.outputs.method == 'wheel' && matrix.os != 'windows' && (inputs.lfx-artifact-name != '' || needs.build-if-needed.outputs.lfx-artifact-name != '') && inputs.sdk-artifact-name == ''
304315
run: |
305316
ls -la ./lfx-dist/
306317
find ./lfx-dist -name "*.whl" -type f
@@ -537,10 +548,10 @@ jobs:
537548
path: ./sdk-dist
538549

539550
- name: Download LFX package artifact
540-
if: steps.install-method.outputs.method == 'wheel' && inputs.lfx-artifact-name != ''
551+
if: steps.install-method.outputs.method == 'wheel' && (inputs.lfx-artifact-name != '' || needs.build-if-needed.outputs.lfx-artifact-name != '')
541552
uses: actions/download-artifact@v7
542553
with:
543-
name: ${{ inputs.lfx-artifact-name }}
554+
name: ${{ inputs.lfx-artifact-name || needs.build-if-needed.outputs.lfx-artifact-name || 'adhoc-dist-lfx' }}
544555
path: ./lfx-dist
545556

546557
- name: Download base package artifact
@@ -588,7 +599,7 @@ jobs:
588599
shell: bash
589600

590601
- name: Install LFX package from wheel (Windows)
591-
if: steps.install-method.outputs.method == 'wheel' && matrix.os == 'windows' && inputs.lfx-artifact-name != ''
602+
if: steps.install-method.outputs.method == 'wheel' && matrix.os == 'windows' && (inputs.lfx-artifact-name != '' || needs.build-if-needed.outputs.lfx-artifact-name != '')
592603
run: |
593604
ls -la ./lfx-dist/
594605
find ./lfx-dist -name "*.whl" -type f
@@ -630,7 +641,7 @@ jobs:
630641
shell: bash
631642

632643
- name: Install LFX package from wheel (Unix)
633-
if: steps.install-method.outputs.method == 'wheel' && matrix.os != 'windows' && inputs.lfx-artifact-name != ''
644+
if: steps.install-method.outputs.method == 'wheel' && matrix.os != 'windows' && (inputs.lfx-artifact-name != '' || needs.build-if-needed.outputs.lfx-artifact-name != '')
634645
run: |
635646
ls -la ./lfx-dist/
636647
find ./lfx-dist -name "*.whl" -type f
@@ -675,7 +686,7 @@ jobs:
675686
if: steps.install-method.outputs.method == 'wheel' && matrix.os == 'windows'
676687
run: |
677688
# Reinstall LFX if it was provided
678-
if [ -n "${{ inputs.lfx-artifact-name }}" ]; then
689+
if [ -n "${{ inputs.lfx-artifact-name || needs.build-if-needed.outputs.lfx-artifact-name }}" ]; then
679690
LFX_WHEEL=$(find ./lfx-dist -name "*.whl" -type f | head -1)
680691
if [ -n "$LFX_WHEEL" ]; then
681692
echo "Force reinstalling LFX: $LFX_WHEEL"
@@ -703,7 +714,7 @@ jobs:
703714
if: steps.install-method.outputs.method == 'wheel' && matrix.os != 'windows'
704715
run: |
705716
# Reinstall LFX if it was provided
706-
if [ -n "${{ inputs.lfx-artifact-name }}" ]; then
717+
if [ -n "${{ inputs.lfx-artifact-name || needs.build-if-needed.outputs.lfx-artifact-name }}" ]; then
707718
LFX_WHEEL=$(find ./lfx-dist -name "*.whl" -type f | head -1)
708719
if [ -n "$LFX_WHEEL" ]; then
709720
echo "Force reinstalling LFX: $LFX_WHEEL"

0 commit comments

Comments
 (0)