Skip to content

Commit 3a8f48b

Browse files
authored
fix(ci): resolve validate-version output in release-lfx changelog link (#13610)
The create-release job references needs.validate-version.outputs.current_version in its generated release notes (the Full Changelog compare link), but validate-version was not in the job's needs array, so the expression evaluated empty and the link rendered as compare/v...lfx-vX.Y.Z (broken base). Add validate-version to the create-release needs. This adds no real serialization: create-release already waits on release-lfx, which transitively requires validate-version via run-tests, and the job's always() if-condition is unaffected. Flagged by actionlint: property "validate-version" is not defined in object type {build-docker, release-lfx}.
1 parent f1d2971 commit 3a8f48b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/release-lfx.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ jobs:
276276
277277
create-release:
278278
name: Create GitHub Release
279-
needs: [release-lfx, build-docker]
279+
needs: [validate-version, release-lfx, build-docker]
280280
if: always() && github.event.inputs.create_github_release == 'true' && needs.release-lfx.result == 'success'
281281
runs-on: ubuntu-latest
282282
steps:

0 commit comments

Comments
 (0)