Skip to content

Commit 73eb55e

Browse files
committed
code improvements review
1 parent f225550 commit 73eb55e

1 file changed

Lines changed: 13 additions & 5 deletions

File tree

src/backend/tests/unit/api/v1/test_mcp_projects.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,15 +1056,17 @@ async def test_should_report_installed_true_when_config_file_contains_matching_u
10561056
tmp_path,
10571057
monkeypatch,
10581058
):
1059-
"""GIVEN: Config files exist with a matching project URL in mcpServers args
1059+
"""Config with matching URL marks client as installed.
1060+
1061+
GIVEN: Config files exist with a matching project URL in mcpServers args
10601062
WHEN: GET /mcp/project/{id}/installed is called
10611063
THEN: Each client should have available=True AND installed=True
10621064
"""
10631065
client_paths = _prepare_installed_check_env(monkeypatch, tmp_path)
10641066

10651067
# Write config files with matching URLs for all clients
10661068
project_id = user_test_project.id
1067-
for name, path in client_paths.items():
1069+
for path in client_paths.values():
10681070
config = {
10691071
"mcpServers": {
10701072
"lf-test": {
@@ -1096,7 +1098,9 @@ async def test_should_report_installed_false_when_config_file_has_no_matching_ur
10961098
tmp_path,
10971099
monkeypatch,
10981100
):
1099-
"""GIVEN: Config files exist but with a DIFFERENT project URL
1101+
"""Config with non-matching URL reports installed=False.
1102+
1103+
GIVEN: Config files exist but with a DIFFERENT project URL
11001104
WHEN: GET /mcp/project/{id}/installed is called
11011105
THEN: available=True (file exists) but installed=False (URL doesn't match)
11021106
"""
@@ -1134,7 +1138,9 @@ async def test_should_report_available_false_when_app_directory_does_not_exist(
11341138
tmp_path,
11351139
monkeypatch,
11361140
):
1137-
"""GIVEN: App directories do NOT exist (applications not installed)
1141+
"""Missing app directory reports available=False.
1142+
1143+
GIVEN: App directories do NOT exist (applications not installed)
11381144
WHEN: GET /mcp/project/{id}/installed is called
11391145
THEN: available=False and installed=False for all clients
11401146
"""
@@ -1182,7 +1188,9 @@ async def test_should_report_available_true_when_config_file_has_corrupt_json(
11821188
tmp_path,
11831189
monkeypatch,
11841190
):
1185-
"""GIVEN: Config files exist but contain invalid/corrupt JSON
1191+
"""Corrupt JSON config reports available=True but installed=False.
1192+
1193+
GIVEN: Config files exist but contain invalid/corrupt JSON
11861194
WHEN: GET /mcp/project/{id}/installed is called
11871195
THEN: available=True (directory exists) but installed=False (can't parse config)
11881196
"""

0 commit comments

Comments
 (0)