Skip to content

Commit 935b466

Browse files
committed
fix: encode Xquik path identifiers
1 parent 72f3470 commit 935b466

3 files changed

Lines changed: 20 additions & 8 deletions

File tree

src/backend/tests/unit/components/data_source/test_xquik.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,17 @@ def test_missing_path_identifier_raises(
272272
with pytest.raises(ValueError, match=expected_message):
273273
component._build_url(operation)
274274

275+
def test_path_identifier_is_url_encoded(self, component_class, default_kwargs):
276+
component = component_class(
277+
**{
278+
**default_kwargs,
279+
"operation": XquikComponent.GET_USER,
280+
"user_identifier": "name/with space",
281+
}
282+
)
283+
284+
assert component._build_url(XquikComponent.GET_USER) == ("https://xquik.com/api/v1/x/users/name%2Fwith%20space")
285+
275286
def test_limit_is_bounded(self, component_class, default_kwargs):
276287
component = component_class(**{**default_kwargs, "limit": 999})
277288

0 commit comments

Comments
 (0)