Merge branch 'release-1.12.0' into db-provider-a11y

Author: deon-sanchez

.secrets.baseline

@@ -22,13 +22,21 @@ describe("Checkbox accessibility", () => {
 });
 
 describe("CheckBoxDiv accessibility", () => {
-  // Known gap (a11y-action-plan 1.3): CheckBoxDiv is a visual-only <div>
-  // with no checkbox role, state, or keyboard support. Fails until the
-  // fix lands.
   it("should_expose_checkbox_role_and_checked_state", () => {
     render(<CheckBoxDiv checked />);
 
     const checkbox = screen.getByRole("checkbox");
     expect(checkbox).toHaveAttribute("aria-checked", "true");
   });
+
+  // When the wrapping element owns the toggle semantics (e.g. a toggle
+  // button) the indicator must NOT expose an interactive "checkbox" role,
+  // otherwise it nests an interactive role inside another one
+  // (IBM aria_descendant_valid).
+  it("should_be_hidden_from_assistive_tech_when_presentational", () => {
+    const { container } = render(<CheckBoxDiv checked presentational />);
+
+    expect(screen.queryByRole("checkbox")).not.toBeInTheDocument();
+    expect(container.firstChild).toHaveAttribute("aria-hidden", "true");
+  });
 });

src/frontend/src/components/ui/__tests__/checkbox.a11y.test.tsx

@@ -29,17 +29,27 @@ Checkbox.displayName = CheckboxPrimitive.Root.displayName;
 const CheckBoxDiv = ({
   className = "",
   checked,
+  presentational = false,
+  "aria-label": ariaLabel,
 }: {
   className?: string;
   checked?: boolean;
+  // When true, render a purely visual indicator (hidden from assistive tech).
+  // Use this when the wrapping element already owns the checkbox/toggle
+  // semantics (e.g. a toggle button), so we don't nest an interactive
+  // "checkbox" role inside another interactive role (IBM aria_descendant_valid).
+  presentational?: boolean;
+  "aria-label"?: string;
 }) => (
   // Read-only state indicator: activation is owned by the wrapping
   // trigger/tooltip, so it exposes checkbox role + state but stays
   // non-focusable itself.
   <div
-    role="checkbox"
-    aria-checked={Boolean(checked)}
-    aria-readonly="true"
+    role={presentational ? undefined : "checkbox"}
+    aria-hidden={presentational ? "true" : undefined}
+    aria-label={presentational ? undefined : ariaLabel}
+    aria-checked={presentational ? undefined : Boolean(checked)}
+    aria-readonly={presentational ? undefined : "true"}
     className={cn(
       className,
       "peer h-4 w-4 shrink-0 rounded-sm border border-primary ring-offset-background disabled:cursor-not-allowed disabled:opacity-50",

src/frontend/src/components/ui/checkbox.tsx

@@ -13,6 +13,8 @@
   "account.updateAvailable": "(Update verfügbar)",
   "account.version": "Version",
   "admin.attentionTitle": "Achtung!",
+  "admin.backButton": "Zurück",
+  "admin.clearSearch": "Suche löschen",
   "admin.cancelButton": "Abbrechen",
   "admin.cannotDeactivateSelf": "Sie können Ihr eigenes Konto nicht deaktivieren",
   "admin.columnActive": "Aktiv",

src/frontend/src/locales/de.json

@@ -373,6 +373,8 @@
   "admin.deleteTitle": "Delete",
   "admin.deleteUserHeader": "Delete User",
   "admin.attentionTitle": "Attention!",
+  "admin.backButton": "Back",
+  "admin.clearSearch": "Clear search",
   "admin.confirmButton": "Confirm",
   "admin.editUserConfirmContent": "Are you completely confident about the changes you are making to this user?",
   "admin.deleteUserConfirmContent": "Are you sure you want to delete this user? This action cannot be undone.",

src/frontend/src/locales/en.json

@@ -13,6 +13,8 @@
   "account.updateAvailable": "(hay una actualización disponible)",
   "account.version": "Versión",
   "admin.attentionTitle": "Atención",
+  "admin.backButton": "Atrás",
+  "admin.clearSearch": "Borrar búsqueda",
   "admin.cancelButton": "Cancelar",
   "admin.cannotDeactivateSelf": "No puedes desactivar tu propia cuenta",
   "admin.columnActive": "Activo",

src/frontend/src/locales/es.json

@@ -13,6 +13,8 @@
   "account.updateAvailable": "(mise à jour disponible)",
   "account.version": "Version",
   "admin.attentionTitle": "Attention !",
+  "admin.backButton": "Retour",
+  "admin.clearSearch": "Effacer la recherche",
   "admin.cancelButton": "Annuler",
   "admin.cannotDeactivateSelf": "Vous ne pouvez pas désactiver votre propre compte",
   "admin.columnActive": "Actif",

src/frontend/src/locales/fr.json

@@ -13,6 +13,8 @@
   "account.updateAvailable": "（更新あり）",
   "account.version": "バージョン",
   "admin.attentionTitle": "注意",
+  "admin.backButton": "戻る",
+  "admin.clearSearch": "検索をクリア",
   "admin.cancelButton": "キャンセル",
   "admin.cannotDeactivateSelf": "ご自身のアカウントを無効にすることはできません",
   "admin.columnActive": "アクティブ",

src/frontend/src/locales/ja.json

@@ -13,6 +13,8 @@
   "account.updateAvailable": "(atualização disponível)",
   "account.version": "Versão",
   "admin.attentionTitle": "Atenção!",
+  "admin.backButton": "Voltar",
+  "admin.clearSearch": "Limpar pesquisa",
   "admin.cancelButton": "Cancelar",
   "admin.cannotDeactivateSelf": "Você não pode desativar sua própria conta",
   "admin.columnActive": "Ativo",

src/frontend/src/locales/pt.json

@@ -13,6 +13,8 @@
   "account.updateAvailable": "（有更新）",
   "account.version": "版本",
   "admin.attentionTitle": "注意！",
+  "admin.backButton": "返回",
+  "admin.clearSearch": "清除搜索",
   "admin.cancelButton": "取消",
   "admin.cannotDeactivateSelf": "您无法注销自己的账户",
   "admin.columnActive": "活动",