Skip to content

Commit aac79b1

Browse files
fix(ui): replace native select with Radix UI Select in LanguageForm
Swaps the native <select> element for the existing Radix UI Select component to get consistent padding on both sides of the chevron, removing reliance on browser-rendered chevron positioning.
1 parent 3d3a943 commit aac79b1

1 file changed

Lines changed: 22 additions & 15 deletions

File tree

  • src/frontend/src/pages/SettingsPage/pages/GeneralPage/components/LanguageForm

src/frontend/src/pages/SettingsPage/pages/GeneralPage/components/LanguageForm/index.tsx

Lines changed: 22 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,13 @@ import {
1010
CardHeader,
1111
CardTitle,
1212
} from "../../../../../../components/ui/card";
13+
import {
14+
Select,
15+
SelectContent,
16+
SelectItem,
17+
SelectTrigger,
18+
SelectValue,
19+
} from "@/components/ui/select";
1320

1421
const LanguageFormComponent = () => {
1522
const { t, i18n } = useTranslation();
@@ -31,21 +38,21 @@ const LanguageFormComponent = () => {
3138
<CardDescription>{t("settings.languageDescription")}</CardDescription>
3239
</CardHeader>
3340
<CardContent>
34-
<select
35-
aria-label={t("settings.languageSelectAriaLabel")}
36-
value={i18n.language}
37-
onChange={(e) => handleChange(e.target.value)}
38-
className="rounded border border-border bg-background px-2 py-1.5 text-sm text-foreground"
39-
>
40-
{SUPPORTED_LANGUAGES.map((lang) => (
41-
<option key={lang.code} value={lang.code}>
42-
{lang.label}
43-
{lang.code === "en"
44-
? ` (${t("settings.languageRecommended")})`
45-
: ""}
46-
</option>
47-
))}
48-
</select>
41+
<Select value={i18n.language} onValueChange={handleChange}>
42+
<SelectTrigger aria-label={t("settings.languageSelectAriaLabel")}>
43+
<SelectValue />
44+
</SelectTrigger>
45+
<SelectContent>
46+
{SUPPORTED_LANGUAGES.map((lang) => (
47+
<SelectItem key={lang.code} value={lang.code}>
48+
{lang.label}
49+
{lang.code === "en"
50+
? ` (${t("settings.languageRecommended")})`
51+
: ""}
52+
</SelectItem>
53+
))}
54+
</SelectContent>
55+
</Select>
4956
</CardContent>
5057
</Card>
5158
);

0 commit comments

Comments
 (0)