Skip to content

Commit dc26d19

Browse files
committed
fix: Update signature for WXO tests
(cherry picked from commit 981fe5f)
1 parent 0732423 commit dc26d19

4 files changed

Lines changed: 36 additions & 85 deletions

File tree

src/backend/base/langflow/services/adapters/deployment/watsonx_orchestrate/service.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,11 +424,13 @@ async def get(
424424
if not agent:
425425
msg = f"Deployment '{deployment_id}' not found."
426426
raise DeploymentNotFoundError(msg)
427+
environments = get_agent_environments(agent) if isinstance(agent, dict) and "environments" in agent else []
427428
return get_deployment_detail_metadata(
428429
data=agent,
429430
deployment_type=DeploymentType.AGENT,
430431
provider_data={
431432
"tool_ids": extract_agent_tool_ids(agent),
433+
"environment": environments[0] if environments else "unknown",
432434
**({"llm": agent["llm"]} if isinstance(agent, dict) and agent.get("llm") else {}),
433435
},
434436
)

src/backend/tests/unit/services/deployment/test_watsonx_orchestrate.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ async def test_process_config_uses_raw_payload_but_overrides_name(monkeypatch):
355355

356356
captured = {}
357357

358-
async def mock_create_config(*, clients, config, user_id, db): # noqa: ARG001
358+
async def mock_create_config(*, clients, config, user_id, db, created_app_ids_journal=None): # noqa: ARG001
359359
captured["name"] = config.name
360360
captured["env_vars"] = config.environment_variables
361361
return config.name
@@ -1026,7 +1026,7 @@ async def test_update_provider_data_creates_raw_connection_and_raw_tool(monkeypa
10261026
async def mock_get_provider_clients(*, user_id, db): # noqa: ARG001
10271027
return fake_clients
10281028

1029-
async def mock_create_config(*, clients, config, user_id, db): # noqa: ARG001
1029+
async def mock_create_config(*, clients, config, user_id, db, created_app_ids_journal=None): # noqa: ARG001
10301030
captured["created_app_id"] = config.name
10311031
fake_connections._connections_by_app_id[config.name] = f"conn-{config.name}"
10321032
return config.name
@@ -1114,7 +1114,7 @@ async def test_update_provider_data_binds_existing_tool_using_provider_app_id_fo
11141114
async def mock_get_provider_clients(*, user_id, db): # noqa: ARG001
11151115
return fake_clients
11161116

1117-
async def mock_create_config(*, clients, config, user_id, db): # noqa: ARG001
1117+
async def mock_create_config(*, clients, config, user_id, db, created_app_ids_journal=None): # noqa: ARG001
11181118
captured["created_app_id"] = config.name
11191119
fake_connections._connections_by_app_id[config.name] = f"conn-{config.name}"
11201120
return config.name
@@ -1288,7 +1288,10 @@ def test_build_provider_update_plan_preserves_operation_encounter_order():
12881288
assert plan.final_existing_tool_ids == ["tool-a", "tool-c"]
12891289
assert plan.existing_app_ids == ["cfg-2", "cfg-1", "cfg-3"]
12901290
assert [item.operation_app_id for item in plan.raw_connections_to_create] == ["cfg-raw-1", "cfg-raw-2"]
1291-
assert [item.provider_app_id for item in plan.raw_connections_to_create] == ["cfg-raw-1", "cfg-raw-2"]
1291+
assert [item.provider_app_id for item in plan.raw_connections_to_create] == [
1292+
_normalized_provider_app_id("cfg-raw-1"),
1293+
_normalized_provider_app_id("cfg-raw-2"),
1294+
]
12921295
assert len(plan.raw_tools_to_create) == 1
12931296
assert plan.raw_tools_to_create[0].app_ids == ["cfg-raw-2", "cfg-raw-1"]
12941297

@@ -2337,7 +2340,7 @@ async def test_update_provider_data_maps_raw_connection_conflict_to_deployment_c
23372340
async def mock_get_provider_clients(*, user_id, db): # noqa: ARG001
23382341
return fake_clients
23392342

2340-
async def mock_create_config(*, clients, config, user_id, db): # noqa: ARG001
2343+
async def mock_create_config(*, clients, config, user_id, db, created_app_ids_journal=None): # noqa: ARG001
23412344
response = SimpleNamespace(status_code=409, text='{"detail":"already exists"}')
23422345
raise ClientAPIException(response=response)
23432346

@@ -2400,7 +2403,7 @@ async def test_create_provider_data_maps_raw_connection_conflict_to_deployment_c
24002403
async def mock_get_provider_clients(*, user_id, db): # noqa: ARG001
24012404
return fake_clients
24022405

2403-
async def mock_create_config(*, clients, config, user_id, db): # noqa: ARG001
2406+
async def mock_create_config(*, clients, config, user_id, db, created_app_ids_journal=None): # noqa: ARG001
24042407
captured["attempted_app_id"] = config.name
24052408
response = SimpleNamespace(status_code=409, text='{"detail":"already exists"}')
24062409
raise ClientAPIException(response=response)
@@ -2595,7 +2598,7 @@ async def test_update_provider_data_rolls_back_partially_created_raw_tools(monke
25952598
async def mock_get_provider_clients(*, user_id, db): # noqa: ARG001
25962599
return fake_clients
25972600

2598-
async def mock_create_config(*, clients, config, user_id, db): # noqa: ARG001
2601+
async def mock_create_config(*, clients, config, user_id, db, created_app_ids_journal=None): # noqa: ARG001
25992602
fake_connections._connections_by_app_id[config.name] = f"conn-{config.name}"
26002603
return config.name
26012604

0 commit comments

Comments
 (0)