LEGLINK-820: Delete reporting plans as a set rather than a row at a time

DeleteAllAsync and DeleteForFacilityAsync loaded every matching plan into the
change tracker and issued one DELETE per row. The table grows by a row per
facility, measure mapping and month, so once the sync stories populate it those
two endpoints would hold the whole table in memory and send a statement per row.

The repository gains ExecuteDeleteAsync, which deletes by predicate in a single
statement and returns the number of rows removed. It does not load or track the
rows, so it takes no part in a pending SaveChanges - which suits these two
actions, where the delete is the whole request.

DeleteForFacilityAsync now logs the rows the database actually removed instead of
a count taken before the delete.

The manager tests assert that GetAllAsync, FindAsync and Remove are no longer
called, so the load-then-delete pattern cannot return unnoticed, and that the
by-facility predicate matches only that facility rather than clearing the table.

Update also compares the two ids after the same normalization. The url id was
sanitized and the body id was not, so a client sending the identical raw string
in both places could be told they did not match.

The module registers AddHttpClient itself. Its fallback facility lookup resolves
IHttpClientFactory, which happened to work only because the Tenant host asks for
one; a host that did not would fail to resolve the service.

Claude-Session: https://claude.ai/code/session_0135KKpfA98BKzyQAsGS5kmg

Author: arianamihailescu

DotNet/DMRP/Business/Managers/FacilityReportingPlanManager.cs

@@ -142,13 +142,11 @@ public async Task DeleteAsync(string id, CancellationToken cancellationToken = d
             await _repository.SaveChangesAsync(cancellationToken);
         }
 
-        public async Task<int> DeleteAllAsync(CancellationToken cancellationToken = default)
+        public Task<int> DeleteAllAsync(CancellationToken cancellationToken = default)
         {
             using Activity? activity = ServiceActivitySource.Instance.StartActivity("Delete All Facility Reporting Plans");
 
-            var existing = await _repository.GetAllAsync(cancellationToken);
-
-            return await RemoveRangeAsync(existing, cancellationToken);
+            return _repository.ExecuteDeleteAsync(_ => true, cancellationToken);
         }
 
         public async Task<int> DeleteForFacilityAsync(string facilityId, CancellationToken cancellationToken = default)
@@ -160,29 +158,12 @@ public async Task<int> DeleteForFacilityAsync(string facilityId, CancellationTok
                 throw new ApplicationException("FacilityId is required.");
             }
 
-            var existing = await _repository.FindAsync(p => p.FacilityId == facilityId, cancellationToken);
-
-            _logger.LogInformation("Removing {Count} reporting plan(s) for facility {FacilityId}",
-                existing.Count, facilityId.SanitizeForLog());
-
-            return await RemoveRangeAsync(existing, cancellationToken);
-        }
-
-        private async Task<int> RemoveRangeAsync(List<FacilityReportingPlan> plans, CancellationToken cancellationToken)
-        {
-            if (plans.Count == 0)
-            {
-                return 0;
-            }
-
-            foreach (var plan in plans)
-            {
-                _repository.Remove(plan);
-            }
+            var removed = await _repository.ExecuteDeleteAsync(p => p.FacilityId == facilityId, cancellationToken);
 
-            await _repository.SaveChangesAsync(cancellationToken);
+            _logger.LogInformation("Removed {Count} reporting plan(s) for facility {FacilityId}",
+                removed, facilityId.SanitizeForLog());
 
-            return plans.Count;
+            return removed;
         }
 
         /// <summary>

DotNet/DMRP/Controllers/FacilityReportingPlansController.cs

@@ -221,12 +221,14 @@ public async Task<IActionResult> UpdateFacilityReportingPlan(string id, Facility
                 return BadRequest("A facility reporting plan is required.");
             }
 
-            if (string.IsNullOrWhiteSpace(request.Id))
+            var requestId = request.Id?.Sanitize();
+
+            if (string.IsNullOrWhiteSpace(requestId))
             {
                 return BadRequest("Id is required in the request body.");
             }
 
-            if (request.Id != id)
+            if (requestId != id)
             {
                 return BadRequest("Id in the URL must match the Id in the request body.");
             }

DotNet/DMRP/DependencyInjection/DmrpModuleExtensions.cs

@@ -70,6 +70,7 @@ private static void AddFacilityVerification(WebApplicationBuilder builder)
                 }
             });
 
+            builder.Services.AddHttpClient();
             builder.Services.TryAddTransient<ITenantApiService, TenantApiService>();
             builder.Services.TryAddScoped<IFacilityExistence, TenantApiFacilityExistence>();
         }

DotNet/ServiceTests/UnitTests/DMRP/FacilityReportingPlanManagerTests.cs

@@ -321,46 +321,43 @@ public async Task DeleteAsync_ExistingId_RemovesTheRow()
         [Fact]
         public async Task DeleteAllAsync_RemovesEveryRowAndReportsHowMany()
         {
-            var plans = new List<FacilityReportingPlan> { ValidPlan(), ValidPlan(), ValidPlan() };
-
-            _mockRepository.Setup(r => r.GetAllAsync(It.IsAny<CancellationToken>()))
-                .ReturnsAsync(plans);
+            _mockRepository.Setup(r => r.ExecuteDeleteAsync(It.IsAny<Expression<Func<FacilityReportingPlan, bool>>>(), It.IsAny<CancellationToken>()))
+                .ReturnsAsync(3);
 
             var removed = await _manager.DeleteAllAsync();
 
             Assert.Equal(3, removed);
-            foreach (var plan in plans)
-            {
-                _mockRepository.Verify(r => r.Remove(plan), Times.Once);
-            }
-
-            _mockRepository.Verify(r => r.SaveChangesAsync(It.IsAny<CancellationToken>()), Times.Once);
+            _mockRepository.Verify(r => r.GetAllAsync(It.IsAny<CancellationToken>()), Times.Never);
+            _mockRepository.Verify(r => r.Remove(It.IsAny<FacilityReportingPlan>()), Times.Never);
         }
 
         [Fact]
-        public async Task DeleteAllAsync_EmptyTable_TouchesNothing()
+        public async Task DeleteAllAsync_EmptyTable_ReportsNothingRemoved()
         {
-            _mockRepository.Setup(r => r.GetAllAsync(It.IsAny<CancellationToken>()))
-                .ReturnsAsync(new List<FacilityReportingPlan>());
+            _mockRepository.Setup(r => r.ExecuteDeleteAsync(It.IsAny<Expression<Func<FacilityReportingPlan, bool>>>(), It.IsAny<CancellationToken>()))
+                .ReturnsAsync(0);
 
-            var removed = await _manager.DeleteAllAsync();
-
-            Assert.Equal(0, removed);
-            _mockRepository.Verify(r => r.SaveChangesAsync(It.IsAny<CancellationToken>()), Times.Never);
+            Assert.Equal(0, await _manager.DeleteAllAsync());
         }
 
         [Fact]
         public async Task DeleteForFacilityAsync_RemovesThatFacilitysRowsAndReportsHowMany()
         {
-            var plans = new List<FacilityReportingPlan> { ValidPlan(), ValidPlan() };
+            Expression<Func<FacilityReportingPlan, bool>>? captured = null;
 
-            _mockRepository.Setup(r => r.FindAsync(It.IsAny<Expression<Func<FacilityReportingPlan, bool>>>(), It.IsAny<CancellationToken>()))
-                .ReturnsAsync(plans);
+            _mockRepository.Setup(r => r.ExecuteDeleteAsync(It.IsAny<Expression<Func<FacilityReportingPlan, bool>>>(), It.IsAny<CancellationToken>()))
+                .Callback((Expression<Func<FacilityReportingPlan, bool>> p, CancellationToken _) => captured = p)
+                .ReturnsAsync(2);
 
             var removed = await _manager.DeleteForFacilityAsync(FacilityId);
 
             Assert.Equal(2, removed);
-            _mockRepository.Verify(r => r.SaveChangesAsync(It.IsAny<CancellationToken>()), Times.Once);
+            _mockRepository.Verify(r => r.FindAsync(It.IsAny<Expression<Func<FacilityReportingPlan, bool>>>(), It.IsAny<CancellationToken>()), Times.Never);
+
+            Assert.NotNull(captured);
+            var matches = captured!.Compile();
+            Assert.True(matches(new FacilityReportingPlan { FacilityId = FacilityId }));
+            Assert.False(matches(new FacilityReportingPlan { FacilityId = "another-facility" }));
         }
 
         [Fact]

DotNet/Shared/Domain/Repositories/Implementations/EntityRepository.cs

@@ -56,6 +56,17 @@ public void Remove(T entity)
             _dbContext.Set<T>().Remove(entity);
         }
 
+        public Task<int> ExecuteDeleteAsync(Expression<Func<T, bool>> predicate)
+        {
+            return ExecuteDeleteAsync(predicate, CancellationToken.None);
+        }
+
+        public async Task<int> ExecuteDeleteAsync(Expression<Func<T, bool>> predicate, CancellationToken cancellationToken)
+        {
+            cancellationToken.ThrowIfCancellationRequested();
+            return await _dbContext.Set<T>().Where(predicate).ExecuteDeleteAsync(cancellationToken);
+        }
+
         // Query Methods
         public Task<bool> AnyAsync(Expression<Func<T, bool>> predicate)
         {

DotNet/Shared/Domain/Repositories/Interfaces/IEntityRepository.cs

@@ -25,6 +25,10 @@ public interface IEntityRepository<T>
         Task<T> SingleAsync(Expression<Func<T, bool>> predicate);
         Task<T> SingleAsync(Expression<Func<T, bool>> predicate, CancellationToken cancellationToken);
         void Remove(T entity);
+
+        Task<int> ExecuteDeleteAsync(Expression<Func<T, bool>> predicate);
+        Task<int> ExecuteDeleteAsync(Expression<Func<T, bool>> predicate, CancellationToken cancellationToken);
+
         void Update(T entity);
         Task<(List<T>, PaginationMetadata)> SearchAsync(Expression<Func<T, bool>> predicate, string? sortBy, SortOrder? sortOrder, int pageSize, int pageNumber);
         Task<(List<T>, PaginationMetadata)> SearchAsync(Expression<Func<T, bool>> predicate, string? sortBy, SortOrder? sortOrder, int pageSize, int pageNumber, CancellationToken cancellationToken);