Commit a692b56
committed
LEGLINK-822: Add the mock DMRP API to the build-and-push script
Raised in review on PR #1800.
set_kubernetes_services.bat gained a mock-dmrp line earlier on this branch, but
build_and_push_and_set.py carries the same per-service inventory -- repo,
deployment and container, plus the Dockerfile and build context the .bat has no
need for -- and had no entry at all. Without one the mock could not be built,
pushed or deployed through the script, and --all-services silently skipped it.
Every value is taken from the deployment definitions rather than inferred:
- link-mock-dmrp from registry-repo-Name in
azure-pipelines.mockdmrpapi.cd.yaml
- mock-dmrp-deploy and mock-dmrp from _deploy_all_services.yml, which builds
"deployment $(serviceName)-deploy $(containerName)=..." out of
serviceName: mock-dmrp and containerName: mock-dmrp
- DotNet/MockDmrpApi/Dockerfile with a repository-root context, from
docker-compose.yml
The docstring's recognized-services list is updated too. It is not decoration:
the same list is printed when an unrecognised --service is passed, and an
unknown service now reports mock-dmrp-api among the valid ones.
The entry carries a comment about where it differs from the others. The mock is
deployed to the lower environments only, and unlike the .bat -- which runs its
kubectl lines unconditionally and merely prints an error for a deployment that
is absent -- this script exits on a failed command, so selecting the mock
against a namespace without mock-dmrp-deploy would stop every service queued
behind it alphabetically.
Verified the module parses, --help runs, the SERVICES keys are still in
alphabetical order, and an unknown --service lists the new name.
One thing found and deliberately not changed: this inventory exists in three
places, and _deploy_all_services.yml -- the one CI actually runs -- has an
automation entry that appears in neither script. That drift predates this
ticket and is the opposite direction from the gap fixed here.1 parent b9bfeef commit a692b56
1 file changed
Lines changed: 6 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
| 26 | + | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
47 | 51 | | |
48 | 52 | | |
49 | 53 | | |
| |||
0 commit comments