Phase 2C: remove PropertiesEnhancer from enhancer pipeline

- EnhancerPlugin: drop new PropertiesEnhancer() from defaultEnhancers(); ConstructorEnhancer already handles constructor generation
- BeanWrapper: remove @PlayPropertyAccessor import and filter from isSetter/isScalaSetter; no such methods exist now that PropertiesEnhancer is off
- PropertiesEnhancer: flip default of play.propertiesEnhancer.enabled from true to false; enhancer remains available as an explicit opt-in

Author: megamattron

framework/src/play/classloading/enhancers/PropertiesEnhancer.java

@@ -29,7 +29,7 @@
  */
 public class PropertiesEnhancer extends Enhancer {
 
-    private final boolean enabled = Boolean.parseBoolean(Play.configuration.getProperty("play.propertiesEnhancer.enabled", "true"));
+    private final boolean enabled = Boolean.parseBoolean(Play.configuration.getProperty("play.propertiesEnhancer.enabled", "false"));
     private final boolean generateAccessors = Boolean.parseBoolean(Play.configuration.getProperty("play.propertiesEnhancer.generateAccessors", "true"));
 
     @Override

framework/src/play/data/binding/BeanWrapper.java

@@ -5,7 +5,6 @@
 import java.util.*;
 
 import play.Logger;
-import play.classloading.enhancers.PropertiesEnhancer.PlayPropertyAccessor;
 import play.exceptions.UnexpectedException;
 
 /**
@@ -63,11 +62,11 @@ public void set(String name, Object instance, Object value) {
     }
 
     private boolean isSetter(Method method) {
-        return (!method.isAnnotationPresent(PlayPropertyAccessor.class) && method.getName().startsWith("set") && method.getName().length() > 3 && method.getParameterTypes().length == 1 && (method.getModifiers() & notaccessibleMethod) == 0);
+        return (method.getName().startsWith("set") && method.getName().length() > 3 && method.getParameterTypes().length == 1 && (method.getModifiers() & notaccessibleMethod) == 0);
     }
 
     private boolean isScalaSetter(Method method) {
-        return (!method.isAnnotationPresent(PlayPropertyAccessor.class) && method.getName().endsWith("_$eq") && method.getParameterTypes().length == 1 && (method.getModifiers() & notaccessibleMethod) == 0);
+        return (method.getName().endsWith("_$eq") && method.getParameterTypes().length == 1 && (method.getModifiers() & notaccessibleMethod) == 0);
     }
 
     protected Object newBeanInstance() throws InstantiationException, IllegalAccessException, NoSuchMethodException, InvocationTargetException {

framework/src/play/plugins/EnhancerPlugin.java

@@ -12,7 +12,7 @@
 public class EnhancerPlugin extends PlayPlugin {
 
     protected Enhancer[] defaultEnhancers() {
-        return new Enhancer[] { new ConstructorEnhancer(), new PropertiesEnhancer(), new ContinuationEnhancer(), new SigEnhancer(), new ControllersEnhancer(),
+        return new Enhancer[] { new ConstructorEnhancer(), new ContinuationEnhancer(), new SigEnhancer(), new ControllersEnhancer(),
                 new MailerEnhancer(), new LocalvariablesNamesEnhancer() };
     }