Revert equal comparisons in templates.

laurentmuller · laurentmuller · commit 3f41dc43acc4 · 2026-08-05T07:38:54.000+02:00
diff --git a/templates/about/_about_macro.html.twig b/templates/about/_about_macro.html.twig
@@ -49,7 +49,7 @@
 {%- endmacro rowInfoLink %}
 
 {% macro rowInfoBoolean(name, value, enabled) -%}
-    {%- if value === true or value === false -%}
+    {%- if value == true or value == false -%}
         {%- set enabled = value -%}
         {%- set value = value|boolean -%}
     {%- endif -%}
diff --git a/templates/admin/product_query.html.twig b/templates/admin/product_query.html.twig
@@ -43,7 +43,7 @@
 {%- set title = 'product.update.title' -%}
 {%- set title_icon = ICON_PRODUCT -%}
 {%- set title_description = 'product.update.description' -%}
-{%- set is_percent = form.type.vars.value === 'percent' -%}
+{%- set is_percent = form.type.vars.value == 'percent' -%}
 {%- set percent_attr = is_percent ? {} : {disabled: 'disabled'} -%}
 {%- set fixed_attr = is_percent ? {disabled: 'disabled'} : {} -%}
 {%- set category_id = form.category.vars.value|default(0) -%}
diff --git a/templates/calculation/calculation_pivot.html.twig b/templates/calculation/calculation_pivot.html.twig
@@ -133,15 +133,15 @@
 
 {%- macro output_month(month, selection) %}
     {% set attrs = {
-        class: ['dropdown-item', month === selection ? 'dropdown-item-checked-right'],
+        class: ['dropdown-item', month == selection ? 'dropdown-item-checked-right'],
         href: path('calculation_pivot_index', {months: month}),
     } %}
     <li><a {{ html_attr(attrs) }}>{{ 'counters.months'|trans({count: month}) }}</a></li>
 {% endmacro output_month -%}
 
 {%- macro output_operation(operation, selection) %}
     {% set attrs = {
-        class: ['dropdown-item', operation === selection ? 'dropdown-item-checked-right'],
+        class: ['dropdown-item', operation == selection ? 'dropdown-item-checked-right'],
         href: path('calculation_pivot_index', {operation: operation.value}),
     } %}
     <li><a {{ html_attr(attrs) }}>{{ operation|trans }}</a></li>
@@ -228,13 +228,13 @@
             <thead>
             {%- for i in 1..max_col_level -%}
                 <tr>
-                    {%- if i === 1 -%}
+                    {%- if i == 1 -%}
                         <td class="text-nowrap not-hover p-0"{{ _self.rowspan(max_col_level) }}{{ _self.colspan(max_row_level) }}>
                             {{- _self.outputTitle(table, max_col_level) -}}
                         </td>
                     {%- endif -%}
                     {{ _self.outputHeaders(table.rootColumn.nodesAtLevel(i), separator) }}
-                    {%- if i === 1 -%}
+                    {%- if i == 1 -%}
                         <td{{ _self.rowspan(max_col_level) }} class="text-currency text-bg-success not-hover align-bottom">
                             {{- total_title -}}
                         </td>
diff --git a/templates/calculation/calculation_table.html.twig b/templates/calculation/calculation_table.html.twig
@@ -19,7 +19,7 @@
     {% if state_id != 0 %}
         {% set text = customData.state.code %}
     {% elseif state_editable != 0 %}
-        {% set text = (state_editable === 1 ? 'calculationstate.list.editable_1' : 'calculationstate.list.editable_0')|trans %}
+        {% set text = (state_editable == 1 ? 'calculationstate.list.editable_1' : 'calculationstate.list.editable_0')|trans %}
     {% endif %}
     {{ _self.output_dropdown_menu('state', ICON_CALCULATION_STATE, text, 'calculation.list.state_help', input_value, data_default) }}
     <ul class="dropdown-menu" aria-labelledby="state">
diff --git a/templates/cards/card_table.html.twig b/templates/cards/card_table.html.twig
@@ -30,7 +30,7 @@
         type: 'button',
         role: 'button',
         'data-value': value,
-        class: ['dropdown-item dropdown-' ~ suffix, value === selection ? 'active']})
+        class: ['dropdown-item dropdown-' ~ suffix, value == selection ? 'active']})
     %}
     <li>
         <button {{ html_attr(attributes) }}>
@@ -107,7 +107,7 @@
 {# output a drop-down view item #}
 {% macro button_view(icon, view, selection) %}
 <li>
-    <button type="button" class="dropdown-item dropdown-menu-view{% if view === selection %} dropdown-item-checked-right{% endif %}" data-value="{{ view }}">
+    <button type="button" class="dropdown-item dropdown-menu-view{% if view == selection %} dropdown-item-checked-right{% endif %}" data-value="{{ view }}">
         {{- icon(icon ~ ' fa-fw', 'table_view.' ~ view) -}}
     </button>
 </li>
@@ -278,7 +278,7 @@
     </thead>
     <tbody{% if row_link|default(true) %} data-link="row" class="rowlink" data-target="a.btn-default"{% endif %}>
         {% for row in rows %}
-        <tr{% if row.id === id %} class="{{ row_selector }}"{%- set row_selector = '' -%}{% endif %}>
+        <tr{% if row.id == id %} class="{{ row_selector }}"{%- set row_selector = '' -%}{% endif %}>
             {% for column in columns %}
             <td>{{ row[column.alias]|raw }}</td>
             {% endfor %}
diff --git a/templates/chart/chart_month.html.twig b/templates/chart/chart_month.html.twig
@@ -12,7 +12,7 @@
 {% macro cell_value(value, previous, user_percent = false) -%}
     {% if not previous %}
         {% set icon = false %}
-    {% elseif previous === value %}
+    {% elseif previous == value %}
         {% set icon = 'right' %}
         {% set color = 'text-secondary' %}
     {% elseif previous < value %}
@@ -51,7 +51,7 @@
             -}}
             <ul class="dropdown-menu dropdown-menu-end">
                 {% for value in allowedMonths %}
-                    {{ _self.month(value, value === months) }}
+                    {{ _self.month(value, value == months) }}
                 {% endfor %}
             </ul>
         {% endif %}
diff --git a/templates/command/commands.html.twig b/templates/command/commands.html.twig
@@ -17,7 +17,7 @@
             {% for key, names in commands %}
                 <optgroup label="{{ key }}">
                     {% for name in names %}
-                        <option{% if name === command.name %} selected{% endif %}>{{ name }}</option>
+                        <option{% if name == command.name %} selected{% endif %}>{{ name }}</option>
                     {% endfor %}
                 </optgroup>
             {% endfor %}
diff --git a/templates/dialog/dialog_table_sort.html.twig b/templates/dialog/dialog_table_sort.html.twig
@@ -35,7 +35,7 @@
                     </div>
                 </div>
                 {% if column %}
-                    {% set key = column.order === 'asc' ? 'list.sort_ascending_title' : 'list.sort_descending_title' %}
+                    {% set key = column.order == 'asc' ? 'list.sort_ascending_title' : 'list.sort_descending_title' %}
                     <div class="small text-body-tertiary mt-2">{{ key|trans({'%name%': column.title}) }}</div>
                 {% endif %}
             </div>
diff --git a/templates/dialog/dialog_theme.html.twig b/templates/dialog/dialog_theme.html.twig
@@ -42,7 +42,7 @@
             <div class="modal-body mx-3">
                 <span class="form-label mb-3">{{ 'theme.help'|trans }}</span>
                 {% for theme in themes() %}
-                    {{ _self.output_theme(theme: theme, checked: theme === selection) }}
+                    {{ _self.output_theme(theme: theme, checked: theme == selection) }}
                 {% endfor %}
             </div>
             <div class="modal-footer">
diff --git a/templates/footer.html.twig b/templates/footer.html.twig
@@ -4,7 +4,7 @@
         <span class="navbar-text text-truncate text-danger border-end border-secondary d-none" id="footer-message">
             {{- 'common.data_changed'|trans -}}
         </span>
-        <a class="nav-link text-truncate border-end border-secondary{% if app.current_route === 'about_index' %} active{% endif %}" href="{{ path('about_index') }}" title="{{ 'footer.about_title'|trans }}">
+        <a class="nav-link text-truncate border-end border-secondary{% if app.current_route == 'about_index' %} active{% endif %}" href="{{ path('about_index') }}" title="{{ 'footer.about_title'|trans }}">
             {{- app_full_name -}}
         </a>
         <span class="navbar-text text-truncate border-end border-secondary" title="{{ 'footer.environment_title'|trans }}">
diff --git a/templates/help/_help_tools.html.twig b/templates/help/_help_tools.html.twig
@@ -100,15 +100,15 @@
         <ul>
             {% for link in links %}
                 {% set type = link.type|default %}
-                {% if type === 'dialog' %}
+                {% if type == 'dialog' %}
                     {%- set dialog = service.findDialog(link.id) -%}
                     {% if dialog %}
                         {%- set href = path('help_dialog', {id: dialog.id}) -%}
                         <li>
                             <a href="{{ href }}">{{- _self.output_icon('fa-regular fa-file-code', dialog.name) -}}</a>
                         </li>
                     {% endif %}
-                {% elseif type === 'entity' %}
+                {% elseif type == 'entity' %}
                     {%- set entity = service.findEntity(link.id) -%}
                     {% if entity %}
                         {%- set href = path('help_entity', {id: entity.id}) -%}
diff --git a/templates/index/_calculation_card.html.twig b/templates/index/_calculation_card.html.twig
@@ -4,7 +4,7 @@
     {%- set is_editable = calculation.stateEditable -%}
     {%- set params = route_params(app.request, id)|merge({caller: caller}) -%}
     {% set class_name = 'row-item item-hover cursor-default border text-border h-100 px-2 py-1' %}
-    {% if id === selection %}
+    {% if id == selection %}
         {% set class_name = class_name ~ ' table-primary' %}
     {% endif %}
     {% if not is_editable %}
diff --git a/templates/index/_calculation_header.html.twig b/templates/index/_calculation_header.html.twig
@@ -10,7 +10,7 @@
 {%- endmacro button_view %}
 {% macro button_counter(value, selection) %}
 <li>
-    <button class="dropdown-item dropdown-item-counter{% if value === selection %} dropdown-item-checked-right{% endif %}" data-value="{{ value }}" >
+    <button class="dropdown-item dropdown-item-counter{% if value == selection %} dropdown-item-checked-right{% endif %}" data-value="{{ value }}" >
         {{- 'counters.calculations'|trans({count: value}) -}}
     </button>
 </li>
diff --git a/templates/index/_calculation_table.html.twig b/templates/index/_calculation_table.html.twig
@@ -6,7 +6,7 @@
             {%- set is_editable = calculation.stateEditable -%}
             {%- set params = route_params(app.request, id)|merge({caller: caller}) -%}
             {% set class_name = 'row-item' %}
-            {% if id === selection %}
+            {% if id == selection %}
                 {% set class_name = class_name ~ ' table-primary' %}
             {% endif %}
             {% if not is_editable %}
diff --git a/templates/macros/_icons.html.twig b/templates/macros/_icons.html.twig
@@ -283,7 +283,7 @@
 
 {% macro sitemap() -%}
     {% set caller = app.request.query.string('caller')|default %}
-    {% if app.user and caller === path('site_map') %}
+    {% if app.user and caller == path('site_map') %}
         {{- _self.link(
             href: caller,
             text: 'index.menu_site_map',
diff --git a/templates/macros/_margins_edit.html.twig b/templates/macros/_margins_edit.html.twig
@@ -35,7 +35,7 @@
 {# output all margins #}
 {% macro outputMargins(margins) %}
 {%- set margins_length = margins|length %}
-{%- set table_class = 'table table-borderless table-edit' ~ (margins_length === 0 ? ' d-none' : '') -%}
+{%- set table_class = 'table table-borderless table-edit' ~ (margins_length == 0 ? ' d-none' : '') -%}
 <div class="d-flex-wrap-center">
     <span class="form-label me-auto">{{ 'group.fields.margins'|trans }}</span>
     <div class="mb-2 d-print-none">
diff --git a/templates/navigation/horizontal/navigation.html.twig b/templates/navigation/horizontal/navigation.html.twig
@@ -53,7 +53,7 @@
                 {% endif %}
             </ul>
             <ul class="navbar-nav">
-                {% if is_granted_data and app.current_route !== 'search' -%}
+                {% if is_granted_data and app.current_route != 'search' -%}
                     {{ include('navigation/horizontal/navigation_search.html.twig') }}
                 {% endif %}
                 {% if is_granted(IS_AUTHENTICATED_REMEMBERED) -%}
diff --git a/templates/navigation/menu/_menu_theme.html.twig b/templates/navigation/menu/_menu_theme.html.twig
@@ -14,7 +14,7 @@
                 name: 'radio-theme',
                 id: 'radio-theme-' ~ theme.value,
                 autocomplete: 'off',
-                checked: theme === current,
+                checked: theme == current,
                 value: theme.value,
                 'data-success': theme.success|trans,
             } %}
diff --git a/templates/notification/csp_violation.html.twig b/templates/notification/csp_violation.html.twig
@@ -10,7 +10,7 @@
     <container>
         <table id="csp">
             {% for key, value in context %}
-                {% if 'original-policy' === key %}
+                {% if 'original-policy' == key %}
                     <tr>
                         <td colspan="2"><u>{{ key }}</u></td>
                     </tr>
diff --git a/templates/openweather/_weather_daily.html.twig b/templates/openweather/_weather_daily.html.twig
@@ -9,7 +9,7 @@
             {% for data in daily.list %}
             <tr>
                 <td class="ow-date">
-                    {%- if loop.index === 1 -%}
+                    {%- if loop.index == 1 -%}
                         {{- 'openweather.current.today'|trans -}}
                     {%- else -%}
                         {{- data.dt|locale_date('none', 'eeee') }}
diff --git a/templates/product/product_macro_category.html.twig b/templates/product/product_macro_category.html.twig
@@ -1,4 +1,4 @@
 {# create a category entry - used by the product list #}
 {% macro categoryEntry(value, text, selection) %}
-    <option value="{{ value }}"{% if value === selection %} selected{% endif %}>{{ text }}</option>
+    <option value="{{ value }}"{% if value == selection %} selected{% endif %}>{{ text }}</option>
 {% endmacro categoryEntry %}
diff --git a/templates/sitemap/sitemap.html.twig b/templates/sitemap/sitemap.html.twig
@@ -29,7 +29,7 @@
 {# output entry content #}
 {% macro entry_content(entry, route) %}
     {% set icon = entry.icon ?? false %}
-    {% if route === constant('App\\Controller\\SiteMapController::LOGOUT_ROUTE') %}
+    {% if route == constant('App\\Controller\\SiteMapController::LOGOUT_ROUTE') %}
         <a href="{{ logout_path() }}">{{ icon(icon: icon, text: entry.text) }}</a>
     {% elseif route and entry.external|default(false) %}
         {{ linkExternal(
diff --git a/templates/task/_task_table.html.twig b/templates/task/_task_table.html.twig
@@ -30,9 +30,9 @@
     </div>
     {# items #}
     {% for task in tasks %}
-        {% set visible = loop.index === 1 %}
+        {% set visible = loop.index == 1 %}
         {% set items = task.items|filter(item => item.count > 0) %}
-        {% set disabled = items|length === 1 %}
+        {% set disabled = items|length == 1 %}
         {% for item in items %}
             {{ _self.task_item_input(task, item, visible, disabled) }}
         {% endfor %}
diff --git a/templates/task/task_compute.html.twig b/templates/task/task_compute.html.twig
@@ -23,7 +23,7 @@
         {{ form_row(form.quantity) }}
     </div>
 </div>
-<div class="row-table{% if tasks_count === 0 %} d-none{% endif %}">
+<div class="row-table{% if tasks_count == 0 %} d-none{% endif %}">
     {{ include('task/_task_table.html.twig', tasks) }}
 </div>
 <div class="row-empty{% if tasks_count != 0 %} d-none{% endif %}">
diff --git a/templates/task/task_edit.html.twig b/templates/task/task_edit.html.twig
@@ -55,7 +55,7 @@
                 </div>
             </div>
             <hr class="my-0">
-            <table class="table table-borderless table-sm table-edit{% if count === 0 %} d-none{% endif %}" data-prototype="{{ outputMarginRow(item.margins.vars.prototype)|e('html_attr') }}">
+            <table class="table table-borderless table-sm table-edit{% if count == 0 %} d-none{% endif %}" data-prototype="{{ outputMarginRow(item.margins.vars.prototype)|e('html_attr') }}">
                 <thead>
                     <tr>
                         <th class="vertical-middle text-end fw-normal required">{{ 'taskitemmargin.fields.minimum'|trans }}</th>
@@ -119,7 +119,7 @@
 </div>
 <div class="items list-group" id="items" data-item-index="{{ item_index }}" data-margin-index="{{ margin_index }}" data-prototype="{{ _self.outputTaskItem(form.items.vars.prototype, true)|e('html_attr') }}">
     {% for item in form.items -%}
-        {{ _self.outputTaskItem(item, loop.index === 1) }}
+        {{ _self.outputTaskItem(item, loop.index == 1) }}
     {% endfor -%}
 </div>
 <small class="text-body-secondary empty-items{% if form.vars.value.count > 0 %} d-none{% endif %}">{{- 'task.edit.empty_items'|trans -}}</small>
diff --git a/templates/task/task_show.html.twig b/templates/task/task_show.html.twig
@@ -25,7 +25,7 @@
     <tbody>
     {% for margin in child.margins %}
         <tr>
-            <td>{{ loop.index === 1 ? child.name : '&nbsp;'|raw }}</td>
+            <td>{{ loop.index == 1 ? child.name : '&nbsp;'|raw }}</td>
             <td class="text-currency">{{ margin.minimum|amount }}</td>
             <td class="text-currency">{{ margin.maximum|amount }}</td>
             <td class="text-currency">{{ margin.value|amount }}</td>
diff --git a/templates/test/diagram.html.twig b/templates/test/diagram.html.twig
@@ -20,7 +20,7 @@
         <div class="input-group input-group-sm">
             <select class="form-select form-select-sm w-auto" id="diagrams" name="diagrams" title="{{ 'diagram.list'|trans }}">
                 {% for current in diagrams %}
-                    <option value="{{ current.name }}"{% if current === diagram %} selected{% endif %}>
+                    <option value="{{ current.name }}"{% if current == diagram %} selected{% endif %}>
                         {{- current.title -}}
                     </option>
                 {% endfor %}
diff --git a/templates/test/exchange_rate.html.twig b/templates/test/exchange_rate.html.twig
@@ -4,12 +4,12 @@
 {% macro fillCodes(codes, selection = '') %}
     {% for key, code in codes -%}
         <option value="{{ key }}" data-name="{{ code.symbol }}"
-                data-digits="{{ code.fractionDigits }}"{% if key === selection %} selected{% endif %}>{{ code.name ~ ' - ' ~ code.symbol }}</option>
+                data-digits="{{ code.fractionDigits }}"{% if key == selection %} selected{% endif %}>{{ code.name ~ ' - ' ~ code.symbol }}</option>
     {% endfor -%}
 {% endmacro fillCodes %}
 {% macro fillEntries(codes, selection = '') %}
     {% for key, code in codes -%}
-        <button class="dropdown-item{% if key === selection %} active{% endif %}" type="button" data-value="{{ key }}"
+        <button class="dropdown-item{% if key == selection %} active{% endif %}" type="button" data-value="{{ key }}"
                 data-name="{{ code.symbol }}"
                 data-digits="{{ code.fractionDigits }}">{{ code.name ~ ' - ' ~ code.symbol }}</button>
     {% endfor -%}
diff --git a/templates/test/notification.html.twig b/templates/test/notification.html.twig
@@ -27,21 +27,21 @@
 {% macro position(position, selection) -%}
     {% set attrs = {
         value: position.value,
-        selected: position === selection} %}
+        selected: position == selection} %}
     <option {{ html_attr(attrs) }}>{{ position|trans }}</option>
 {%- endmacro position %}
 
 {% macro timeout(seconds, selection) -%}
     {% set attrs = {
         value: seconds * 1000,
-        selected: seconds * 1000 === selection} %}
+        selected: seconds * 1000 == selection} %}
     <option {{ html_attr(attrs) }}>{{ 'counters.seconds'|trans({'%count%': seconds}) }}</option>
 {%- endmacro timeout %}
 
 {% macro progress(pixels, selection) -%}
     {% set attrs = {
         value: pixels,
-        selected: pixels === selection} %}
+        selected: pixels == selection} %}
     <option {{ html_attr(attrs) }}>{{ 'counters.pixels'|trans({'%count%': pixels}) }}</option>
 {%- endmacro progress %}
 
@@ -115,7 +115,7 @@
             <label class="form-label" for="maxNbChars">Nombre de caractères</label>
             <select id="maxNbChars" name="maxNbChars" data-default="{{ selection }}" class="form-select">
                 {% for i in range(50, 500, 50) %}
-                    <option value="{{ i }}"{% if i === selection %} selected{% endif %}>{{ i }}</option>
+                    <option value="{{ i }}"{% if i == selection %} selected{% endif %}>{{ i }}</option>
                 {% endfor %}
             </select>
         </div>
@@ -146,7 +146,7 @@
                 name: 'radio-theme',
                 id: 'radio-theme-' ~ theme.value,
                 value: theme.value,
-                checked: theme === current,
+                checked: theme == current,
                 autocomplete: 'off',
                 'data-success': theme.success|trans,
             } %}
diff --git a/templates/test/timeline.html.twig b/templates/test/timeline.html.twig
@@ -4,7 +4,7 @@
 {# macros #}
 {% macro addInterval(value, count, message, selection) -%}
     {%- set text = message|trans({count: count}) -%}
-    <option value="{{ value }}"{% if value === selection %} selected{% endif %}>{{ text }}</option>
+    <option value="{{ value }}"{% if value == selection %} selected{% endif %}>{{ text }}</option>
 {%- endmacro addInterval %}
 {% macro addButton(class, disabled, path, title, icon, date = null) -%}
     <button type="button" class="btn btn-secondary {{ class }}"{% if disabled %} disabled{% endif %} data-url="{{ url(path) }}" title="{{ title|trans }}"{% if date %} data-date="{{ date }}"{% endif %}>
@@ -16,8 +16,8 @@
 {%- set title_icon = 'fa-solid fa-stream' -%}
 {%- set min_date_locale = min_date|locale_date('none', 'yyyy-MM-dd') -%}
 {%- set max_date_locale = max_date|locale_date('none', 'yyyy-MM-dd') -%}
-{%- set is_first = from === min_date -%}
-{%- set is_last = to === max_date -%}
+{%- set is_first = from == min_date -%}
+{%- set is_last = to == max_date -%}
 {# body #}
 {% block body -%}
 <div>
diff --git a/templates/test/translate.html.twig b/templates/test/translate.html.twig
diff --git a/templates/test/tree_view.html.twig b/templates/test/tree_view.html.twig
diff --git a/templates/user/user_show.html.twig b/templates/user/user_show.html.twig
