-
Notifications
You must be signed in to change notification settings - Fork 12
Expand file tree
/
Copy pathmain.rs
More file actions
717 lines (650 loc) · 28.9 KB
/
Copy pathmain.rs
File metadata and controls
717 lines (650 loc) · 28.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
use clap::Parser;
use config::{get_config, ConfigManager};
use cover::CoverManager;
use error::MprisenceError;
use log::{debug, error, info, trace, warn};
use player::{
bridge_browser, canonical_player_bus_name, compute_presence_migrations,
events::{self, EventOutcome, PlayerEvent},
is_mprisence_web_bridge_bus, is_playerctld_no_active_error, merge_url_duplicates,
select_richest_player, select_winner_idx, should_suppress_native, BucketSummary, Player,
PlayerFinder, PlayerIdentifier,
};
use presence::Presence;
use smol_str::SmolStr;
use std::{
alloc::System,
collections::{HashMap, HashSet},
sync::Arc,
time::Duration,
};
use tokio::sync::mpsc;
#[global_allocator]
static GLOBAL: System = System;
mod cli;
mod config;
mod cover;
mod discord;
mod error;
mod metadata;
mod player;
mod presence;
mod template;
mod utils;
mod web_bridge;
use crate::cli::Cli;
#[tokio::main]
async fn main() -> Result<(), error::Error> {
let raw_args: Vec<String> = std::env::args().collect();
let cli_args = raw_args.get(1..).unwrap_or(&[]);
if web_bridge::looks_like_native_host_invocation(cli_args)
|| web_bridge::is_explicit_host_command(cli_args)
{
web_bridge::init_host_logging();
web_bridge::run_host().await;
return Ok(());
}
env_logger::init();
let cli = Cli::parse();
match cli.command {
Some(cmd) => {
if cmd.requires_config() {
config::initialize()?;
}
cmd.execute().await?
}
None => {
info!("Starting mprisence");
config::initialize()?;
let mut mprisence = Mprisence::new()?;
mprisence.run().await?;
}
}
Ok(())
}
pub struct Mprisence {
/// Keyed by normalised player identity (e.g. `"music_player_daemon"`).
/// Enforces at most one Discord presence per logical player, regardless of
/// how many D-Bus bus names expose the same underlying player.
media_players: HashMap<SmolStr, Presence>,
/// Last seen deduplication selection for identities that currently expose
/// multiple bus names.
dedup_selection: HashMap<SmolStr, DedupSelection>,
template_manager: Arc<template::TemplateManager>,
cover_manager: Arc<CoverManager>,
config_rx: config::ConfigChangeReceiver,
config: Arc<ConfigManager>,
}
#[derive(Clone, Debug)]
struct DedupSelection {
buses_signature: String,
winner_bus: SmolStr,
}
impl Mprisence {
pub fn new() -> Result<Self, MprisenceError> {
info!("Initializing service components");
let config = get_config();
trace!("Creating template manager");
let template_manager = Arc::new(template::TemplateManager::new(&config)?);
trace!("Creating cover manager");
let cover_manager = Arc::new(CoverManager::new(&config)?);
debug!("Service initialization complete");
Ok(Self {
media_players: HashMap::new(),
dedup_selection: HashMap::new(),
template_manager,
cover_manager,
config_rx: config.subscribe(),
config,
})
}
async fn handle_config_change(&mut self) -> Result<(), MprisenceError> {
info!("Configuration change detected, updating components");
self.config = get_config();
self.template_manager = Arc::new(template::TemplateManager::new(&self.config)?);
self.cover_manager = Arc::new(CoverManager::new(&self.config)?);
debug!("Template and cover managers updated successfully");
for (_norm_id, presence) in self.media_players.iter_mut() {
let pid = presence.player_id();
let url = presence.current_url();
let title = presence.current_title();
let resolution = self.config.resolve_source(
&pid.identity,
&pid.player_bus_name,
url.as_deref(),
title.as_deref(),
);
let player_config = &resolution.config;
let is_allowed =
self.config
.is_source_allowed(&pid.identity, &pid.player_bus_name, &resolution);
if player_config.ignore || !is_allowed {
debug!(
"Player now {}: {}",
if player_config.ignore {
"ignored"
} else {
"disallowed"
},
pid.identity
);
let _ = presence.destroy_discord_client();
} else {
presence.update_managers(
self.template_manager.clone(),
self.cover_manager.clone(),
self.config.clone(),
);
}
}
self.media_players.retain(|_norm_id, presence| {
let pid = presence.player_id();
let url = presence.current_url();
let title = presence.current_title();
let resolution = self.config.resolve_source(
&pid.identity,
&pid.player_bus_name,
url.as_deref(),
title.as_deref(),
);
!resolution.config.ignore
&& self
.config
.is_source_allowed(&pid.identity, &pid.player_bus_name, &resolution)
});
debug!("All media players updated with new configuration");
Ok(())
}
pub async fn update(&mut self) -> Result<(), MprisenceError> {
trace!("Starting Discord presence update cycle");
let discord_running = discord::is_discord_running();
if !discord_running {
trace!("Discord is not running, destroying all Discord clients");
for presence in self.media_players.values_mut() {
if let Err(e) = presence.destroy_discord_client() {
warn!("Failed to destroy Discord client: {}", e);
}
}
return Ok(());
}
trace!("Scanning for active media players");
let mut player_finder = PlayerFinder::new()?;
player_finder.set_player_timeout_ms(5000);
// Phase 1: collect all allowed, non-ignored players and group them by
// normalised identity so that multiple bus names for the same underlying
// player (e.g. `mpd` and `playerctld`) are treated as one logical player.
let mut candidates: HashMap<SmolStr, Vec<Player>> = HashMap::new();
for player in player_finder.iter_players()? {
let player = match player {
Ok(p) => p,
Err(err) if is_playerctld_no_active_error(&err) => {
debug!("Skipping playerctld proxy without an active player during discovery");
continue;
}
Err(err) => return Err(err.into()),
};
let id = PlayerIdentifier::from(&player);
let metadata = player.get_metadata().ok();
let url = metadata
.as_ref()
.and_then(|m| m.url().map(|s| s.to_string()));
let title = metadata
.as_ref()
.and_then(|m| m.title().map(|s| s.to_string()));
let resolution = self.config.resolve_source(
&id.identity,
&id.player_bus_name,
url.as_deref(),
title.as_deref(),
);
if !self
.config
.is_source_allowed(&id.identity, &id.player_bus_name, &resolution)
{
trace!("Skipping disallowed player: {}", id.identity);
continue;
}
if resolution.config.ignore {
trace!(
"Skipping ignored player: {} ({})",
id.identity,
url.as_deref().unwrap_or("no URL")
);
continue;
}
// Bridge players are one-per-tab: their canonical bus name
// (`mprisence_web.<site>.<hash>`) is unique per tab, so key by it.
// Native players are keyed by normalized identity so multiple bus
// names for the same player still collapse to one.
let norm_id = if is_mprisence_web_bridge_bus(&id.player_bus_name) {
id.player_bus_name.clone()
} else {
SmolStr::new(utils::normalize_player_identity(&id.identity))
};
candidates.entry(norm_id).or_default().push(player);
}
// Phase 1.5: merge identity groups that share the same xesam:url, so
// that e.g. plasma-browser-integration and the native browser MPRIS
// endpoint exposing the same tab are tracked as one logical player.
let candidates = merge_url_duplicates(candidates);
// Phase 1.6a: when a native browser MPRIS endpoint exposes the same
// tab as a live bridge player, suppress the native endpoint so the tab
// is not double-counted. Keep unrelated native browser entries (e.g.
// SoundCloud in the browser when only YouTube tabs are bridged).
let bridged_sources: Vec<(String, String)> = candidates
.values()
.flatten()
.filter(|p| is_mprisence_web_bridge_bus(p.bus_name()))
// A D-Bus metadata error silently skips the player for this scan cycle.
.filter_map(|p| {
let metadata = p.get_metadata().ok()?;
let browser = bridge_browser(&metadata)?;
let url = metadata.url().map(|s| s.to_string())?;
Some((browser, url))
})
.collect();
let candidates: HashMap<SmolStr, Vec<Player>> = if bridged_sources.is_empty() {
candidates
} else {
candidates
.into_iter()
// A post-merge candidate group holds players of a single kind
// (bridge groups are keyed per-tab and never URL-merged), so a
// group is dropped only when every player in it is a native
// browser bus already represented by a bridge player.
.filter(|(_, players)| {
!players.iter().all(|p| {
let canon = canonical_player_bus_name(p.bus_name());
let native_url = p
.get_metadata()
.ok()
.and_then(|m| m.url().map(|s| s.to_string()));
should_suppress_native(&canon, native_url.as_deref(), &bridged_sources)
})
})
.collect()
};
// Phase 1.6: presence-key migration. When URL-merge changes the
// post-merge norm_id of an existing logical player (e.g. plasma
// begins or ceases to expose a tab the native bus also reports),
// re-key the existing Presence so its Discord IPC client, listener
// thread, and cached playback state survive instead of being torn
// down and reconstructed.
{
let existing: HashMap<SmolStr, SmolStr> = self
.media_players
.iter()
.map(|(k, p)| (k.clone(), p.player_id().player_bus_name.clone()))
.collect();
let buckets: Vec<BucketSummary> = candidates
.iter()
.map(|(norm_id, players)| {
let ids: Vec<PlayerIdentifier> =
players.iter().map(PlayerIdentifier::from).collect();
let mut bus_names: Vec<SmolStr> =
ids.iter().map(|id| id.player_bus_name.clone()).collect();
bus_names.sort_unstable();
let winner_idx = select_richest_player(players, None);
BucketSummary {
norm_id: norm_id.clone(),
bus_names,
winner_bus: ids[winner_idx].player_bus_name.clone(),
}
})
.collect();
let (migrations, drops) = compute_presence_migrations(&existing, &buckets);
for d in drops {
if let Some(mut p) = self.media_players.remove(&d.key) {
warn!(
"Dropping duplicate presence '{}' (superseded by '{}')",
d.key, d.superseded_by
);
if let Err(e) = p.destroy_discord_client() {
warn!("Failed to destroy Discord client for {}: {}", d.key, e);
}
p.stop_listener();
}
self.dedup_selection.remove(&d.key);
}
for m in migrations {
if let Some(presence) = self.media_players.remove(&m.from_key) {
debug!(
"Migrating presence '{}' -> '{}' (URL-merge bucket rename)",
m.from_key, m.to_key
);
self.media_players.insert(m.to_key.clone(), presence);
}
if let Some(sel) = self.dedup_selection.remove(&m.from_key) {
self.dedup_selection.insert(m.to_key, sel);
}
}
}
// Phase 2: for each identity group select one winner and update/create
// the corresponding Presence. This ensures at most one Discord IPC
// connection per logical player identity.
let mut current_norm_ids = HashSet::new();
let mut duplicate_norm_ids = HashSet::new();
for (norm_id, mut group) in candidates {
current_norm_ids.insert(norm_id.clone());
let current_bus = self
.media_players
.get(&norm_id)
.map(|presence| presence.player_id().player_bus_name.clone());
let ids: Vec<PlayerIdentifier> = group.iter().map(PlayerIdentifier::from).collect();
// A group has >1 player only when several native bus names expose
// the same player (e.g. mpd + playerctld, or plasma + native
// browser). Bridge groups are always single-element.
let winner_idx = if group.len() > 1 {
select_richest_player(&group, current_bus.as_deref())
} else {
select_winner_idx(&ids, current_bus.as_deref())
};
if ids.len() > 1 {
duplicate_norm_ids.insert(norm_id.clone());
let mut bus_names: Vec<&str> =
ids.iter().map(|id| id.player_bus_name.as_str()).collect();
bus_names.sort_unstable();
let buses_signature = bus_names.join(", ");
let winner_bus = SmolStr::new(ids[winner_idx].player_bus_name.as_str());
let next = DedupSelection {
buses_signature: buses_signature.clone(),
winner_bus: winner_bus.clone(),
};
match self.dedup_selection.get(&norm_id) {
None => {
warn!(
"Duplicate MPRIS bus names detected for '{}': [{}] - selecting '{}'",
ids[0].identity, buses_signature, winner_bus
);
self.dedup_selection.insert(norm_id.clone(), next);
}
Some(prev)
if prev.buses_signature != buses_signature
|| prev.winner_bus != winner_bus =>
{
warn!(
"Dedup selection changed for '{}': [{}] - now selecting '{}'",
ids[0].identity, buses_signature, winner_bus
);
self.dedup_selection.insert(norm_id.clone(), next);
}
Some(_) => {}
}
}
let winner_player = group.remove(winner_idx);
let winner_id = &ids[winner_idx];
trace!("Processing player {}", winner_id);
if let Some(presence) = self.media_players.get_mut(&norm_id) {
if let Err(e) = presence.initialize_discord_client() {
warn!(
"Failed to initialize Discord client for {}: {}",
winner_id.identity, e
);
}
// In event-driven mode, signals drive most Discord updates. The discovery
// tick still calls presence.update() so that position jumps (seeks on
// players that don't emit Seeked) are caught by the has_position_jump
// check inside update(). The internal diff logic prevents unnecessary
// Discord pushes when nothing has changed.
if let Err(e) = presence.update(winner_player).await {
warn!(
"Failed to update presence for {}: {}",
winner_id.identity, e
);
}
} else {
debug!("New media player detected: {}", winner_id.identity);
let mut presence = Presence::new(
winner_player,
self.template_manager.clone(),
self.cover_manager.clone(),
self.config.clone(),
);
if let Err(e) = presence.initialize_discord_client() {
warn!(
"Failed to initialize Discord client for new player {}: {}",
winner_id.identity, e
);
}
// Always do the initial Discord push when a new player is discovered,
// even in event-driven mode - signals only fire on *changes*, so the
// current state must be pushed once at creation time.
if let Err(e) = presence.update_from_current_state().await {
warn!(
"Failed to set initial presence for {}: {}",
winner_id.identity, e
);
}
self.media_players.insert(norm_id, presence);
}
}
// Phase 3: remove entries whose player has gone away or been reconfigured.
self.media_players.retain(|norm_id, presence| {
let (identity, player_bus_name) = {
let pid = presence.player_id();
(pid.identity.clone(), pid.player_bus_name.clone())
};
// Use URL-aware config to respect web_player overrides (e.g. SoundCloud
// un-ignoring a browser that is ignored by default).
// Also try title-suffix inference for players without xesam:url.
let url = presence.current_url();
let title = presence.current_title();
let resolution = self.config.resolve_source(
&identity,
&player_bus_name,
url.as_deref(),
title.as_deref(),
);
let allowed = self
.config
.is_source_allowed(&identity, &player_bus_name, &resolution);
let keep = current_norm_ids.contains(norm_id) && !resolution.config.ignore && allowed;
if !keep {
let reason = if !current_norm_ids.contains(norm_id) {
"player no longer exists"
} else if resolution.config.ignore {
"player is now ignored"
} else {
"player is not in the allowed list"
};
debug!(
"Media player removed from tracking: {} ({})",
identity, reason
);
if let Err(e) = presence.destroy_discord_client() {
warn!("Failed to destroy Discord client for {}: {}", identity, e);
}
}
keep
});
self.dedup_selection.retain(|norm_id, _| {
current_norm_ids.contains(norm_id) && duplicate_norm_ids.contains(norm_id)
});
Ok(())
}
pub async fn run(&mut self) -> Result<(), MprisenceError> {
info!("Starting mprisence service");
if self.config.event_driven() {
info!(
"Run mode: event-driven (D-Bus signal monitoring, fallback poll={}ms)",
self.config.fallback_poll_interval()
);
self.run_event_driven().await
} else {
info!("Run mode: polling (interval={}ms)", self.config.interval());
self.run_polling().await
}
}
async fn run_polling(&mut self) -> Result<(), MprisenceError> {
let mut interval = tokio::time::interval(Duration::from_millis(self.config.interval()));
let mut cache_cleanup_interval = tokio::time::interval(Duration::from_secs(6 * 60 * 60));
loop {
tokio::select! {
_ = interval.tick() => {
trace!("Running periodic presence update");
if let Err(e) = self.update().await {
error!("Failed to update presence: {}", e);
}
},
_ = cache_cleanup_interval.tick() => {
debug!("Starting periodic cache cleanup");
match cover::clean_cache().await {
Ok(_) => debug!("Cache cleanup completed successfully"),
Err(e) => error!("Cache cleanup failed: {}", e)
}
},
Ok(change) = self.config_rx.recv() => {
match change {
config::ConfigChange::Reloaded => {
debug!("Configuration change detected");
if self.config.event_driven() {
warn!("event_driven flag flipped at runtime; restart mprisence to switch modes");
}
interval = tokio::time::interval(Duration::from_millis(self.config.interval()));
if let Err(e) = self.handle_config_change().await {
error!("Failed to handle configuration change: {}", e);
}
},
config::ConfigChange::Error(e) => {
error!("Configuration error: {}", e);
}
}
},
else => {
warn!("All event sources have closed, initiating shutdown");
break;
}
}
}
Ok(())
}
async fn run_event_driven(&mut self) -> Result<(), MprisenceError> {
let (event_tx, mut event_rx) = mpsc::channel::<PlayerEvent>(64);
let mut fallback_poll_interval =
tokio::time::interval(Duration::from_millis(self.config.fallback_poll_interval()));
let mut cache_cleanup_interval = tokio::time::interval(Duration::from_secs(6 * 60 * 60));
// Prime once so listeners attach to whatever is already running.
debug!("fallback poll (initial)");
if let Err(e) = self.update().await {
error!("Initial discovery failed: {}", e);
}
self.ensure_listeners(&event_tx);
loop {
tokio::select! {
Some(evt) = event_rx.recv() => {
// Collapse bursts from one listener before re-reading MPRIS state.
let (evt, deferred) = events::drain_latest_refresh(evt, &mut event_rx);
self.handle_player_event(evt, &event_tx).await;
for deferred_evt in deferred {
self.handle_player_event(deferred_evt, &event_tx).await;
}
// Don't reset the fallback poll timer here - doing so starves
// the discovery poll when events arrive faster than the poll
// interval (e.g. every 1s from YT/SC). Without a self-healing
// poll, players whose listeners die (PlayerShutDown from bridge
// pruning stale sources) are never re-discovered and disappear
// from Discord until a service restart.
// The fallback poll fires every fallback_poll_interval ms
// regardless of event flow - this is intentional.
// fallback_poll_interval.reset();
},
_ = fallback_poll_interval.tick() => {
trace!("fallback poll tick");
if let Err(e) = self.update().await {
error!("Failed to refresh players: {}", e);
}
self.ensure_listeners(&event_tx);
},
_ = cache_cleanup_interval.tick() => {
debug!("Starting periodic cache cleanup");
match cover::clean_cache().await {
Ok(_) => debug!("Cache cleanup completed successfully"),
Err(e) => error!("Cache cleanup failed: {}", e)
}
},
Ok(change) = self.config_rx.recv() => {
match change {
config::ConfigChange::Reloaded => {
debug!("Configuration change detected");
if !self.config.event_driven() {
warn!("event_driven flag flipped to false at runtime; restart mprisence to switch back to polling mode");
}
fallback_poll_interval = tokio::time::interval(
Duration::from_millis(self.config.fallback_poll_interval()),
);
if let Err(e) = self.handle_config_change().await {
error!("Failed to handle configuration change: {}", e);
}
self.ensure_listeners(&event_tx);
},
config::ConfigChange::Error(e) => {
error!("Configuration error: {}", e);
}
}
},
else => {
warn!("All event sources have closed, initiating shutdown");
break;
}
}
}
Ok(())
}
fn ensure_listeners(&mut self, tx: &mpsc::Sender<PlayerEvent>) {
for (norm_id, presence) in self.media_players.iter_mut() {
presence.ensure_listener(tx.clone(), norm_id.clone());
}
}
async fn handle_player_event(&mut self, evt: PlayerEvent, tx: &mpsc::Sender<PlayerEvent>) {
let PlayerEvent {
norm_id,
listener_generation,
kind,
} = evt;
trace!("dispatch event to {}: {:?}", norm_id, kind);
let outcome = match self.media_players.get_mut(&norm_id) {
Some(presence) => {
if !presence.listener_generation_matches(listener_generation) {
trace!(
"ignoring stale listener event for {} (generation {})",
norm_id,
listener_generation
);
return;
}
match presence.handle_event(kind).await {
Ok(outcome) => outcome,
Err(e) => {
warn!("handle_event failed for {}: {}", norm_id, e);
EventOutcome::Continue
}
}
}
None => {
trace!("event for unknown presence {} (already removed)", norm_id);
return;
}
};
if matches!(outcome, EventOutcome::ShouldRemove) {
debug!(
"removing presence {} (listener reported termination)",
norm_id
);
if let Some(mut presence) = self.media_players.remove(&norm_id) {
presence.stop_listener();
if let Err(e) = presence.destroy_discord_client() {
warn!("Failed to destroy Discord client for {}: {}", norm_id, e);
}
}
// Do NOT trigger immediate rediscovery here. The D-Bus name may
// linger briefly after the player signals shutdown, causing a
// spurious re-detection that opens a new Discord IPC connection.
// That second connection interferes with Discord's activity cleanup
// from the first connection, leaving a stale rich presence.
// Instead, let the normal fallback_poll_interval tick (default 5s)
// handle re-detection - by then the name will be fully gone, or
// if the player genuinely restarted it will be picked up cleanly.
self.ensure_listeners(tx);
}
}
}