fix: parsing error && node config usage

Author: itaven

tests/base/config/env.config.ts

@@ -75,7 +75,7 @@ export const STAND_CONFIGS = new Map<string, StandConfig>([
           : NETWORKS_CONFIG.testnet.ETHEREUM_HOODI.rpcUrl,
       },
       nodeConfig: {
-        rpcUrlToMock: `**/api/rpc?chainId=560048`,
+        rpcUrlToMock: `**/api/rpc?chainId=560048`, // not required
         rpcUrl: process.env.RPC_URL as string,
         host: '127.0.0.1',
         port: 8545,

tests/base/contracts/stethContract.ts

@@ -1,4 +1,4 @@
-import { formatEther, getContract } from 'viem';
+import { Address, formatEther, getContract } from 'viem';
 
 import { callReadMethodSilent, getClient } from '../providers';
 import { getLocatorContract } from './lidoLocator';
@@ -23,6 +23,13 @@ export const getPooledEthByShares = async (shares: bigint) => {
   );
 };
 
+export const getStEthBalance = async (address: Address) => {
+  const contract = await getStethContract();
+  return formatEther(
+    await callReadMethodSilent(contract, 'balanceOf', [address]),
+  );
+};
+
 export const getPooledEthBySharesRoundUp = async (shares: bigint) => {
   const contract = await getStethContract();
 

tests/base/providers/clients.ts

@@ -2,6 +2,7 @@ import {
   Address,
   createPublicClient,
   createTestClient,
+  formatEther,
   http,
   publicActions,
   walletActions,
@@ -19,7 +20,7 @@ export const getTestClient = () =>
 
 export const getBalanceEth = async (address: Address) => {
   const testClient = getTestClient();
-  return await testClient.getBalance({ address: address });
+  return formatEther(await testClient.getBalance({ address: address }));
 };
 
 export const getClient = () =>

tests/base/tests/scenarios/oneStepProcess.spec.ts

@@ -21,9 +21,10 @@ import {
   getTotalMintingCapacityShares,
   getPooledEthBySharesRoundUp,
   getWithdrawValue,
+  getStEthBalance,
 } from '../../contracts';
 import process from 'node:process';
-import { getBalanceEth } from '../../providers';
+import { getBalanceEth, getClient } from '../../providers';
 
 const CONFIRM_EXPIRY = 86400;
 const NO_FEE_RATE = 100;
@@ -72,12 +73,17 @@ test.describe.serial('One step process', () => {
   test('Create vault connected to vault hub && configure with all roles ', async ({
     ethereumNodeService,
   }) => {
+    const vaultCreatorAccount = ethereumNodeService.getAccount(
+      getPermissionRole(ROLES.DEFAULT_ADMIN).index,
+    );
+    const publicClient = getClient();
+    const vaultCreatorBalanceBeforeCreate = await publicClient.getBalance({
+      address: vaultCreatorAccount.address as Address,
+    });
+
     const vaultData =
       await test.step('Create vault connected to VaultHub && grant all VM roles', async () => {
         const additionalRoles = buildAdditionalRoles(ethereumNodeService);
-        const vaultCreatorPK = ethereumNodeService.getAccount(
-          getPermissionRole(ROLES.DEFAULT_ADMIN).index,
-        ).secretKey;
 
         return await lsvCLI.factory.createVaultConnectedToVh({
           defaultAdmin: roles.defaultAdmin.address,
@@ -86,7 +92,7 @@ test.describe.serial('One step process', () => {
           confirmExpiry: CONFIRM_EXPIRY,
           nodeOperatorFeeRate: NO_FEE_RATE,
           roles: additionalRoles,
-          privateKey: vaultCreatorPK,
+          privateKey: vaultCreatorAccount.secretKey,
         });
       });
 
@@ -105,10 +111,29 @@ test.describe.serial('One step process', () => {
         ).toBe(expectedVaultConnection);
       });
 
-      await test.step('Check vault metrics', async () => {
+      await test.step('Check collateral', async () => {
+        const receipt =
+          (await publicClient
+            .getTransactionReceipt({ hash: vaultData.txHash })
+            .catch(() => undefined)) ||
+          (await publicClient.waitForTransactionReceipt({
+            hash: vaultData.txHash,
+          }));
+        const vaultCreatorBalanceAfterCreation = await publicClient.getBalance({
+          address: vaultCreatorAccount.address as Address,
+        });
+        const txFee = receipt.gasUsed * receipt.effectiveGasPrice;
+        const vaultCreatorBalanceDifference =
+          vaultCreatorBalanceBeforeCreate -
+          vaultCreatorBalanceAfterCreation -
+          txFee;
         const { totalValueEth, collateralEth } =
           await lsvCLI.dashboard.overview(dashboardAddress);
 
+        expect(
+          vaultCreatorBalanceDifference,
+          `Vault creation requires collateral of ${LIDO_CONNECTION_COLLATERAL} ETH`,
+        ).toBe(parseEther(LIDO_CONNECTION_COLLATERAL));
         expect(
           collateralEth,
           `Vault creation requires collateral of ${LIDO_CONNECTION_COLLATERAL} ETH`,
@@ -289,6 +314,9 @@ test.describe.serial('One step process', () => {
       ethereumNodeService.getAccount(getPermissionRole(ROLES.BURN).index)
         .address,
     );
+    const recipientStEthBalanceBeforeMint = await getStEthBalance(
+      recipientRepayRoleAddress,
+    );
 
     await lsvCLI.vo.mintStEth(
       vaultAddress,
@@ -304,6 +332,11 @@ test.describe.serial('One step process', () => {
     const liabilityShares = await getLiabilityShares(dashboardAddress);
     const contractLiabilityStEth =
       await getPooledEthBySharesRoundUp(liabilityShares);
+    const calculatedRecipientStEthBalanceAfterMint =
+      parseFloat(recipientStEthBalanceBeforeMint) + parseFloat(mintAmount);
+    const recipientStEthBalanceAfterMint = parseFloat(
+      await getStEthBalance(recipientRepayRoleAddress),
+    );
 
     expect(
       dashboardLiabilityShares,
@@ -313,7 +346,10 @@ test.describe.serial('One step process', () => {
       dashboardLiabilityStEth,
       'Expect dashboard liability stETH to be correct with contract',
     ).toBe(contractLiabilityStEth);
-    // add check for stETH to be mint to recipient
+    expect(
+      recipientStEthBalanceAfterMint,
+      'Expect recipient stEth address receives correct amount',
+    ).toBe(calculatedRecipientStEthBalanceAfterMint);
   });
 
   test(`Burn stETH as ${ROLES.BURN}`, async ({ ethereumNodeService }) => {
@@ -376,10 +412,10 @@ test.describe.serial('One step process', () => {
       await lsvCLI.dashboard.overview(dashboardAddress);
 
     const withdrawRecipientBalanceAfterWithdraw = parseFloat(
-      formatEther(await getBalanceEth(withdrawRecipientAddress)),
+      await getBalanceEth(withdrawRecipientAddress),
     );
     const calculatedWithdrawRecipientBalanceAfter =
-      parseFloat(formatEther(withdrawRecipientBalanceBeforeWithdraw)) +
+      parseFloat(withdrawRecipientBalanceBeforeWithdraw) +
       parseFloat(availableToWithdrawalEthBefore);
 
     const contractWithdrawableValue = formatEther(

tests/base/tests/test.fixture.ts

@@ -20,10 +20,11 @@ export const test = base.extend<
   ],
   ethereumNodeService: [
     async ({ nodeRunOptions }, use) => {
-      const nodeConfig = getStandConfig().nodeConfig;
+      const { networkConfig, nodeConfig } = getStandConfig();
       const ethereumNodeService = new EthereumNodeService({
         ...nodeConfig,
         runOptions: nodeRunOptions,
+        rpcUrl: networkConfig.rpcUrl,
       });
       await ethereumNodeService.startNode();
 

tests/base/utils/lsvCLI/programs/dashboard.ts

@@ -106,7 +106,7 @@ export const overview = async (
           case 'Reserve Ratio, %':
             reserveRatioPercent = value;
             break;
-          case 'Force Rebalance Threshold':
+          case 'Force Rebalance Threshold, %':
             forceRebalanceThreshold = value;
             break;
           case 'stVault Share Limit, stETH':

tests/base/utils/lsvCLI/programs/factory.ts

@@ -1,5 +1,5 @@
 import { spawn } from 'child_process';
-import { Address } from 'viem';
+import { Address, Hex } from 'viem';
 import type { CreateVaultParams, VaultCreationResult } from '../types';
 
 export const createVaultConnectedToVh = async (
@@ -68,6 +68,13 @@ export const createVaultConnectedToVh = async (
           (line) => line.includes('Dashboard Address') && line.includes('0x'),
         );
 
+      const txHashLine = stdout
+        .split('\n')
+        .find(
+          (line) => line.includes('Transaction Hash ') && line.includes('0x'),
+        );
+      const txHashMatch = txHashLine?.match(/(0x[a-fA-F0-9]{64})/);
+
       const vaultAddressMatch = vaultLine?.match(/(0x[a-fA-F0-9]{40})/);
       const dashboardAddressMatch = dashboardLine?.match(/(0x[a-fA-F0-9]{40})/);
 
@@ -83,9 +90,16 @@ export const createVaultConnectedToVh = async (
         );
       }
 
+      if (!txHashMatch?.[1]) {
+        return reject(
+          new Error('Transaction hash not found in CLI output:\n' + stdout),
+        );
+      }
+
       resolve({
         vaultAddress: vaultAddressMatch[1] as Address,
         dashboardAddress: dashboardAddressMatch[1] as Address,
+        txHash: txHashMatch[1] as Hex,
       });
     });
 

tests/base/utils/lsvCLI/types.ts

@@ -1,4 +1,4 @@
-import { Address } from 'viem';
+import { Address, Hex } from 'viem';
 
 export type RoleAssignment = {
   account: string;
@@ -20,6 +20,7 @@ export type CreateVaultParams = {
 export type VaultCreationResult = {
   vaultAddress: Address;
   dashboardAddress: Address;
+  txHash: Hex;
 };
 
 export type VaultInfo = {