Skip to content

Remerge from aguillon/permit-cameligo #10

Description

@aguillon

https://github.com/aguillon/permit-cameligo/ has diverged from the official repository (sorry, I wasn't tracking it) but is more modern. Among other things, it uses the recently merged version of @ligo/fa instead of extendable-fa2, changes the admin to a set and adds an entrypoint to remove an admin, and rewrites the tests to use breathalyzer instead of a custom test suite.

Can we list here what I need to do to merge my changes into yours? I think we can reset to d6e61b0 (last common ancestor), as most changes that happened after this commit seem to be about migration to Ligo v1.

Then I need to

  • drop submodules and use registry instead (breathalyzer and ligo/fa both should be available in registry), and
  • make sure TZIP 17 is correctly implemented and write tests about it.

Anything else?

It is likely that this code becomes mostly obsolete after the next version of Tezos. However, permits can still be used for other things, so I will probably start a new library from this repository in the future. @Laucans, is it possible to change the name and category of a project on Registry after it has been added? From "permit-cameligo" to "permit-library", for instance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions