Merge pull request #36 from lindentechde/ci/windows-re-enable

ci(tests): re-enable CLI / examples suites on Windows via shared helpers

Author: ggulpari

jest.config.js

@@ -8,21 +8,14 @@ const baseConfig = {
 
   coverageDirectory: 'coverage',
   coverageReporters: ['text', 'lcov', 'html', 'json'],
-  // On Windows CI several CLI/integration suites are skipped (see
-  // tests/cli-*.test.ts TODO(windows-ci) markers), which would otherwise
-  // drop coverage below thresholds and mask the real signal. Skip the
-  // coverage gate on win32.
-  coverageThreshold:
-    process.platform === 'win32'
-      ? undefined
-      : {
-          global: {
-            branches: 55,
-            functions: 75,
-            lines: 68,
-            statements: 68,
-          },
-        },
+  coverageThreshold: {
+    global: {
+      branches: 55,
+      functions: 75,
+      lines: 68,
+      statements: 68,
+    },
+  },
   testTimeout: 10000,
   verbose: true,
   maxWorkers: 1,

tests/cli-program.test.ts

@@ -35,8 +35,8 @@ jest.mock('chokidar', () => {
 
 import * as fs from 'fs';
 import * as path from 'path';
-import * as os from 'os';
 import * as cliProgram from '../src/cli/program';
+import { canonicalTmpDir } from './helpers/paths';
 
 const { createProgram, compileFile } = cliProgram;
 
@@ -47,9 +47,7 @@ const { createProgram, compileFile } = cliProgram;
  * We stub process.exit and console to keep the test runner alive and to assert outputs.
  */
 
-// TODO(windows-ci): this suite uses Windows 8.3 short paths and npm init in a temp
-// directory; it needs explicit long-path handling before it can pass on win32.
-(process.platform === 'win32' ? describe.skip : describe)('CLI Program (in-process)', () => {
+describe('CLI Program (in-process)', () => {
   let tempDir: string;
   let originalCwd: string;
   let originalExitCode: number | undefined;
@@ -59,7 +57,7 @@ const { createProgram, compileFile } = cliProgram;
   let skipCleanup = false;
 
   beforeEach(() => {
-    tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'somon-cli-program-'));
+    tempDir = canonicalTmpDir('somon-cli-program-');
     originalCwd = process.cwd();
     originalExitCode = process.exitCode;
     consoleLogSpy = jest.spyOn(console, 'log').mockImplementation(() => {});
@@ -72,13 +70,27 @@ const { createProgram, compileFile } = cliProgram;
   // Config loader behavior is covered in tests/config.test.ts.
 
   afterEach(() => {
+    // Restore cwd FIRST — on Windows, rmSync on the current working
+    // directory raises EBUSY, which would throw and leave the next suite
+    // with a stale cwd pointing at a deleted temp dir.
+    try {
+      process.chdir(originalCwd);
+    } catch {
+      // originalCwd may itself be gone in pathological cases; swallow and
+      // keep going so we still restore spies and exit code.
+    }
+
     // Cleanup temp dir
     if (!skipCleanup && fs.existsSync(tempDir)) {
-      fs.rmSync(tempDir, { recursive: true, force: true });
+      try {
+        fs.rmSync(tempDir, { recursive: true, force: true });
+      } catch {
+        // Windows occasionally keeps file handles open briefly after a
+        // subprocess exits; the OS will reclaim the temp dir, and a failed
+        // cleanup here must not break subsequent suites.
+      }
     }
 
-    // Restore cwd
-    process.chdir(originalCwd);
     // Reset any exit code left by CLI handlers during tests
     process.exitCode = originalExitCode ?? 0;
     consoleLogSpy.mockRestore();