Clean up test harness

Author: hakanensari

.env.example

@@ -1,8 +1,4 @@
 /.bundle/
-/.yardoc
-/_yardoc/
-/coverage/
-/doc/
 /pkg/
 /spec/reports/
 /tmp/

.gitignore

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
   spec.summary = "Amazon Ads API client for Ruby"
   spec.homepage = "https://github.com/lineofflight/amazon-ads-ruby"
   spec.license = "MIT"
-  spec.required_ruby_version = ">= 3.3.0"
+  spec.required_ruby_version = ">= 3.3"
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = spec.homepage
@@ -20,8 +20,6 @@ Gem::Specification.new do |spec|
 
   spec.files = Dir["lib/amazon_ads/**/*.rb", "sig/generated/amazon_ads/**/*.rbs"]
     .append("lib/amazon_ads.rb", "sig/generated/amazon_ads.rbs", "LICENSE.txt", "README.md")
-  spec.bindir = "exe"
-  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_dependency("cgi")

amazon-ads.gemspec

@@ -0,0 +1,5 @@
+AMAZON_ADS_CLIENT_ID=CLIENT_ID
+AMAZON_ADS_CLIENT_SECRET=CLIENT_SECRET
+AMAZON_ADS_TEST_REFRESH_TOKEN=REFRESH_TOKEN
+AMAZON_ADS_TEST_REGION=NA
+AMAZON_ADS_TEST_PROFILE_ID=PROFILE_ID

test/.env.example

@@ -3,12 +3,11 @@
 require "test_helper"
 
 class TestLWA < Minitest::Test
+  include Credentials
   include Recordable
 
   def test_request_returns_parsed_response
-    data = AmazonAds::LWA.request(
-      refresh_token: ENV.fetch("AMAZON_ADS_TEST_REFRESH_TOKEN"),
-    )
+    data = AmazonAds::LWA.request(refresh_token:)
 
     assert(data.key?("access_token"))
     assert(data.key?("expires_in"))

test/amazon_ads/test_lwa.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Credentials
+  def region
+    ENV.fetch("AMAZON_ADS_TEST_REGION")
+  end
+
+  def profile_id
+    ENV.fetch("AMAZON_ADS_TEST_PROFILE_ID")
+  end
+
+  def refresh_token
+    ENV.fetch("AMAZON_ADS_TEST_REFRESH_TOKEN")
+  end
+end

test/support/credentials.rb

@@ -1,32 +1,21 @@
 # frozen_string_literal: true
 
+require_relative "credentials"
 require_relative "recordable"
 
 module FeatureHelpers
+  include Credentials
   include Recordable
 
   def setup
     super
 
     class_name = self.class.name.delete_prefix("Test")
-    @api = AmazonAds.const_get(class_name).new(**api_options)
-  end
-
-  private
-
-  def api_options
-    @api_options ||= {
-      region: ENV.fetch("AMAZON_ADS_TEST_REGION", "na"),
-      profile_id: ENV["AMAZON_ADS_TEST_PROFILE_ID"],
-      access_token: access_token,
-    }
+    @api = AmazonAds.const_get(class_name).new(region:, profile_id:, access_token:)
   end
 
   def access_token
-    data = AmazonAds::LWA.request(
-      refresh_token: ENV.fetch("AMAZON_ADS_TEST_REFRESH_TOKEN", "dummy"),
-    )
-
+    data = AmazonAds::LWA.request(refresh_token:)
     data.fetch("access_token")
   end
 end

test/support/feature_helpers.rb

@@ -2,14 +2,12 @@
 
 $LOAD_PATH.unshift(File.expand_path("../lib", __dir__))
 
-require "dotenv/load"
+require "dotenv"
 
-ENV["AMAZON_ADS_CLIENT_ID"] ||= "dummy"
-ENV["AMAZON_ADS_CLIENT_SECRET"] ||= "dummy"
-
-require "amazon_ads"
+Dotenv.load("#{__dir__}/.env", "#{__dir__}/.env.example")
 
 require "minitest/autorun"
+require "amazon_ads"
 
 require_relative "support/recordable"
 require_relative "support/feature_helpers"