Commit aa4033c
authored
fix(srt): handle undefined/null text in malformed SRT files (#1990)
* fix(cli/srt): filter out undefined/null subtitle entries during push and pull operations
* fix(cli/srt): add warning for skipping undefined/null subtitle entries during push
* refactor(srt): remove misleading warnings for filtered undefined entries
Warnings were misleading since entries get filled from sourceData in final merge.
Final output is correct, so silent filtering is appropriate.1 parent 83204dd commit aa4033c
File tree
2 files changed
+6
-9
lines changed- .changeset
- packages/cli/src/cli/loaders
2 files changed
+6
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
| 27 | + | |
36 | 28 | | |
37 | 29 | | |
38 | 30 | | |
| |||
0 commit comments