fix(cli): use separator-bounded matching for key pattern filters (#2010)

* fix(cli): use separator-bounded matching for key pattern filters

* fix(cli): add dash as recognized separator in key pattern matching

Author: AndreyHirsa

.changeset/flat-beans-wonder.md

@@ -0,0 +1,5 @@
+---
+"lingo.dev": patch
+---
+
+fix(cli): use exact and separator-bounded matching for lockedKeys, ignoredKeys, preservedKeys, and localizableKeys instead of substring prefix matching

packages/cli/src/cli/utils/key-matching.spec.ts

@@ -6,15 +6,41 @@ import {
 } from "./key-matching";
 
 describe("matchesKeyPattern", () => {
-  it("should match keys with prefix matching", () => {
+  it("should match keys with separator-bounded prefix matching", () => {
     const patterns = ["api", "settings"];
 
     expect(matchesKeyPattern("api/users", patterns)).toBe(true);
     expect(matchesKeyPattern("api/posts", patterns)).toBe(true);
+    expect(matchesKeyPattern("api.users", patterns)).toBe(true);
     expect(matchesKeyPattern("settings/theme", patterns)).toBe(true);
+    expect(matchesKeyPattern("settings.theme", patterns)).toBe(true);
     expect(matchesKeyPattern("other/key", patterns)).toBe(false);
   });
 
+  it("should match exact keys", () => {
+    const patterns = ["inbox"];
+
+    expect(matchesKeyPattern("inbox", patterns)).toBe(true);
+  });
+
+  it("should not match keys that share a prefix but lack a separator", () => {
+    const patterns = ["inbox"];
+
+    expect(matchesKeyPattern("inbox_url", patterns)).toBe(false);
+    expect(matchesKeyPattern("inbox_empty_title", patterns)).toBe(false);
+    expect(matchesKeyPattern("inbox_empty_body", patterns)).toBe(false);
+    expect(matchesKeyPattern("inboxes", patterns)).toBe(false);
+  });
+
+  it("should match keys with dot, slash, or dash separator after pattern", () => {
+    const patterns = ["inbox"];
+
+    expect(matchesKeyPattern("inbox.title", patterns)).toBe(true);
+    expect(matchesKeyPattern("inbox/details", patterns)).toBe(true);
+    expect(matchesKeyPattern("inbox-0", patterns)).toBe(true);
+    expect(matchesKeyPattern("inbox.nested.key", patterns)).toBe(true);
+  });
+
   it("should match keys with glob patterns", () => {
     const patterns = ["api/*/users", "settings/*"];
 

packages/cli/src/cli/utils/key-matching.ts

@@ -1,11 +1,18 @@
 import { minimatch } from "minimatch";
 
 /**
- * Checks if a key matches any of the provided patterns using prefix or glob matching
+ * Checks if a key matches any of the provided patterns using exact, separator-bounded prefix, or glob matching.
+ * Separator-bounded means the key must equal the pattern exactly, or continue with a ".", "/", or "-" separator.
+ * This prevents "inbox" from matching "inbox_url" while still matching "inbox.title", "inbox/details", or "heading-0".
  */
 export function matchesKeyPattern(key: string, patterns: string[]): boolean {
   return patterns.some(
-    (pattern) => key.startsWith(pattern) || minimatch(key, pattern),
+    (pattern) =>
+      key === pattern ||
+      key.startsWith(pattern + ".") ||
+      key.startsWith(pattern + "/") ||
+      key.startsWith(pattern + "-") ||
+      minimatch(key, pattern),
   );
 }