Skip to content

Commit 2ae4cfe

Browse files
abhics1002abhishek bharadwaj
andauthored
adding logs to detect ZK use. (#1140)
* adding logs to detect ZK use. * reduced logs * adding application name * updating version to resolve conflicts * changing error to warn --------- Co-authored-by: abhishek bharadwaj <abharadwaj@linkedin.com>
1 parent 42be70c commit 2ae4cfe

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

CHANGELOG.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ and what APIs have changed, if applicable.
1414

1515
## [Unreleased]
1616

17+
## [29.85.2] - 2026-02-13
18+
Adding logging in D2 client for ZK usages
19+
1720
## [29.85.1] - 2026-02-12
1821
Add public needScatterGather method to RestClient
1922

@@ -5958,7 +5961,8 @@ patch operations can re-use these classes for generating patch messages.
59585961

59595962
## [0.14.1]
59605963

5961-
[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.85.1...master
5964+
[Unreleased]: https://github.com/linkedin/rest.li/compare/v29.85.2...master
5965+
[29.85.2]: https://github.com/linkedin/rest.li/compare/v29.85.1...v29.85.2
59625966
[29.85.1]: https://github.com/linkedin/rest.li/compare/v29.85.0...v29.85.1
59635967
[29.85.0]: https://github.com/linkedin/rest.li/compare/v29.84.1...v29.85.0
59645968
[29.84.1]: https://github.com/linkedin/rest.li/compare/v29.84.0...v29.84.1
@@ -7212,4 +7216,4 @@ patch operations can re-use these classes for generating patch messages.
72127216
[0.14.4]: https://github.com/linkedin/rest.li/compare/v0.14.3...v0.14.4
72137217
[0.14.3]: https://github.com/linkedin/rest.li/compare/v0.14.2...v0.14.3
72147218
[0.14.2]: https://github.com/linkedin/rest.li/compare/v0.14.1...v0.14.2
7215-
[0.14.1]: https://github.com/linkedin/rest.li/tree/v0.14.1
7219+
[0.14.1]: https://github.com/linkedin/rest.li/tree/v0.14.1

d2/src/main/java/com/linkedin/d2/balancer/D2ClientBuilder.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import com.linkedin.d2.balancer.clients.DynamicClient;
2828
import com.linkedin.d2.balancer.clients.RequestTimeoutClient;
2929
import com.linkedin.d2.balancer.util.D2CalleeInfoRecorder;
30+
import com.linkedin.d2.discovery.util.D2Utils;
3031
import java.time.Duration;
3132
import javax.annotation.Nonnull;
3233
import com.linkedin.d2.balancer.clients.RetryClient;
@@ -269,6 +270,14 @@ public D2Client build()
269270
+ "Using in stack: {}", stackTrace);
270271
}
271272

273+
// Adding logs to detect if any non-INDIS load balancer factory is being used.
274+
if (!loadBalancerFactory.isIndisOnly())
275+
{
276+
LOG.warn("[ACTION REQUIRED] Zookeeper-based D2 Client "
277+
+ "is deprecated (unless talking to a locally-deployed ZK, or for testing EI ZK) and must be migrated to INDIS. "
278+
+ "See instructions at go/onboardindis , application identity: ", D2Utils.getAppIdentityName());
279+
}
280+
272281
if (loadBalancerFactory.isIndisOnly() && cfg.xdsServer == null)
273282
{
274283
throw new IllegalStateException("xdsServer is null. Call setXdsServer with a valid indis server address. "

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version=29.85.1
1+
version=29.85.2
22
group=com.linkedin.pegasus
33
org.gradle.configureondemand=true
44
org.gradle.parallel=true

0 commit comments

Comments
 (0)