[HELM UPDATE CONFIG]: Litmus-Agent Hooks break Subscriber-Secret and Subscriber Config Updates

[seanocca]

Steps to Reproduce Issue

1. Deploy the litmus portal
2. Create an environment in the portal
3. Deploy the litmus-agent chart via ArgoCD and add values to create a new infrastructure. Making sure to let the deployment create the infraSecret and infraConfigmap
4. The subscriber-secret and subscriber-configmap get populated with the correct values and every starts up
5. Run a sync on ArgoCD
6. The hook annotations on the subscriber-secret and subscriber-configmap will delete the kubernetes resources and remove the required information
7. The pre-install-webhook will start up and complete with the message Infra already exist. This will create but not populate the subscriber-secret and subscriber-configmap.
8. The subscriber and event-tracker deployments fail because the required environment variables do not exist

Requested Feature

Requested Fix in Code

• Update [client.go](https://github.com/litmuschaos/test-tools/blob/master/custom/litmus-helm-agent/pkg/litmus/client.go#L161) to add/update the required variables to the secret if the "Infra already exists"
  • This may require changes elsewhere in the code though

Requested Fix in Helm Chart

• Remove helm.sh hook annotations from infra_config_map
• Remove helm.sh hook annotations from infra-secret

Current (undesired) Workaround

• Create your own subscriber-secret and subscriber-configmap without the hook annotations
  • However this will NOT WORK if the subscriber-secret and subscriber-configmap are deleted or altered in anyway

Other People Facing the Same Issues

litmuschaos/litmus-helm#412
litmuschaos/litmus-helm#334
#4892
#4786

[dariolstella]

Hello Sean, I ran into the same problem. I had to fill the data for suscriber-secret and suscriber-config and also workflow-controller-configmap. I trying to figure out if there is a hack meanwhile the issue is fixed.

[Jonsy13]

Hi @dariolstella & @seanocca , Thanks for raising these.
We were working on a different solution, which automatically will fix this issue as well - litmuschaos/litmus-helm#396

We will restart work on it & see what we can do in further releases!