Fix async error reporting and memory type handling in CCLAdaptor and DeviceAdaptor (flagos-ai#266)

Author: MC952-arch

.github/workflows/test.yml

@@ -50,12 +50,15 @@ jobs:
           apt update -y
           apt-get install clang-format -y
           git fetch --all
-          from_ref=${GITHUB_HEAD_REF}
-          to_ref=${GITHUB_BASE_REF}
-
-          echo "From branch: $from_ref, To branch: $to_ref"
-
-          pre-commit run --from-ref "origin/$from_ref" --to-ref "origin/$to_ref"
+          if [ -n "$GITHUB_HEAD_REF" ] && [ -n "$GITHUB_BASE_REF" ]; then
+            from_ref="origin/$GITHUB_HEAD_REF"
+            to_ref="origin/$GITHUB_BASE_REF"
+          else
+            from_ref="HEAD^"
+            to_ref="HEAD"
+          fi
+          echo "From reference: $from_ref; To reference: $to_ref"
+          pre-commit run --from-ref "$from_ref" --to-ref "$to_ref"
         continue-on-error: false
 
       - name: Check the current working directory

.github/workflows/torch-api-test.yml

@@ -47,12 +47,15 @@ jobs:
         run: |
           cd /__w/FlagCX/FlagCX
           git fetch --all
-          from_ref=${GITHUB_HEAD_REF}
-          to_ref=${GITHUB_BASE_REF}
-
-          echo "From branch: $from_ref, To branch: $to_ref"
-
-          pre-commit run --from-ref "origin/$from_ref" --to-ref "origin/$to_ref"
+          if [ -n "$GITHUB_HEAD_REF" ] && [ -n "$GITHUB_BASE_REF" ]; then
+            from_ref="origin/$GITHUB_HEAD_REF"
+            to_ref="origin/$GITHUB_BASE_REF"
+          else
+            from_ref="HEAD^"
+            to_ref="HEAD"
+          fi
+          echo "From reference: $from_ref; To reference: $to_ref"
+          pre-commit run --from-ref "$from_ref" --to-ref "$to_ref"
         continue-on-error: false
 
       - name: Run `make` to build the project

.github/workflows/unit-test.yml

@@ -50,12 +50,15 @@ jobs:
           apt update -y
           apt-get install clang-format -y
           git fetch --all
-          from_ref=${GITHUB_HEAD_REF}
-          to_ref=${GITHUB_BASE_REF}
-
-          echo "From branch: $from_ref, To branch: $to_ref"
-
-          pre-commit run --from-ref "origin/$from_ref" --to-ref "origin/$to_ref"
+          if [ -n "$GITHUB_HEAD_REF" ] && [ -n "$GITHUB_BASE_REF" ]; then
+            from_ref="origin/$GITHUB_HEAD_REF"
+            to_ref="origin/$GITHUB_BASE_REF"
+          else
+            from_ref="HEAD^"
+            to_ref="HEAD"
+          fi
+          echo "From reference: $from_ref; To reference: $to_ref"
+          pre-commit run --from-ref "$from_ref" --to-ref "$to_ref"
         continue-on-error: false
 
       - name: Build Google Test

flagcx/adaptor/ccl/bootstrap_adaptor.cc

@@ -80,7 +80,7 @@ flagcxResult_t bootstrapAdaptorCommUserRank(const flagcxInnerComm_t comm,
 
 // TODO: unsupported
 flagcxResult_t bootstrapAdaptorCommGetAsyncError(flagcxInnerComm_t comm,
-                                                 flagcxResult_t asyncError) {
+                                                 flagcxResult_t *asyncError) {
   return flagcxNotSupported;
 }
 

flagcx/adaptor/ccl/cncl_adaptor.cc

@@ -106,10 +106,9 @@ flagcxResult_t cnclAdaptorCommUserRank(const flagcxInnerComm_t comm,
   return (flagcxResult_t)c2f_ret_map[cnclGetCommRank(rank, comm->base)];
 }
 
-// TODO: change params's type from flagcxResult_t to flagcxResult_t*
 flagcxResult_t cnclAdaptorCommGetAsyncError(flagcxInnerComm_t comm,
-                                            flagcxResult_t asyncError) {
-  asyncError = c2f_ret_map[cnclGetCommAsyncError(comm->base)];
+                                            flagcxResult_t *asyncError) {
+  *asyncError = c2f_ret_map[cnclGetCommAsyncError(comm->base)];
   return flagcxSuccess;
 }
 

flagcx/adaptor/ccl/dunccl_adaptor.cc

@@ -67,9 +67,9 @@ flagcxResult_t duncclAdaptorCommUserRank(const flagcxInnerComm_t comm,
 }
 
 flagcxResult_t duncclAdaptorCommGetAsyncError(flagcxInnerComm_t comm,
-                                              flagcxResult_t asyncError) {
+                                              flagcxResult_t *asyncError) {
   return (flagcxResult_t)ncclCommGetAsyncError(comm->base,
-                                               (ncclResult_t *)&asyncError);
+                                               (ncclResult_t *)asyncError);
 }
 
 // TODO: unsupported

flagcx/adaptor/ccl/gloo_adaptor.cc

@@ -111,7 +111,7 @@ flagcxResult_t glooAdaptorCommUserRank(const flagcxInnerComm_t comm,
 
 // TODO: unsupported
 flagcxResult_t glooAdaptorCommGetAsyncError(flagcxInnerComm_t comm,
-                                            flagcxResult_t asyncError) {
+                                            flagcxResult_t *asyncError) {
   return flagcxNotSupported;
 }
 

flagcx/adaptor/ccl/hccl_adaptor.cc

@@ -137,7 +137,7 @@ flagcxResult_t hcclAdaptorCommUserRank(const flagcxInnerComm_t comm,
 
 // TODO: unsupported
 flagcxResult_t hcclAdaptorCommGetAsyncError(flagcxInnerComm_t comm,
-                                            flagcxResult_t asyncError) {
+                                            flagcxResult_t *asyncError) {
   return flagcxNotSupported;
 }
 

flagcx/adaptor/ccl/ixnccl_adaptor.cc

@@ -67,9 +67,9 @@ flagcxResult_t ixncclAdaptorCommUserRank(const flagcxInnerComm_t comm,
 }
 
 flagcxResult_t ixncclAdaptorCommGetAsyncError(flagcxInnerComm_t comm,
-                                              flagcxResult_t asyncError) {
+                                              flagcxResult_t *asyncError) {
   return (flagcxResult_t)ncclCommGetAsyncError(comm->base,
-                                               (ncclResult_t *)&asyncError);
+                                               (ncclResult_t *)asyncError);
 }
 
 // TODO: unsupported

flagcx/adaptor/ccl/mccl_adaptor.cc

@@ -71,9 +71,9 @@ flagcxResult_t mcclAdaptorCommUserRank(const flagcxInnerComm_t comm,
 }
 
 flagcxResult_t mcclAdaptorCommGetAsyncError(flagcxInnerComm_t comm,
-                                            flagcxResult_t asyncError) {
+                                            flagcxResult_t *asyncError) {
   return (flagcxResult_t)mcclCommGetAsyncError(comm->base,
-                                               (mcclResult_t *)&asyncError);
+                                               (mcclResult_t *)asyncError);
 }
 
 // TODO: unsupported