refactor: default turnDetectionDisabled in the session signature

Author: u9g

agents/src/voice/realtime_auto_disable_turn_detection.test.ts

@@ -59,9 +59,12 @@ class FakeRealtimeSession extends RealtimeSession {
   readonly chatCtx = ChatContext.empty();
   readonly tools = ToolContext.empty();
 
-  constructor(model: RealtimeModel, options: RealtimeSessionOptions = {}) {
+  constructor(
+    model: RealtimeModel,
+    { turnDetectionDisabled = false }: RealtimeSessionOptions = {},
+  ) {
     super(model);
-    this.turnDetectionDisabled = options.turnDetectionDisabled ?? false;
+    this.turnDetectionDisabled = turnDetectionDisabled;
   }
 
   async updateInstructions() {}

plugins/openai/src/realtime/realtime_model.ts

@@ -492,7 +492,10 @@ export class RealtimeSession extends llm.RealtimeSession {
   #task: Task<void>;
   #closed = false;
 
-  constructor(realtimeModel: RealtimeModel, options: llm.RealtimeSessionOptions = {}) {
+  constructor(
+    realtimeModel: RealtimeModel,
+    { turnDetectionDisabled = false }: llm.RealtimeSessionOptions = {},
+  ) {
     super(realtimeModel);
 
     this.oaiRealtimeModel = realtimeModel;
@@ -503,7 +506,7 @@ export class RealtimeSession extends llm.RealtimeSession {
     // diff to always see "no change" and never send session.update.
     this._options = {
       ...realtimeModel._options,
-      turnDetection: options.turnDetectionDisabled ? null : realtimeModel._options.turnDetection,
+      turnDetection: turnDetectionDisabled ? null : realtimeModel._options.turnDetection,
     };
 
     this.#task = Task.from(({ signal }) => this.#mainTask(signal));