fix from comment

Author: toubatbrian

agents/src/ipc/proc_pool.test.ts

@@ -53,4 +53,17 @@ describe('ProcPool warmed process lock handling', () => {
     expect(unlock).toHaveBeenCalledTimes(1);
     expect(executor.close).toHaveBeenCalledTimes(1);
   });
+
+  it('releases both init and proc locks when closed before proc starts', async () => {
+    const pool = new ProcPool('agent', 1, 1000, 1000, undefined, 0, 0);
+    const initUnlock = vi.fn();
+    const procUnlock = vi.fn();
+    pool.closed = true;
+    pool.initMutex.lock = vi.fn(async () => initUnlock);
+
+    await pool.procWatchTask(procUnlock);
+
+    expect(initUnlock).toHaveBeenCalledTimes(1);
+    expect(procUnlock).toHaveBeenCalledTimes(1);
+  });
 });

agents/src/ipc/proc_pool.ts

@@ -96,21 +96,28 @@ export class ProcPool {
       this.executors.push(proc);
 
       const unlock = await this.initMutex.lock();
-      if (this.closed) {
-        return;
-      }
-
-      await proc.start();
+      let procUnlockTransferred = false;
       try {
-        await proc.initialize();
-        await this.warmedProcQueue.put({ proc, unlock: procUnlock });
-      } catch {
-        // Initialization failed before enqueue, so release the acquired slot immediately.
-        procUnlock();
-      }
+        if (this.closed) {
+          return;
+        }
+
+        await proc.start();
+        try {
+          await proc.initialize();
+          await this.warmedProcQueue.put({ proc, unlock: procUnlock });
+          procUnlockTransferred = true;
+        } catch {
+          // Initialization failed before enqueue, so release the acquired slot immediately.
+        }
 
-      unlock();
-      await proc.join();
+        await proc.join();
+      } finally {
+        unlock();
+        if (!procUnlockTransferred) {
+          procUnlock();
+        }
+      }
     } finally {
       const procIndex = this.executors.indexOf(proc);
       if (procIndex !== -1) {