ci: switch benchmarks to cloud (#980)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: pblazej

.github/workflows/benchmark.yaml

@@ -5,6 +5,14 @@ permissions:
 
 on:
   workflow_dispatch:
+    inputs:
+      target:
+        description: 'Benchmark target'
+        type: choice
+        default: cloud
+        options:
+          - cloud
+          - local
   schedule:
     - cron: '0 0 * * *'
 
@@ -15,16 +23,17 @@ jobs:
     timeout-minutes: 60
     env:
       LK_BENCHMARK: 1
-      # LIVEKIT_URL: ${{ secrets.BENCHMARK_URL }}
-      # LIVEKIT_API_KEY: ${{ secrets.BENCHMARK_API_KEY }}
-      # LIVEKIT_API_SECRET: ${{ secrets.BENCHMARK_API_SECRET }}
+      LIVEKIT_URL: ${{ inputs.target != 'local' && secrets.BENCHMARK_URL || '' }}
+      LIVEKIT_API_KEY: ${{ inputs.target != 'local' && secrets.BENCHMARK_API_KEY || '' }}
+      LIVEKIT_API_SECRET: ${{ inputs.target != 'local' && secrets.BENCHMARK_API_SECRET || '' }}
     steps:
       - uses: actions/checkout@v6
 
       - name: Install dependencies
         run: brew install livekit jemalloc swiftly && swiftly init --quiet-shell-followup --skip-install -y
 
       - name: Run LiveKit Server
+        if: inputs.target == 'local'
         run: livekit-server --dev &
 
       - uses: maxim-lobanov/setup-xcode@v1
@@ -39,8 +48,12 @@ jobs:
 
       - name: Benchmark Report
         working-directory: Benchmarks
+        env:
+          TARGET: ${{ inputs.target || 'cloud' }}
         run: |
-          swiftly run +xcode swift package --disable-sandbox \
-            benchmark baseline read current \
-            --format markdown \
-            | tee -a "$GITHUB_STEP_SUMMARY"
+          {
+            echo "## Target: \`${TARGET}\`"
+            echo
+            swiftly run +xcode swift package --disable-sandbox \
+              benchmark baseline read current --format markdown
+          } | tee -a "$GITHUB_STEP_SUMMARY"

Benchmarks/LiveKitBenchmark/BenchmarkSupport/BenchmarkConfig.swift

@@ -31,23 +31,30 @@ struct BenchmarkConfig {
     /// Read benchmark configuration from environment variables.
     ///
     /// Falls back to local defaults (`ws://localhost:7880`, `devkey`/`secret`)
-    /// when environment variables are not set.
+    /// when environment variables are not set or are empty.
     ///
     /// Override with:
     ///   - `LIVEKIT_URL`: WebSocket URL (e.g., `wss://my-project.livekit.cloud`)
     ///   - `LIVEKIT_API_KEY`: API key for token generation
     ///   - `LIVEKIT_API_SECRET`: API secret for token generation
     ///   - `LIVEKIT_BENCHMARK_REGION`: Server region (only used for cloud)
     static func fromEnvironment() -> BenchmarkConfig {
-        let url = ProcessInfo.processInfo.environment["LIVEKIT_URL"] ?? "ws://localhost:7880"
-        let apiKey = ProcessInfo.processInfo.environment["LIVEKIT_API_KEY"] ?? "devkey"
-        let apiSecret = ProcessInfo.processInfo.environment["LIVEKIT_API_SECRET"] ?? "secret"
+        // GitHub Actions interpolates missing `${{ secrets.X }}` to an empty
+        // string, so treat empty values the same as unset to fall back cleanly.
+        func env(_ key: String) -> String? {
+            guard let value = ProcessInfo.processInfo.environment[key], !value.isEmpty else { return nil }
+            return value
+        }
+
+        let url = env("LIVEKIT_URL") ?? "ws://localhost:7880"
+        let apiKey = env("LIVEKIT_API_KEY") ?? "devkey"
+        let apiSecret = env("LIVEKIT_API_SECRET") ?? "secret"
 
         // Auto-detect mode from URL
         let mode: InfrastructureMode = if url.hasPrefix("ws://") || url.contains("localhost") {
             .local
         } else {
-            .cloud(region: ProcessInfo.processInfo.environment["LIVEKIT_BENCHMARK_REGION"])
+            .cloud(region: env("LIVEKIT_BENCHMARK_REGION"))
         }
 
         return BenchmarkConfig(
@@ -58,3 +65,12 @@ struct BenchmarkConfig {
         )
     }
 }
+
+extension BenchmarkConfig.InfrastructureMode: CustomStringConvertible {
+    var description: String {
+        switch self {
+        case .local: "local"
+        case let .cloud(region): region.map { "cloud (\($0))" } ?? "cloud"
+        }
+    }
+}

Benchmarks/LiveKitBenchmark/Benchmarks.swift

@@ -28,6 +28,8 @@ let benchmarkTracer = BenchmarkTracer()
 ///
 /// Run with: `swift package benchmark`
 let benchmarks: @Sendable () -> Void = {
+    print("Benchmark target: \(BenchmarkConfig.fromEnvironment().mode)")
+
     // Inject our tracing so we can capture timing data
     LiveKitSDK.setTracing(benchmarkTracer)