Skip to content

lk agent deploy ignore secrets after version v2.18.0 #926

Description

@trotman23

Description

Semi-related to #860

When deploying an existing agent and passing the --secrets-file flag, secrets are not updated in the project.

I observed this stop working with the releease of the CLI version v2.18.0.

Unlike #860, I don't believe there is any early-return issue in this codebase. It appears to align with this change:

https://github.com/livekit/livekit-cli/pull/886/changes#diff-4a70574ec74b4fc8888fd29a16e49065fec8bd1833148322247a5522810a1c89R864

where a new DeployAgentV2 function is called on the cloud agents client from the go sdk.

The secrets should be passed to the server in the new v2 proto, but I don't believe the server does anything with them because our secrets never update, and new ones are never present on agents deployed to livekit cloud.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions