Skip to content

Commit 8b48599

Browse files
committed
refactor: drop irrelevant fixme comments
1 parent a3a016d commit 8b48599

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

livekit/src/room/token_source/traits.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,18 +21,15 @@ use crate::token_source::{TokenSourceFetchOptions, TokenSourceResponse, TokenSou
2121
///
2222
/// The most common downstream implementer is TokenSourceLiteral.
2323
pub trait TokenSourceFixed {
24-
// FIXME: what should the error type of the result be?
2524
fn fetch(&self) -> impl Future<Output = TokenSourceResult<TokenSourceResponse>>;
2625
}
2726

2827
/// A helper trait to more easily implement a TokenSourceFixed which not async.
2928
pub trait TokenSourceFixedSynchronous {
30-
// FIXME: what should the error type of the result be?
3129
fn fetch_synchronous(&self) -> TokenSourceResult<TokenSourceResponse>;
3230
}
3331

3432
impl<T: TokenSourceFixedSynchronous> TokenSourceFixed for T {
35-
// FIXME: what should the error type of the result be?
3633
fn fetch(&self) -> impl Future<Output = TokenSourceResult<TokenSourceResponse>> {
3734
ready(self.fetch_synchronous())
3835
}
@@ -48,7 +45,6 @@ impl<T: TokenSourceFixedSynchronous> TokenSourceFixed for T {
4845
///
4946
/// A few common downstream implementers are TokenSourceEndpoint and TokenSourceCustom.
5047
pub trait TokenSourceConfigurable {
51-
// FIXME: what should the error type of the result be?
5248
fn fetch(
5349
&self,
5450
options: &TokenSourceFetchOptions,
@@ -57,15 +53,13 @@ pub trait TokenSourceConfigurable {
5753

5854
/// A helper trait to more easily implement a TokenSourceConfigurable which not async.
5955
pub trait TokenSourceConfigurableSynchronous {
60-
// FIXME: what should the error type of the result be?
6156
fn fetch_synchronous(
6257
&self,
6358
options: &TokenSourceFetchOptions,
6459
) -> TokenSourceResult<TokenSourceResponse>;
6560
}
6661

6762
impl<T: TokenSourceConfigurableSynchronous> TokenSourceConfigurable for T {
68-
// FIXME: what should the error type of the result be?
6963
fn fetch(
7064
&self,
7165
options: &TokenSourceFetchOptions,

0 commit comments

Comments
 (0)