Skip to content

Commit c269c9b

Browse files
committed
Merge branch 'develop' into 'main'
chore: Update user register See merge request locker/api-core!618
2 parents 85a3c3f + 63acf24 commit c269c9b

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

locker_server/api/v1_0/users/serializers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class UserRegisterSerializer(serializers.Serializer):
9292
enterprise_name = serializers.CharField(required=False, allow_null=True)
9393

9494
def validate(self, data):
95-
kdf_type = data.get("kdf_type", KDF_TYPE_PBKDF2_SHA256)
95+
kdf_type = data.get("kdf", KDF_TYPE_PBKDF2_SHA256)
9696
if not KDF_TYPE.get(kdf_type):
9797
raise serializers.ValidationError(detail={"kdf": ["This KDF Type is not valid"]})
9898
kdf_iterations = data.get("kdf_iterations", DEFAULT_KDF_ITERATIONS)
@@ -267,7 +267,7 @@ class UserResetPasswordSerializer(serializers.Serializer):
267267
login_method = serializers.ChoiceField(choices=[LOGIN_METHOD_PASSWORD, LOGIN_METHOD_PASSWORDLESS])
268268

269269
def validate(self, data):
270-
kdf_type = data.get("kdf_type", KDF_TYPE_PBKDF2_SHA256)
270+
kdf_type = data.get("kdf", KDF_TYPE_PBKDF2_SHA256)
271271
if not KDF_TYPE.get(kdf_type):
272272
raise serializers.ValidationError(detail={"kdf": ["This KDF Type is not valid"]})
273273
kdf_iterations = data.get("kdf_iterations")

locker_server/core/services/user_service.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@
2828
from locker_server.core.repositories.user_plan_repository import UserPlanRepository
2929
from locker_server.core.repositories.user_repository import UserRepository
3030
from locker_server.shared.caching.sync_cache import get_sync_cache_key
31-
from locker_server.shared.constants.account import LOGIN_METHOD_PASSWORD
31+
from locker_server.shared.constants.account import LOGIN_METHOD_PASSWORD, DEFAULT_KDF_ITERATIONS
32+
from locker_server.shared.constants.ciphers import KDF_TYPE_PBKDF2_SHA256
3233
from locker_server.shared.constants.enterprise_members import *
3334
from locker_server.shared.constants.event import EVENT_USER_LOGIN_FAILED, EVENT_USER_LOGIN, EVENT_USER_BLOCK_LOGIN
3435
from locker_server.shared.constants.factor2 import FA2_METHOD_MAIL_OTP
@@ -174,8 +175,8 @@ def register_user(self, user_id: Union[str, int], master_password_hash: str, key
174175
is_password_changed = True if default_plan == PLAN_TYPE_PM_ENTERPRISE else False
175176
master_password_score = kwargs.get("score") or kwargs.get("master_password_score") or user.master_password_score
176177
user_new_creation_data = {
177-
"kdf": kwargs.get("kdf", 0),
178-
"kdf_iterations": kwargs.get("kdf_iterations", 100000),
178+
"kdf": kwargs.get("kdf", KDF_TYPE_PBKDF2_SHA256),
179+
"kdf_iterations": kwargs.get("kdf_iterations", DEFAULT_KDF_ITERATIONS),
179180
"kdf_memory": kwargs.get("kdf_memory"),
180181
"kdf_parallelism": kwargs.get("kdf_parallelism"),
181182
"key": key,

0 commit comments

Comments
 (0)