test(robot): add test case Test Disable Node Disk Health Monitoring

Signed-off-by: Yang Chiu <yang.chiu@suse.com>

Author: yangchiu

e2e/keywords/metrics.resource

@@ -14,6 +14,9 @@ Check if nodes are under memory pressure
 Metric ${metric_name} value should be ${expected_value}
     check_longhorn_metric    metric_name=${metric_name}    expected_value=${expected_value}
 
+There should be no ${metric_name} metric
+    wait_for_longhorn_metric_absent    metric_name=${metric_name}
+
 Get Longhorn components resource usage
     get_longhorn_components_memory_cpu_usage
 

e2e/libs/keywords/metrics_keywords.py

@@ -1,7 +1,7 @@
 import time
 
 from node import Node
-from metrics.metrics import get_node_metrics, check_longhorn_metric
+from metrics.metrics import get_node_metrics, check_longhorn_metric, find_longhorn_metric_samples
 from metrics.metrics import get_longhorn_components_memory_cpu_usage
 from metrics.metrics import check_longhorn_components_memory_cpu_usage
 from utility.utility import get_retry_count_and_interval
@@ -12,7 +12,7 @@ class metrics_keywords:
 
     def __init__(self):
         self.node = Node()
-        retry_count, retry_interval = get_retry_count_and_interval()
+        self.retry_count, self.retry_interval = get_retry_count_and_interval()
 
     def get_node_total_memory_in_mi(self, node_name):
         total_memory = self.node.get_node_total_memory(node_name)
@@ -52,6 +52,14 @@ def check_if_node_under_memory_pressure(self, node_name):
     def check_longhorn_metric(self, metric_name, node_name=None, metric_label=None, expected_value=None):
         check_longhorn_metric(metric_name, node_name, metric_label, expected_value)
 
+    def wait_for_longhorn_metric_absent(self, metric_name, node_name=None):
+        for i in range(self.retry_count):
+            logging(f"Waiting for longhorn metric {metric_name} absent on node {node_name} ... ({i})")
+            if not find_longhorn_metric_samples(metric_name, node_name):
+                logging(f"Longhorn metric {metric_name} is absent on node {node_name}")
+                return
+            time.sleep(self.retry_interval)
+
     def get_longhorn_components_memory_cpu_usage(self):
         get_longhorn_components_memory_cpu_usage()
 

e2e/tests/regression/test_metric.robot

@@ -7,6 +7,7 @@ Resource    ../keywords/variables.resource
 Resource    ../keywords/common.resource
 Resource    ../keywords/volume.resource
 Resource    ../keywords/metrics.resource
+Resource    ../keywords/setting.resource
 
 Test Setup    Set up v2 test environment
 Test Teardown    Cleanup test resources
@@ -22,3 +23,17 @@ Test longhorn_node_storage_scheduled_bytes Metric
     When Create volume 0 with    size=2Gi    dataEngine=v1
     And Create volume 1 with    size=4Gi    dataEngine=v2
     Then Metric longhorn_node_storage_scheduled_bytes value should be 6Gi
+
+Test Disable Node Disk Health Monitoring
+    [Documentation]    Issue: https://github.com/longhorn/longhorn/issues/12300
+    ${HOST_PROVIDER}=    Get Environment Variable    HOST_PROVIDER    vagrant
+    IF    '${HOST_PROVIDER}' == "harvester"
+        Skip    HAL nodes don't collect SMART metrics
+    END
+    Given Setting node-disk-health-monitoring is set to true
+    Then Metric longhorn_disk_health value should be 1
+    And Metric longhorn_disk_health_attribute_raw value should be 0
+
+    When Setting node-disk-health-monitoring is set to false
+    Then There should be no longhorn_disk_health metric
+    And There should be no longhorn_disk_health_attribute_raw metric