test(robot): move volume endpoint check logic to Python keyword

- Extracting the check into a new Python keyword `check_volume_endpoint_on_node`,
  which asserts the endpoint exists and raises a clear error if not.
- simplify node-level directory check to always log as WARNING.

longhorn/longhorn#13256

Signed-off-by: Roger Yao <roger.yao@suse.com>

Author: roger-ryao

e2e/keywords/host.resource

@@ -165,43 +165,16 @@ Get host log list on path ${log_path} on node ${node_id}
 Check volume endpoint on node of ${resource_kind} ${resource_id}
     [Documentation]    Find which node ${resource_kind} ${resource_id}'s volume is attached to,
     ...                then run "ls -l /dev/longhorn/${volume_name}" on that node and log the output.
-    ...                If the directory is empty or doesn't exist, log a WARNING.
+    ...                Fails the test if the endpoint is empty or doesn't exist.
     ${resource_name} =    generate_name_with_suffix    ${resource_kind}    ${resource_id}
     ${volume_name} =    Run Keyword If    '${resource_kind}' == 'volume'
     ...        Set Variable    ${resource_name}
     ...    ELSE
     ...        get_workload_volume_name    ${resource_name}
     ${node_name} =    get_volume_node    ${volume_name}
-    ${result} =    execute_command_on_node    ls -l /dev/longhorn/${volume_name}    ${node_name}
-
-    # Check if result is empty or contains error
-    ${result_stripped} =    Strip String    ${result}
-    ${is_empty} =    Run Keyword And Return Status    Should Be Empty    ${result_stripped}
-    ${has_error} =    Run Keyword And Return Status    Should Contain    ${result}    No such file or directory
-
-    IF    ${is_empty} or ${has_error}
-        ${warning_msg} =    Set Variable    /dev/longhorn/${volume_name} is empty or doesn't exist on node=${node_name}, ${resource_kind}=${resource_name}, volume=${volume_name}
-        Log    ${warning_msg}    level=WARN    console=True
-    ELSE
-        ${message} =    Set Variable    node=${node_name}, volume=${volume_name}\n/dev/longhorn/${volume_name}:\n${result}
-        Log    ${message}    console=True
-    END
+    check_volume_endpoint_on_node    ${volume_name}    ${node_name}
 
 Check volume endpoint on node ${node_id}
-    [Documentation]    Run "ls -l /dev/longhorn/" on node ${node_id} and log the output.
-    ...                If the directory is empty or doesn't exist, log a WARNING.
-    ${node_name} =    get_node_by_index    ${node_id}
-    ${result} =    execute_command_on_node    ls -l /dev/longhorn/    ${node_name}
-
-    # Check if result is empty or contains error
-    ${result_stripped} =    Strip String    ${result}
-    ${is_empty} =    Run Keyword And Return Status    Should Be Empty    ${result_stripped}
-    ${has_error} =    Run Keyword And Return Status    Should Contain    ${result}    No such file or directory
-
-    IF    ${is_empty} or ${has_error}
-        ${warning_msg} =    Set Variable    /dev/longhorn/ is empty or doesn't exist on node=${node_name}
-        Log    ${warning_msg}    level=WARN    console=True
-    ELSE
-        ${message} =    Set Variable    node=${node_name}\n/dev/longhorn/:\n${result}
-        Log    ${message}    console=True
-    END
+    [Documentation]    Run "ls -l /dev/longhorn/" on node ${node_id} and log the output as a WARNING.
+    ${result} =    Run command on node ${node_id} and get output string    ls -l /dev/longhorn/
+    Log    /dev/longhorn/ on node ${node_id}:\n${result}    level=WARN    console=True

e2e/libs/keywords/host_keywords.py

@@ -140,3 +140,11 @@ def execute_command_on_node_and_get_output_string(self, cmd, node_name):
 
     def get_host_log_files(self, node_name, log_path):
         return self.host.get_host_log_files(node_name, log_path)
+
+    def check_volume_endpoint_on_node(self, volume_name, node_name):
+        cmd = f"ls -l /dev/longhorn/{volume_name}"
+        res = NodeExec(node_name).issue_cmd(cmd)
+        assert res.strip() and "No such file or directory" not in res, \
+            f"Volume endpoint /dev/longhorn/{volume_name} is empty or doesn't exist on node {node_name}"
+        logging(f"node={node_name}, volume={volume_name}\n/dev/longhorn/{volume_name}:\n{res}")
+