test(robot): enable running robot test on storage-network pipeline, add 2nd nad for testing rwx volumes, and add rwx volume endpoint network test cases

Signed-off-by: Yang Chiu <yang.chiu@suse.com>

Author: yangchiu

e2e/keywords/common.resource

@@ -82,12 +82,11 @@ Enable v2 data engine and add block disks
 
 Init worker node variables
     ${worker_nodes}=    get_worker_nodes
-    Set Test Variable    ${NODE_0}    ${worker_nodes[0]}
-    Set Test Variable    ${NODE_1}    ${worker_nodes[1]}
-    Set Test Variable    ${NODE_2}    ${worker_nodes[2]}
+    Run Keyword And Ignore Error    Set Test Variable    ${NODE_0}    ${worker_nodes[0]}
+    Run Keyword And Ignore Error    Set Test Variable    ${NODE_1}    ${worker_nodes[1]}
+    Run Keyword And Ignore Error    Set Test Variable    ${NODE_2}    ${worker_nodes[2]}
 
 Set up test environment
-    init_k8s_api_client
     setup_control_plane_network_latency
     set_backupstore
     Init worker node variables

e2e/keywords/longhorn.resource

@@ -149,6 +149,9 @@ Upgrade Longhorn to custom version should fail
         Fail    Upgrading Longhorn succeed
     END
 
+Enable Storage Network
+    enable_storage_network_setting
+
 Check Longhorn node ${type} state on power off node is ${expect_state}
     ${status} =    get_longhorn_node_condition_status    ${last_volume_node}    ${type}
     Should Be Equal    ${status}    ${expect_state}

e2e/keywords/setting.resource

@@ -22,3 +22,7 @@ Update Setting To Valid Value And Verify
     update_setting    ${setting_key}    ${setting_value}
     ${value} =    get_setting    ${setting_key}
     Should Be Equal    ${value}    ${expected_value}
+
+Setting ${setting_key} should be ${setting_value}
+    ${current_value} =    get_setting    ${setting_key}
+    Should Be Equal    ${current_value}    ${setting_value}

e2e/libs/keywords/common_keywords.py

@@ -15,9 +15,6 @@
 class common_keywords:
 
     def __init__(self):
-        pass
-
-    def init_k8s_api_client(self):
         init_k8s_api_client()
 
     def generate_name_with_suffix(self, kind, suffix):

e2e/libs/keywords/k8s_keywords.py

@@ -84,7 +84,7 @@ def wait_for_all_pods_evicted(self, node_name):
         wait_all_pods_evicted(node_name)
 
     def uncordon_all_nodes(self):
-        nodes = Node.list_node_names_by_role("worker")
+        nodes = Node().list_node_names_by_role("worker")
 
         for node_name in nodes:
             uncordon_node(node_name)

e2e/libs/keywords/longhorn_deploy_keywords.py

@@ -17,3 +17,6 @@ def install_longhorn_system(self, custom_cmd="", install_stable_version=False):
 
     def upgrade_longhorn(self, upgrade_to_transient_version=False, timeout=600, wait_when_fail=True):
         return self.longhorn.upgrade(upgrade_to_transient_version, timeout, wait_when_fail)
+
+    def enable_storage_network_setting(self):
+        self.longhorn.enable_storage_network_setting()

e2e/libs/longhorn_deploy/base.py

@@ -92,3 +92,13 @@ def setup_longhorn_ui_nodeport(self):
             logging(f"Setting up Longhorn UI nodeport failed")
             time.sleep(self.retry_count)
             assert False, "Setting up Longhorn UI nodeport failed"
+
+    def enable_storage_network_setting(self):
+        command = "./pipelines/utilities/storage_network.sh"
+        process = subprocess.Popen([command, "enable_storage_network_setting"],
+                                   shell=False)
+        process.wait()
+        if process.returncode != 0:
+            logging(f"Enabling storage network setting failed")
+            time.sleep(self.retry_count)
+            assert False, "Enabling storage network setting failed"

e2e/libs/longhorn_deploy/longhorn_deploy.py

@@ -68,3 +68,7 @@ def upgrade(self, upgrade_to_transient_version, timeout, wait_when_fail):
             time.sleep(60)
         logging(f"Upgraded Longhorn")
         return upgraded
+
+    def enable_storage_network_setting(self):
+        logging(f"Enabling storage network setting")
+        self.longhorn.enable_storage_network_setting()

e2e/libs/network/network.py

@@ -26,7 +26,7 @@ def get_control_plane_node_network_latency_in_ms():
 def setup_control_plane_network_latency():
     latency_in_ms = get_control_plane_node_network_latency_in_ms()
     if latency_in_ms != 0:
-        control_plane_nodes = Node.list_node_names_by_role("control-plane")
+        control_plane_nodes = Node().list_node_names_by_role("control-plane")
         for control_plane_node in control_plane_nodes:
             cmd = f"tc qdisc replace dev eth0 root netem delay {latency_in_ms}ms"
             res = NodeExec(control_plane_node).issue_cmd(cmd)
@@ -38,7 +38,7 @@ def setup_control_plane_network_latency():
 def cleanup_control_plane_network_latency():
     latency_in_ms = get_control_plane_node_network_latency_in_ms()
     if latency_in_ms != 0:
-        control_plane_nodes = Node.list_node_names_by_role("control-plane")
+        control_plane_nodes = Node().list_node_names_by_role("control-plane")
         for control_plane_node in control_plane_nodes:
             cmd = "tc qdisc del dev eth0 root"
             res = NodeExec(control_plane_node).issue_cmd(cmd)

e2e/libs/node/node.py

@@ -19,7 +19,13 @@ class Node:
     DEFAULT_DISK_PATH = "/var/lib/longhorn/"
     DEFAULT_VOLUME_PATH = "/dev/longhorn/"
 
+    all_nodes = None
+    control_plane_nodes = None
+    worker_nodes = None
+
     def __init__(self):
+        if not Node.all_nodes:
+            self.init_node_list()
         self.retry_count, self.retry_interval = get_retry_count_and_interval()
 
     def mount_disk(self, disk_name, node_name):
@@ -162,13 +168,21 @@ def list_node_names_by_role(self, role="all"):
         if role not in ["all", "control-plane", "worker"]:
             raise ValueError("Role must be one of 'all', 'master' or 'worker'")
 
+        if role == "all":
+            return Node.all_nodes
+        elif role == "control-plane":
+            return Node.control_plane_nodes
+        elif role == "worker":
+            return Node.worker_nodes
+
+    def init_node_list(self):
+
         def filter_nodes(nodes, condition):
             return [node.metadata.name for node in nodes if condition(node)]
 
         core_api = client.CoreV1Api()
         nodes = core_api.list_node().items
-
-        all_nodes = sorted(filter_nodes(nodes, lambda node: True))
+        Node.all_nodes = sorted(filter_nodes(nodes, lambda node: True))
 
         control_plane_labels = {
             "node-role.kubernetes.io/master": ["true"],
@@ -180,16 +194,14 @@ def filter_nodes(nodes, condition):
             label in node.metadata.labels and node.metadata.labels[label] in values
             for label, values in control_plane_labels.items()
         )
-        control_plane_nodes = sorted(filter_nodes(nodes, condition))
+        Node.control_plane_nodes = sorted(filter_nodes(nodes, condition))
 
-        worker_nodes = sorted([node for node in all_nodes if node not in control_plane_nodes])
+        def has_no_schedule_taint(node):
+            if not node.spec.taints:
+                return False
+            return any(taint.effect == "NoSchedule" for taint in node.spec.taints)
 
-        if role == "all":
-            return all_nodes
-        elif role == "control-plane":
-            return control_plane_nodes
-        elif role == "worker":
-            return worker_nodes
+        Node.worker_nodes = sorted([node.metadata.name for node in nodes if not has_no_schedule_taint(node)])
 
     def set_node(self, node_name: str, allowScheduling: bool, evictionRequested: bool) -> object:
         for _ in range(self.retry_count):