test(robot): add test case Test Volume Expansion During Volume Cloning

yangchiu · yangchiu · commit f95c34b919ee · 2025-12-22T22:39:19.000+08:00
Signed-off-by: Yang Chiu &lt;yang.chiu@suse.com&gt;
diff --git a/e2e/keywords/persistentvolumeclaim.resource b/e2e/keywords/persistentvolumeclaim.resource
@@ -69,3 +69,12 @@ Assert persistentvolumeclaim ${claim_id} is using storageclass ${storageclass_na
    ${claim_name} =    generate_name_with_suffix    claim    ${claim_id}
    ${current_storageclass} =    get_pvc_storageclass_name    ${claim_name}
    Should Be Equal    ${current_storageclass}    ${storageclass_name}
+
+Expand persistentvolumeclaim ${claim_id} size to ${size}
+    ${claim_name} =    generate_name_with_suffix    claim    ${claim_id}
+    expand_persistentvolumeclaim_size_to    ${claim_name}    ${size}
+
+Wait for volume of persistentvolumeclaim ${claim_id} size to be ${size}
+    ${claim_name} =    generate_name_with_suffix    claim    ${claim_id}
+    ${volume_name} =    get_volume_name_from_persistentvolumeclaim    ${claim_name}
+    wait_for_volume_expand_to_size    ${volume_name}    ${size}
diff --git a/e2e/libs/keywords/persistentvolumeclaim_keywords.py b/e2e/libs/keywords/persistentvolumeclaim_keywords.py
@@ -5,6 +5,7 @@
 from utility.constant import LABEL_TEST
 from utility.constant import LABEL_TEST_VALUE
 from utility.utility import logging
+from utility.utility import convert_size_to_bytes
 
 from volume.constant import MEBIBYTE
 
@@ -31,11 +32,12 @@ def delete_persistentvolumeclaim(self, name):
         logging(f'Deleting persistentvolumeclaim {name}')
         return self.claim.delete(name)
 
-    def expand_persistentvolumeclaim_size_by_mib(self, claim_name, size_in_mib):
-        size_in_byte = int(size_in_mib) * MEBIBYTE
+    def expand_persistentvolumeclaim_size_to(self, claim_name, size):
+        logging(f'Expanding persistentvolumeclaim {claim_name} to {size}')
+        size_in_byte = convert_size_to_bytes(size)
         expanded_size = self.claim.expand(claim_name, size_in_byte)
 
-        logging(f'Expanding persistentvolumeclaim {claim_name} by {size_in_mib} MiB')
+        logging(f'Expanded persistentvolumeclaim {claim_name} to {expanded_size}')
         self.claim.set_annotation(claim_name, ANNOT_EXPANDED_SIZE, str(expanded_size))
 
     def get_claim_requested_size(self, claim_name):
diff --git a/e2e/libs/keywords/volume_keywords.py b/e2e/libs/keywords/volume_keywords.py
@@ -65,7 +65,7 @@ def list_volumes(self, dataEngine=None):
         return self.volume.list_names(dataEngine=dataEngine)
 
     def wait_for_volume_expand_to_size(self, volume_name, size):
-        logging(f'Waiting for volume {volume_name} expand to {size}')
+        logging(f'Waiting for volume {volume_name} to expand to {size}')
         return self.volume.wait_for_volume_expand_to_size(volume_name, size)
 
     def get_replica_node(self, volume_name):
@@ -302,8 +302,8 @@ def wait_for_volume_condition(self, volume_name, condition_name, condition_statu
         self.volume.wait_for_volume_condition(volume_name, condition_name, condition_status, reason)
 
     def wait_for_volume_clone_status_completed(self, volume_name):
-        logging(f'Waiting for volume {volume_name} clone status to be completed')
-        self.volume.wait_for_volume_clone_status(volume_name, "completed")
+        logging(f'Waiting for volume {volume_name} clone status to be copy-completed-awaiting-healthy')
+        self.volume.wait_for_volume_clone_status(volume_name, "copy-completed-awaiting-healthy")
 
     def wait_for_volume_migration_to_be_ready(self, volume_name):
         logging(f'Waiting for volume {volume_name} migration to be ready')
diff --git a/e2e/libs/persistentvolumeclaim/persistentvolumeclaim.py b/e2e/libs/persistentvolumeclaim/persistentvolumeclaim.py
@@ -121,6 +121,7 @@ def get_volume_name(self, claim_name):
     def expand(self, claim_name, size_in_byte, skip_retry=False):
         expanded_size = self.claim.expand(claim_name, size_in_byte, skip_retry=skip_retry)
         self.set_annotation(claim_name, ANNOT_EXPANDED_SIZE, str(expanded_size))
+        return expanded_size
 
     def expand_with_additional_bytes(self, claim_name, size_in_byte, skip_retry=False):
         pvc = self.claim.get(claim_name)
diff --git a/e2e/libs/volume/crd.py b/e2e/libs/volume/crd.py
@@ -504,7 +504,12 @@ def wait_for_volume_expand_to_size(self, volume_name, expected_size):
         engine_operation = Engine()
         for i in range(self.retry_count):
             engine = engine_operation.get_engine(volume_name)
-            engine_current_size = int(engine['status']['currentSize'])
+            # there is no current size for a stopped engine
+            if engine['status']['currentState'] == 'stopped':
+                engine_current_size = int(engine['spec']['volumeSize'])
+            else:
+                engine_current_size = int(engine['status']['currentSize'])
+
             if engine_current_size == engine_expected_size:
                 break
 
diff --git a/e2e/tests/negative/stress_cpu.robot b/e2e/tests/negative/stress_cpu.robot
@@ -45,6 +45,7 @@ Stress Volume Node CPU When Volume Is Detaching and Attaching
     END
 
 Stress Volume Node CPU When Volume Is Online Expanding
+    [Tags]    expansion
     Given Create storageclass longhorn-test with    dataEngine=${DATA_ENGINE}
     And Create statefulset 0 using RWO volume with longhorn-test storageclass
     And Write 1024 MB data to file 0.txt in statefulset 0
@@ -59,6 +60,7 @@ Stress Volume Node CPU When Volume Is Online Expanding
     END
 
 Stress Volume Node CPU When Volume Is Offline Expanding
+    [Tags]    expansion
     Given Create storageclass longhorn-test with    dataEngine=${DATA_ENGINE}
     And Create statefulset 0 using RWO volume with longhorn-test storageclass
     And Write 1024 MB data to file 0.txt in statefulset 0
diff --git a/e2e/tests/negative/stress_filesystem.robot b/e2e/tests/negative/stress_filesystem.robot
@@ -45,6 +45,7 @@ Stress Volume Node Filesystem When Volume Is Detaching and Attaching
     END
 
 Stress Volume Node Filesystem When Volume Is Online Expanding
+    [Tags]    expansion
     Given Create storageclass longhorn-test with    dataEngine=${DATA_ENGINE}
     And Create statefulset 0 using RWO volume with longhorn-test storageclass
     And Write 1024 MB data to file data.txt in statefulset 0
@@ -58,6 +59,7 @@ Stress Volume Node Filesystem When Volume Is Online Expanding
     END
 
 Stress Volume Node Filesystem When Volume Is Offline Expanding
+    [Tags]    expansion
     Given Create storageclass longhorn-test with    dataEngine=${DATA_ENGINE}
     And Create statefulset 0 using RWO volume with longhorn-test storageclass
     And Write 1024 MB data to file data.txt in statefulset 0
diff --git a/e2e/tests/negative/stress_memory.robot b/e2e/tests/negative/stress_memory.robot
@@ -46,6 +46,7 @@ Stress Volume Node Memory When Volume Is Detaching and Attaching
     END
 
 Stress Volume Node Memory When Volume Is Online Expanding
+    [Tags]    expansion
     Given Create storageclass longhorn-test with    dataEngine=${DATA_ENGINE}
     And Create statefulset 0 using RWO volume with longhorn-test storageclass
     And Write 1024 MB data to file 0.txt in statefulset 0
@@ -60,6 +61,7 @@ Stress Volume Node Memory When Volume Is Online Expanding
     END
 
 Stress Volume Node Memory When Volume Is Offline Expanding
+    [Tags]    expansion
     Given Create storageclass longhorn-test with    dataEngine=${DATA_ENGINE}
     And Create statefulset 0 using RWO volume with longhorn-test storageclass
     And Write 1024 MB data to file 0.txt in statefulset 0
diff --git a/e2e/tests/negative/test_dr_volume.robot b/e2e/tests/negative/test_dr_volume.robot
@@ -127,7 +127,7 @@ Sync Up With Backup Target During DR Volume Activation
     Then Check pod 0 file version-info.txt has checksum d51dc42f616b67126fd2aa1e1f43385b
 
 Test DR Volume Live Upgrade And Rebuild
-    [Tags]    manual    negative    dr-volume-live-upgrade-and-rebuild
+    [Tags]    manual    negative    dr-volume-live-upgrade-and-rebuild    expansion    upgrade
     [Documentation]    - Test DR volume live upgrade and rebuild
     ...                Related Issue:
     ...                https://github.com/longhorn/longhorn/issues/1279
@@ -248,7 +248,7 @@ Test DR Volume Live Upgrade And Rebuild
     And Check pod 2 works
 
 Test DR Volume Incremental Restore After Source Volume Expansion
-    [Tags]    manual    negative    dr-volume-expansion
+    [Tags]    manual    negative    dr-volume-expansion    expansion
     [Documentation]    - Test DR Volume Incremental Restore After Source Volume Expansion
     ...                Related Issue:
     ...                https://github.com/longhorn/longhorn/issues/11767
diff --git a/e2e/tests/regression/test_encrypted_volume.robot b/e2e/tests/regression/test_encrypted_volume.robot
@@ -48,7 +48,7 @@ Test Encrypted RWX Volume Basic
         RWX
 
 Test Encrypted RWO Volume Online Expansion
-    [Tags]    rwo
+    [Tags]    rwo    expansion
     Given Create crypto secret
     When Create storageclass longhorn-crypto with    encrypted=true    dataEngine=${DATA_ENGINE}
     And Create persistentvolumeclaim 0    volume_type=RWO    sc_name=longhorn-crypto    storage_size=50MiB
diff --git a/e2e/tests/regression/test_expansion.robot b/e2e/tests/regression/test_expansion.robot
@@ -42,3 +42,72 @@ Test Volume Expansion When Node Disk Is Full
     Then Expand volume 0 to 8Gi should fail
     And Wait for volume 0 size to be 3Gi
     And Delete volume 0
+
+Test Volume Expansion During Volume Cloning
+    [Documentation]    Issue: https://github.com/longhorn/longhorn/issues/11484
+    ...    1. Create a source volume. Write some data to the volume
+    ...    2. Create a target volume from the source volume
+    ...    3. While data cloning is still in progress, expand the size of target volume.
+    ...       Longhorn should block the expansion request. User can only expand the target volume after cloning finish
+    ...    4. Data in the target volume is intact after the expansion
+    Given Create storageclass longhorn-test with    dataEngine=${DATA_ENGINE}
+    And Create persistentvolumeclaim source-pvc    sc_name=longhorn-test    storage_size=2GiB
+    And Wait for volume of persistentvolumeclaim source-pvc to be created
+    And Wait for volume of persistentvolumeclaim source-pvc detached
+    And Create pod source-pod using persistentvolumeclaim source-pvc
+    And Wait for pod source-pod running
+    And Wait for volume of persistentvolumeclaim source-pvc healthy
+    And Write 1024 MB data to file data.txt in pod source-pod
+    And Record file data.txt checksum in pod source-pod as checksum source-pvc
+
+    FOR   ${i}    IN RANGE    5
+        When Create persistentvolumeclaim cloned-pvc-${i} from persistentvolumeclaim source-pvc    sc_name=longhorn-test    storage_size=2GiB
+        And Wait for volume of persistentvolumeclaim cloned-pvc-${i} to be created
+        And Wait for volume of persistentvolumeclaim cloned-pvc-${i} degraded
+        Then Expand persistentvolumeclaim cloned-pvc-${i} size to 3Gi
+        And Wait for volume of persistentvolumeclaim cloned-pvc-${i} detached
+        And Create pod cloned-pod-${i} using persistentvolumeclaim cloned-pvc-${i}
+        And Wait for pod cloned-pod-${i} running
+        And Wait for volume of persistentvolumeclaim cloned-pvc-${i} healthy
+        And Check pod cloned-pod-${i} file data.txt checksum matches checksum source-pvc
+    END
+
+Test Volume Expansion Without Schedulable Nodes
+    [Documentation]    Issue: https://github.com/longhorn/longhorn/issues/11484
+    ...    1. Disable scheduling for all nodes
+    ...    2. Create a volume of 1 GiB. Notice that it will be unschedulale because all nodes are disabled
+    ...    3. Try expand the volume. Note your have to use kubectl edit to change volume size
+    ...    4. Verify that Longhorn block the expansion request
+    Given Disable node 0 scheduling
+    And Disable node 1 scheduling
+    And Disable node 2 scheduling
+    And Create volume vol with    size=2Gi    dataEngine=${DATA_ENGINE}
+
+    When Run command and expect output
+    ...    kubectl patch volume -n longhorn-system vol --type='merge' -p '{"spec": {"size": "3221225472"}}'
+    ...    The request is invalid
+    Then Wait for volume vol size to be 2Gi
+
+Test Volume Expansion
+    [Documentation]    Issue: https://github.com/longhorn/longhorn/issues/11484
+    ...    1. Create a volume
+    ...    2. Make sure all replicas are schedule
+    ...    3. Expand the volume -> verify that it is ok
+    ...    4. Attach the volume
+    ...    5. Try to expand the volume again-> verify that it is ok
+    Given Create storageclass longhorn-test with    dataEngine=${DATA_ENGINE}
+    And Create persistentvolumeclaim 0    sc_name=longhorn-test    storage_size=2GiB
+    And Wait for volume of persistentvolumeclaim 0 to be created
+    And Wait for volume of persistentvolumeclaim 0 detached
+    # offline expansion
+    When Expand persistentvolumeclaim 0 size to 3Gi
+    Then Wait for volume of persistentvolumeclaim 0 size to be 3Gi
+    And Create pod 0 using persistentvolumeclaim 0
+    And Wait for pod 0 running
+    And Wait for volume of persistentvolumeclaim 0 healthy
+    And Write 1024 MB data to file data.txt in pod 0
+
+    # online expansion
+    When Expand persistentvolumeclaim 0 size to 4Gi
+    Then Wait for volume of persistentvolumeclaim 0 size to be 4Gi
+    And Check pod 0 data in file data.txt is intact
