add missing highligher impl; update the test checklist;

Author: youssefadly237

api/TESTING.md

@@ -24,306 +24,249 @@
 ## Checklist
 
 - [ ] pen
-
-  - [x] Wrapper
-  - [ ] legacy
+  - [ ] Wrapper
+  - [x] legacy
 
 - [ ] eraser
-
-  - [x] Wrapper
-  - [ ] legacy
+  - [ ] Wrapper
+  - [x] legacy
 
 - [ ] highlighter
-
-  - [x] Wrapper
-  - [ ] legacy
+  - [ ] Wrapper
+  - [x] legacy
 
 - [ ] hand
-
-  - [x] Wrapper
-  - [ ] legacy
+  - [ ] Wrapper
+  - [x] legacy
 
 - [ ] text
-
-  - [x] Wrapper
-  - [ ] legacy
+  - [ ] Wrapper
+  - [x] legacy
 
 - [ ] tex
-
-  - [x] Wrapper
+  - [ ] Wrapper
   - [ ] legacy
 
 - [ ] selectRegion
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] selectRectangle
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] selectObject
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] ruler
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] arrow
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] rectangle
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] ellipse
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] spline
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] fill
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] veryFine
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] fine
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] medium
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] thick
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] veryThick
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] plain
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] dotted
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] dashed
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] dashDotted
-
   - [ ] Wrapper
-  - [ ] legacy
-
-- [ ] changeToolColor
+  - [x] legacy
 
-  - [ ] Wrapper
-  - [ ] legacy
+- [x] changeToolColor
 
 - [ ] delete
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] undo
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] redo
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] zoomIn
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
-- [ ] zoomOut
+  zooming works but there is something wrong with the mappping
 
+- [ ] zoomOut
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] newBefore
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] newAfter
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] copyPage
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] deletePage
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] moveUp
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] moveDown
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] newLayer
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] deleteLayer
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] layerDown
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] layerUp
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] currentPage
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] goToFirstPage
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] goToLastPage
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] goToPage
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] goToTop
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] goToBottom
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] goToPos
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] scrollPageUp
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] scrollPageDown
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] plainBG
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] ruledBG
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] graphBG
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] dottedGraphBG
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] isometricGraphBG
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] isometricDottedGraphBG
-
   - [ ] Wrapper
-  - [ ] legacy
+  - [x] legacy
 
 - [ ] open
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] save
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] saveAs
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] annotatePDF
-
   - [ ] Wrapper
   - [ ] legacy
 
 - [ ] exportAsPDF
-
   - [ ] Wrapper
   - [ ] legacy
 
-- [ ] getToolInfo
+- [ ] open Dialog
+  - [ ] Wrapper
+  - [x] legacy
 
+- [ ] getToolInfo
   - [ ] Wrapper
   - [ ] legacy

api/registry.lua

@@ -89,8 +89,14 @@ return {
     },
   },
   highlighter = {
-    { impl = wrapper.highlighter, deps = {} },
-    { impl = legacy.highlighter, deps = {} },
+    {
+      impl = wrapper.highlighter,
+      deps = { 'changeActionState', 'app.C.Tool_highlighter' },
+    },
+    {
+      impl = legacy.highlighter,
+      deps = { 'uiAction' },
+    },
   },
   hand = {
     { impl = wrapper.hand, deps = { 'changeActionState', 'app.C.Tool_hand' } },

main.lua

@@ -5,8 +5,6 @@ package.path = script_path .. '?.lua;' .. script_path .. '?/init.lua;' .. packag
 local utils = require('utils')
 local log = utils.log
 
-local api = require('api')
-local registry = require('api.registry')
 require('keybindings')
 require('modes')
 

modes.lua

@@ -1,4 +1,3 @@
-local api = require('api')
 local utils = require('utils')
 local log = utils.log
 

utils.lua

@@ -1,7 +1,10 @@
 local utils = {}
 
-function utils.log(...)
-  print('[vi-xournalpp]', ...)
+--- Logs a string message with the [vi-xournalpp] prefix.
+--- @param str string
+--- @return nil
+function utils.log(str)
+  print('[vi-xournalpp] ' .. str)
 end
 
 return utils