Skip to content

Commit e70a128

Browse files
Merge pull request #214 from ls1intum/docs/pr-template-language-and-review-claim
Stop promising a review box that nothing unchecks
2 parents 4fa36bf + 7503184 commit e70a128

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
Thanks for contributing to Ares 2.
44
Fill in every section. Each section states what to write when it does not apply.
55
Tick boxes as [x], not [ x] and not [x ].
6+
Write in British English.
67
78
Each recurring instruction is repeated, in the same words, in every section where it
89
applies, so that reading the one section you are filling in is enough. They close every
@@ -320,6 +321,7 @@ No breaking changes or migration.
320321
- [ ] I followed the [guidelines for inclusive, diversity-sensitive and appreciative language](https://docs.artemis.tum.de/developer/guidelines/language).
321322
- [ ] I have self-reviewed the diff of this pull request.
322323
- [ ] Tests were added or updated for the behaviour changed here.
324+
- [ ] Javadoc follows the [AGENTS.md](AGENTS.md#documenting-java) conventions.
323325
- [ ] Documentation (`docs/`, `README.adoc`, Javadoc) was updated where the change is user-facing.
324326
- [ ] CI is green, or every remaining failure is explained above.
325327
- [ ] No secrets, tokens or absolute local paths are contained in the diff.
@@ -328,8 +330,6 @@ No breaking changes or migration.
328330

329331
<!--
330332
Reviewers tick what they have reviewed. Both boxes should be ticked before merge.
331-
When new commits are pushed, the affected box is unchecked again. Not every change
332-
requires a full re-review.
333333
334334
This section is always required. If a category does not apply, wrap its line in an HTML
335335
comment and state the reason inside the comment, rather than deleting it.

0 commit comments

Comments
 (0)