Skip to content

Commit 44bca1b

Browse files
committed
code quality improvements
1 parent 3db2d92 commit 44bca1b

3 files changed

Lines changed: 2 additions & 11 deletions

File tree

src/main/java/de/tum/cit/aet/analysis/service/AnalysisResultPersistenceService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -670,7 +670,7 @@ private CQIResultDTO calculateGitOnlyCqi(TeamRepositoryDTO repo, TeamParticipati
670670
gitComponents.pairProgrammingStatus() != null ? gitComponents.pairProgrammingStatus().name() : null);
671671
teamParticipationRepository.save(teamParticipation);
672672

673-
return CQIResultDTO.gitOnly(cqiCalculatorService.buildWeightsDTO(), gitComponents, filterResult.summary());
673+
return CQIResultDTO.gitOnly(cqiCalculatorService.buildWeightsDTO(null), gitComponents, filterResult.summary());
674674
}
675675
} catch (Exception e) {
676676
log.warn("Failed to calculate git-only metrics for team {}: {}", team.name(), e.getMessage());

src/main/java/de/tum/cit/aet/analysis/service/cqi/CQICalculatorService.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -240,15 +240,6 @@ public ComponentScoresDTO calculateGitOnlyComponents(
240240
temporalResult.dailyDistribution());
241241
}
242242

243-
/**
244-
* Build a {@link ComponentWeightsDTO} from the default configuration.
245-
*
246-
* @return DTO containing the default weights for all CQI components
247-
*/
248-
public ComponentWeightsDTO buildWeightsDTO() {
249-
return buildWeightsDTO(null);
250-
}
251-
252243
/**
253244
* Build a {@link ComponentWeightsDTO} from the exercise-specific or default configuration.
254245
*

src/main/webapp/src/components/CqiWeightsPanel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { Input } from '@/components/ui/input';
77
import { Label } from '@/components/ui/label';
88
import { Badge } from '@/components/ui/badge';
99
import { toast } from '@/hooks/use-toast';
10-
import { Settings, RotateCcw } from 'lucide-react';
10+
import { Settings, RotateCcw, ChevronRight } from 'lucide-react';
1111
import type { CqiWeightsDTO } from '@/app/generated';
1212
import { cqiWeightsApi } from '@/lib/apiClient';
1313

0 commit comments

Comments
 (0)