Skip to content

Commit 13b3d7f

Browse files
fix(scripts): name the real pnpm full-gate inputs
check:affected's full-gate list carried two placeholder filenames that exist nowhere, leaving pnpm-lock.yaml, pnpm-workspace.yaml, and patches/ covered only by the unknown-input fail-closed branch. Name them explicitly and cover them in the fail-closed test. Point the preview-controller control-plane test at the setup composite that actually exists, and record in pnpm-workspace.yaml why the router-plugin unplugin override pins 3.0.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 14398d5 commit 13b3d7f

4 files changed

Lines changed: 9 additions & 3 deletions

File tree

pnpm-workspace.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ allowBuilds:
2525
protobufjs: false
2626

2727
overrides:
28+
# unplugin 3.1+ declares an optional peer on the retired runtime's types package, whose name
29+
# would re-enter the lockfile and fail check:package-manager's repository-wide token ban.
2830
"@tanstack/router-plugin>unplugin": 3.0.0
2931
mermaid: 11.16.1
3032
vitest: 4.1.11

scripts/check-affected.test.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ await test("maps scopes to the documented commands", () => {
5959
await test("fails closed for shared, generated, contract, tooling, and unknown inputs", () => {
6060
for (const path of [
6161
"package.json",
62+
"pnpm-lock.yaml",
63+
"pnpm-workspace.yaml",
64+
"patches/zod@4.4.3.patch",
6265
".oxlintrc.json",
6366
"scripts/check-affected.ts",
6467
"server/openapi.yaml",

scripts/check-affected.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,9 @@ const fullGateInputs = [
3333
/^\.changeset\//,
3434
/^scripts\//,
3535
/^package\.json$/,
36-
/^node\.lock$/,
37-
/^nodefig\.toml$/,
36+
/^pnpm-lock\.yaml$/,
37+
/^pnpm-workspace\.yaml$/,
38+
/^patches\//,
3839
/^tsconfig(?:\.agents)?\.json$/,
3940
/^\.ox(?:fmt|lint)rc\.json$/,
4041
/^server\/openapi\.yaml$/,

scripts/preview-controller.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ void describe("preview controller admission", () => {
162162
void it("refuses PR-controlled changes to any part of the deployment control plane", async () => {
163163
for (const filename of [
164164
".github/workflows/reusable-docker-build.yml",
165-
".github/actions/setup-node/action.yml",
165+
".github/actions/setup-node-pnpm/action.yml",
166166
"docker/preview/compose.app.yaml",
167167
"docker/preview/.env.example",
168168
]) {

0 commit comments

Comments
 (0)