Skip to content

Commit c96eae4

Browse files
feat(workspace): adopt catalog practices without leaving practice setup (#1443)
1 parent 0755445 commit c96eae4

184 files changed

Lines changed: 10353 additions & 2374 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
"hephaestus": patch
3+
---
4+
5+
Practice setup no longer sends you to another page to look at something on it. Selecting a practice — one of yours, or one the library is offering — opens it beside the tree you were reading, and selecting something inside that opens on top of it, so you can go two levels deep and step back one at a time with Escape, a press on the page, the browser's Back button, or a swipe. The page behind stays readable rather than blurred, and each panel leaves a column of the one beneath it showing.
6+
7+
Your own practices now have a read-only view for the first time. Opening one used to mean opening the edit form, so "what does this practice say?" and "change this practice" were the same act; now reading is reading, and editing is one clearly marked step away. A practice looks the same whether you met it in the library or in your own tree, because both show the same definition.
8+
9+
Writing a practice no longer takes over the page either — on Practice setup and in the instance catalog, **Create** and **Edit** open beside the tree the practice belongs to, so you can see where it is going while you write it. An editor closes the same four ways everything else does — Escape, a press on the page beside it, a swipe, or its own controls — and asks before discarding unsaved changes on any of them, so nothing is lost and nothing silently refuses to close. The old addresses still work and open the same editor.
10+
11+
Adding a practice returns you to the library you were working through — the practice moves into your own tree and stops being offered — instead of dropping you into an edit form. Adding five practices is now five selections rather than five round trips. Everything is addressable: the URL you are looking at is the URL you can share, and it reopens exactly the panels you had open.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"hephaestus": minor
3+
---
4+
5+
Deciding whether to adopt a practice now starts with why the habit matters, not with the rule the reviewer follows. The rule is still there, under **How it decides**, next to what the practice reads and what it measures first — but it is written for the model that applies it, runs to several thousand characters, and is not what you need in order to choose.
6+
7+
The library list carries each practice's reason too, so you can work through the catalog without opening every entry to find out what it is for.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"hephaestus": patch
3+
---
4+
5+
Creating or editing a practice area now lets you pick its icon and colour, the same way the instance library does. Left alone, both still follow the area's name.
6+
7+
A practice's "What to look for" is written in markdown — the editor says so — and the read view now renders it. Headings, lists, emphasis and inline code used to reach you as literal `##` and `-` characters in one long paragraph of bold text.

.changeset/calm-practices-adopt.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
"hephaestus": minor
3+
---
4+
5+
Workspace administrators now choose which practices their workspace reviews, instead of receiving a copy of the instance library at creation. Practice setup shows the library beside the practices you already have, so you can read a practice's full definition, the evidence it needs, and what it will look like in your workspace before you add it. Adding one gives you an independent copy you can edit; later library changes never rewrite it. A whole group can be added at once, and a group you removed earlier can be restored from the same place.
6+
7+
Adding never starts sending feedback on its own. A practice Hephaestus can review starts at **Review before sending**, and a practice it cannot review stays **Off** until you connect what it reads.
8+
9+
You can also add a whole area at once. Hephaestus shows every practice it would add, reuse, or skip first, and applies the result in one step or not at all. Adding is refused if the library or your workspace changed while you were reading the preview, so you always act on what you saw.
10+
11+
Workspaces you already have keep everything in them, and a workspace that has never recorded a catalog installation still receives one at the next start, so nothing goes missing.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"hephaestus": patch
3+
---
4+
5+
Fixes three faults in the sliding panels used across practice setup and the instance catalog. A panel now slides in from the edge instead of appearing fully formed. Opening a panel on top of another no longer makes the one behind jump back and re-animate when you step back out of it. And a covered panel keeps a readable column of its own content on screen rather than a bare strip of its margin, which is the whole reason these stack instead of replacing each other.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"hephaestus": patch
3+
---
4+
5+
When the library changes while you are reading an area's plan, the panel now stays open and shows you the refreshed plan, the same way a single practice already did. It used to close and leave you a message asking you to go and look at the area again.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"hephaestus": patch
3+
---
4+
5+
A panel covered by another one now leaves noticeably more of itself showing, so the thing you opened from stays readable rather than reduced to a stripe of its margin.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"hephaestus": patch
3+
---
4+
5+
Tidies the practice and group editors. Their Save and Cancel buttons now sit on the panel's own bottom edge, spanning it, instead of floating in a bar that stopped short of both sides and left a strip of empty space beneath it. The fields fill the panel rather than stopping partway across, so the buttons line up with them. Panel headings no longer squeeze the practice name into a narrow column beside a badge — the badge moves under the name, which leaves the name room to read on a phone. The scrollable part of a panel can also be scrolled from the keyboard, including while a form is saving and every field in it is disabled.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"hephaestus": patch
3+
---
4+
5+
Editing a practice no longer costs you your place: opening the editor from a practice panel and saving or cancelling returns you to that panel, with the catalog still open where you left it.
6+
7+
Rows that pair a label with a dropdown now stack on a narrow screen instead of squeezing the label into a sliver beside it.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"hephaestus": patch
3+
---
4+
5+
The practice screens say one thing one way. The set of practices an instance offers is the **catalog** everywhere, entries are **included** or **excluded** rather than offered, a practice with no group is **Unassigned**, and the grouping is called a **group** — or not named at all where its own name is already on screen.
6+
7+
Filtering the practice list to nothing now says so and gives you a button to clear the filter, instead of leaving you with empty groups and a note about a filter you had no way to remove.

0 commit comments

Comments
 (0)