Commit 53aabda
authored
fix(ci): clear knip unused-exports failures on dev (#119)
The `npm run knip` step in the TypeScript/Lint/Tests workflow has been
red on every push to dev since 55091f0. Two distinct sources:
- `MessageLoadResult` in `useChatStore.ts` was exported but only consumed
in the same file (as the type of an internal store field). Demote to a
file-private interface.
- `KnownBridgeKey` and `DataBridgeProbeResult` in
`theia/dataBridgeReader.ts` were exported (and re-exported through
`theia/index.ts`) for use as type annotations at call sites that
actually rely on TypeScript inference. The exports were never read.
Demote to file-private and drop the barrel re-exports.
Also drop the redundant `esbuild.js` entry from `knip.json` — knip
auto-detects build configs and was flagging it as a configuration hint.
After this commit, `npm run knip` exits 0 locally with no warnings.1 parent a292111 commit 53aabda
4 files changed
Lines changed: 3 additions & 5 deletions
File tree
- extension
- src
- extension/theia
- webview/stores
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
| 104 | + | |
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | 6 | | |
8 | 7 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
0 commit comments