fix: don't drain view disposables on render, only on re-resolve

_resetReadyState() is called from both resolveWebviewView() and
render(). The previous commit drained _viewDisposables inside
_resetReadyState(), which destroyed message/visibility/config
listeners on every render() call. In ArtemisWebviewProvider, render()
fires on every sidebar view switch, killing all communication after
the first navigation.

Move _drainViewDisposables() to resolveWebviewView() only, where
new listeners are registered immediately after.

Author: Predixx

extension/src/extension/provider/artemisWebviewProvider.ts

@@ -164,6 +164,7 @@ export class ArtemisWebviewProvider extends BaseWebviewProvider implements vscod
         context: vscode.WebviewViewResolveContext,
         _token: vscode.CancellationToken,
     ) {
+        this._drainViewDisposables();
         this._view = webviewView;
 
         this._resetReadyState();

extension/src/extension/provider/baseWebviewProvider.ts

@@ -61,7 +61,7 @@ export abstract class BaseWebviewProvider {
     }
 
     /** Dispose only the per-view-resolution disposables. */
-    private _drainViewDisposables(): void {
+    protected _drainViewDisposables(): void {
         while (this._viewDisposables.length > 0) {
             const d = this._viewDisposables.pop();
             d?.dispose();
@@ -82,7 +82,6 @@ export abstract class BaseWebviewProvider {
     protected _resetReadyState(): void {
         this._webviewReady = false;
         this._pendingMessages = [];
-        this._drainViewDisposables();
     }
 
     /** Hard cap on pending messages to prevent unbounded growth. */

extension/src/extension/provider/chatWebviewProvider.ts

@@ -189,6 +189,7 @@ export class ChatWebviewProvider extends BaseWebviewProvider implements vscode.W
         _token: vscode.CancellationToken,
     ) {
         logger.debug('Iris Chat webview being resolved/loaded', LogCategory.VIEW);
+        this._drainViewDisposables();
         this._view = webviewView;
         this._resetReadyState();