fix(recording): final codex review findings — viewer sync, chat pending terminal, startup fileSwitch filter

- Fix sync-types.mjs path (extension/src/services/ -> extension/src/extension/services/) so the script is no longer broken with ENOENT; regenerate recordingTypes.ts which now includes ConsentChangeEvent, StartupPhaseCompleteEvent, BuildResultEvent scoping fields, and InterventionEvent blocked/dismissReason/rawWanted fields; add consentChange + startupPhaseComplete to MARKER_COLORS and ALL_EVENT_TYPES in constants.ts
- Fix orphaned pending IrisChatSendAttempt: fire status='failed' with send-rejected reason whenever sendMessage() returns result.sent===false, before handling the per-reason UX side-effects
- Fix startup fileSwitch privacy leak: check shouldRecordUri on the active editor URI before emitting the event so out-of-exercise or blacklisted-scheme files are excluded

Author: Predixx

extension/src/extension/provider/chatWebviewProvider.ts

@@ -633,6 +633,12 @@ export class ChatWebviewProvider extends BaseWebviewProvider implements vscode.W
                 this._onDidAttemptIrisChatSend.fire({ content, status: 'sent' });
                 this._onDidSendIrisChatMessage.fire(content);
             } else {
+                // Fire terminal 'failed' so the pending event is never orphaned.
+                this._onDidAttemptIrisChatSend.fire({
+                    content,
+                    status: 'failed',
+                    errorMessage: `send-rejected: ${result.reason ?? 'unknown'}`,
+                });
                 switch (result.reason) {
                     case 'no-ai':
                         this._postNoAiStatus(true);

extension/src/extension/services/telemetry/recording/sessionRecorder.ts

@@ -1375,14 +1375,14 @@ export class SessionRecorder implements vscode.Disposable, WebSocketMessageHandl
         }
 
         // 3. fileSwitch for the active editor (if any).
-        const activeUri = vscode.window.activeTextEditor?.document.uri.toString();
-        if (activeUri) {
+        const activeUri = vscode.window.activeTextEditor?.document.uri;
+        if (activeUri && shouldRecordUri(activeUri, this._exerciseRootUri)) {
             this._recordInternal(
-                { type: 'fileSwitch', timestamp: Date.now(), fromUri: undefined, toUri: activeUri },
+                { type: 'fileSwitch', timestamp: Date.now(), fromUri: undefined, toUri: activeUri.toString() },
                 { allowDuringStartup: true },
                 generation,
             );
-            this._lastActiveEditorUri = activeUri;
+            this._lastActiveEditorUri = activeUri.toString();
         }
 
         // 4. terminalOpenClose('opened') for every already-open terminal.

recording-viewer/scripts/sync-types.mjs

@@ -10,11 +10,11 @@ import { dirname, join } from 'path';
 import { fileURLToPath } from 'url';
 
 const __dirname = dirname(fileURLToPath(import.meta.url));
-const SOURCE = join(__dirname, '..', '..', 'extension', 'src', 'services', 'telemetry', 'recording', 'types.ts');
+const SOURCE = join(__dirname, '..', '..', 'extension', 'src', 'extension', 'services', 'telemetry', 'recording', 'types.ts');
 const DEST = join(__dirname, '..', 'src', 'generated', 'recordingTypes.ts');
 
 const HEADER = `// DO NOT EDIT — auto-generated by sync-types.mjs
-// Source: extension/src/services/telemetry/recording/types.ts
+// Source: extension/src/extension/services/telemetry/recording/types.ts
 `;
 
 let source = readFileSync(SOURCE, 'utf-8');

recording-viewer/src/constants.ts

@@ -12,6 +12,8 @@ export const MARKER_COLORS: Record<EventType, string> = {
     fileSnapshot: '#4ade80',
     sessionStart: '#a5b4fc',
     sessionEnd: '#f87171',
+    consentChange: '#fb7185',
+    startupPhaseComplete: '#a5f3fc',
     irisChatMessage: '#f472b6',
     irisChatSendAttempt: '#fb923c',
     irisChatFeedback: '#a78bfa',
@@ -31,7 +33,7 @@ export const MARKER_COLORS: Record<EventType, string> = {
 };
 
 export const ALL_EVENT_TYPES = [
-    'sessionStart', 'sessionEnd',
+    'sessionStart', 'sessionEnd', 'consentChange', 'startupPhaseComplete',
     'eqSnapshot', 'eqEngineState', 'intervention', 'buildResult',
     'textChange', 'save',
     'diagnostics',

recording-viewer/src/generated/recordingTypes.ts

@@ -1,5 +1,5 @@
 // DO NOT EDIT — auto-generated by sync-types.mjs
-// Source: extension/src/services/telemetry/recording/types.ts
+// Source: extension/src/extension/services/telemetry/recording/types.ts
 // ── Serialization helpers ─────────────────────────────────────────────
 
 export interface SerializedRange {
@@ -56,9 +56,16 @@ export interface BuildResultEvent {
     timestamp: number;
     successful: boolean | undefined;
     errorCount: number;
+    /** Legacy: flat array of detailText strings for failed test feedbacks. Kept for backwards compat. */
     failedTests: string[];
     buildFailed: boolean;
     buildErrorFamilies?: string[];
+    // Scoping fields (added in Block F)
+    exerciseId?: number;
+    participationId?: number;
+    submissionId?: number;
+    /** Structured failed-test details carrying both the test name and the failure message. */
+    failedTestDetails?: { testName: string; detail: string }[];
 }
 
 export interface WindowFocusEvent {
@@ -80,7 +87,7 @@ export interface SessionStartEvent {
     exerciseId: number;
     participantId: string | undefined;
     exerciseRoot?: string;
-    /** Schema version for forward-compat parsing. Introduced in Block AB (version 2). */
+    /** Schema version for forward-compat parsing. Block AB introduces version 2. */
     schemaVersion?: number;
 }
 
@@ -90,16 +97,47 @@ export interface SessionEndEvent {
     exerciseId: number;
 }
 
+/**
+ * Emitted when user consent is downgraded (or upgraded) mid-session.
+ * Minimal payload — carries no user data — acts as a marker only. The
+ * downgraded path is followed by a `sessionEnd` and metadata finalisation.
+ */
+export interface ConsentChangeEvent {
+    type: 'consentChange';
+    timestamp: number;
+    level: 'downgraded' | 'upgraded';
+}
+
+/**
+ * Marker event indicating that all synchronous startup work (snapshots,
+ * initial diagnostics, initial-state events, startup contributors) has been
+ * flushed to the event stream. Consumers can use this as a cut-point for
+ * deterministic "seed state vs. runtime events" separation.
+ */
+export interface StartupPhaseCompleteEvent {
+    type: 'startupPhaseComplete';
+    timestamp: number;
+}
+
 export interface IrisChatMessageEvent {
     type: 'irisChatMessage';
     timestamp: number;
     direction: 'sent' | 'received';
     content: string;
+    // Added in Block H: optional metadata from server response / WebSocket payload
     messageId?: string;
     sessionId?: string;
     sentAt?: number;
 }
 
+/**
+ * Records a send attempt lifecycle: pending (before API call), sent (on success),
+ * or failed (on error). Emitted in addition to irisChatMessage so that:
+ *  - Failed sends (which produce no irisChatMessage) are still visible in the recording.
+ *  - The pending→sent timing is available for latency analysis.
+ *
+ * Lifecycle: pending → sent  OR  pending → failed
+ */
 export interface IrisChatSendAttemptEvent {
     type: 'irisChatSendAttempt';
     timestamp: number;
@@ -108,6 +146,10 @@ export interface IrisChatSendAttemptEvent {
     errorMessage?: string;
 }
 
+/**
+ * Records a helpful/unhelpful rating submitted by the user for a received
+ * Iris message. Wired up when the webview's feedback UI fires the event.
+ */
 export interface IrisChatFeedbackEvent {
     type: 'irisChatFeedback';
     timestamp: number;
@@ -143,12 +185,21 @@ export interface EqEngineStateEvent {
 export interface InterventionEvent {
     type: 'intervention';
     timestamp: number;
-    action: 'shown' | 'accepted' | 'dismissed';
+    action: 'shown' | 'accepted' | 'dismissed' | 'blocked';
     level: 'subtle' | 'notification' | 'proactive';
     shouldIntervene: boolean;
     eq: number;
     confidence: 'sufficient' | 'insufficient';
     triggerType?: 'execution-error' | 'multiline-paste' | 'idle' | 'selection-maintained';
+    /** Populated when action='blocked'. Identifies why the intervention was blocked. */
+    blockedReason?: 'cooldown' | 'warmup' | 'session-limit' | 'low-confidence';
+    /** Populated when action='dismissed'. Identifies how the intervention was dismissed. */
+    dismissReason?: 'user-action' | 'hidden' | 'replaced' | 'session-end';
+    /**
+     * Whether the EQ was above the severity threshold, regardless of confidence/guardrails.
+     * Populated when action='blocked' to explain the signal that was suppressed.
+     */
+    rawWanted?: boolean;
 }
 
 export interface ViewNavigationEvent {
@@ -199,10 +250,17 @@ export interface TerminalOpenCloseEvent {
     terminalName: string;
 }
 
+/**
+ * Emitted once per URI after three consecutive snapshot-write failures.
+ * Acts as a permanent "give up" marker so consumers know a snapshot is
+ * missing and why. Written via `_writeLifecycleEvent` (bypass phase gate)
+ * only while recording is active.
+ */
 export interface FileSnapshotErrorEvent {
     type: 'fileSnapshotError';
     timestamp: number;
     uri: string;
+    /** Short human-readable reason, e.g. 'snapshot-write-failed-after-3-retries' or an fs error message. */
     reason: string;
 }
 
@@ -251,6 +309,8 @@ export type RecordedEvent =
     | FileSnapshotEvent
     | SessionStartEvent
     | SessionEndEvent
+    | ConsentChangeEvent
+    | StartupPhaseCompleteEvent
     | IrisChatMessageEvent
     | IrisChatSendAttemptEvent
     | IrisChatFeedbackEvent
@@ -279,7 +339,7 @@ export interface SessionMetadata {
     startTime: number;
     endTime: number | undefined;
     eventCount: number;
-    /** Schema version for forward-compat parsing. Introduced in Block D (version 2). */
+    /** Schema version for forward-compat parsing. Block D introduces version 2. */
     schemaVersion?: number;
     /** Recorder version string, set by storageWriter at write time. */
     recorderVersion?: string;