fix: add suggestion and improve compliance issue detection

- translate existing compliance suggestions during snippet mapping
- preserve suggestion meaning across languages
- require exact target-text matches for mapped snippets

Author: ge94zec

openapi/openapi.yaml

@@ -3905,9 +3905,10 @@ components:
           type: array
           items: {$ref: '#/components/schemas/ComplianceIssue'}
         jobId: {type: string, format: uuid}
+        text: {type: string, minLength: 1}
         toLang: {type: string}
         translatedText: {type: string, minLength: 1}
-      required: [complianceIssues, jobId, translatedText]
+      required: [complianceIssues, jobId, text, translatedText]
     MultipartUploadRequest:
       type: object
       properties:

src/main/java/de/tum/cit/aet/ai/dto/MapComplianceIssuesRequestDTO.java

@@ -11,6 +11,7 @@
 public record MapComplianceIssuesRequestDTO(
     String toLang,
     @NotNull UUID jobId,
+    @NotBlank String text,
     @NotBlank String translatedText,
     @NotNull List<ComplianceIssue> complianceIssues
 ) {}

src/main/java/de/tum/cit/aet/ai/service/AiService.java

@@ -520,9 +520,13 @@ public List<ComplianceIssue> mapComplianceIssues(MapComplianceIssuesRequestDTO r
             return List.of();
         }
 
-        String snippets = java.util.stream.IntStream.range(0, request.complianceIssues().size())
-            .mapToObj(index -> (index + 1) + "\t" + request.complianceIssues().get(index).getText().trim())
-            .collect(Collectors.joining("\n"));
+        String issues = request
+            .complianceIssues()
+            .stream()
+            .map(
+                issue -> "Text: " + issue.getText().trim() + "\nSuggestion: " + (issue.getSuggestion() == null ? "" : issue.getSuggestion())
+            )
+            .collect(Collectors.joining("\n---\n"));
 
         List<String> mappedTexts;
         try {
@@ -531,9 +535,10 @@ public List<ComplianceIssue> mapComplianceIssues(MapComplianceIssuesRequestDTO r
                 .user(u ->
                     u
                         .text(snippetMappingResource)
-                        .param("count", String.valueOf(request.complianceIssues().size()))
-                        .param("snippets", snippets)
+                        .param("issues", issues)
+                        .param("jobDescription", request.text())
                         .param("translatedText", request.translatedText())
+                        .param("targetLanguage", request.toLang())
                 )
                 .call()
                 .entity(new ParameterizedTypeReference<List<String>>() {});
@@ -543,14 +548,14 @@ public List<ComplianceIssue> mapComplianceIssues(MapComplianceIssuesRequestDTO r
             throw new InternalServerException("Compliance issue mapping failed", e);
         }
 
-        if (mappedTexts == null || mappedTexts.size() != request.complianceIssues().size()) {
+        if (mappedTexts == null || mappedTexts.size() != request.complianceIssues().size() * 2) {
             aiFeatureToggleService.recordFailure();
             throw new InternalServerException("Mapping returned an invalid number of snippets");
         }
 
         List<ComplianceIssue> mappedIssues = new ArrayList<>();
         for (int i = 0; i < request.complianceIssues().size(); i++) {
-            String mappedText = mappedTexts.get(i);
+            String mappedText = mappedTexts.get(i * 2);
             String mapped = mappedText == null ? null : mappedText.trim();
             if (!SnippetMatcher.isVerbatim(request.translatedText(), mapped)) {
                 log.warn("Snippet {} not found in translated text, dropping", i);
@@ -565,7 +570,7 @@ public List<ComplianceIssue> mapComplianceIssues(MapComplianceIssuesRequestDTO r
                     sourceIssue.getArticle(),
                     sourceIssue.getExplanation(),
                     sourceIssue.getAction(),
-                    sourceIssue.getSuggestion(),
+                    mappedTexts.get(i * 2 + 1).trim(),
                     request.toLang()
                 )
             );

src/main/resources/prompts/AnalyzeComplianceText.st

@@ -7,7 +7,7 @@ TASK:
 Deeply analyze the job posting for legal risks (AGG, DSGVO, WissZeitVG) based on German and EU law.
 The input description language is: {descriptionLanguage}.
 EXPLANATIONS must be written in: {userLang}.
-SUGGESTIONS must be written in: {descriptionLanguage}.
+SUGGESTIONS must be written in: {descriptionLanguage}
 
 SSTRICT ANALYSIS RULES:
  1. NO SUMMARIES: Every single violation must be a separate JSON object.
@@ -35,8 +35,8 @@ CATEGORIES & ACTIONS:
   - Detect mentions of THIRD PARTIES/TOOLS (Workday, Headhunter, Partner Uni, consortia) without stating that data is shared with them.
   - If entire jobDescription does NOT contain a sentence clarifying that applicant data is shared with external recipients, flag detected mention
   - NOT triggered by: When explicit DATA is requested from the applicant. DO NOT confuse this with MINIMIZATION. Do not flag links here. Flag the MENTION of external partners.
-  - TRANSPARENCY SUGGESTION: suggestion must be a consent-based sentence like: By applying, you consent to your data being shared with "third party" for the purpose of the application process (Art. 13 DSGVO)
-  - Before reporting an ADD issue, check the entire description for an equivalent disclosure. Never suggest information that is already present, even with different wording.
+  - TRANSPARENCY SUGGESTION: suggestion must be a consent-based sentence like: By applying, you consent to your data being shared with "third party" for the purpose of the application process (Art. 13 DSGVO).
+  - Before reporting an ADD issue, check the entire description for an EQUIVALENT disclosure. Never suggest information that is already present, even with different wording.
   - Every ADD suggestion must be one grammatically independent, complete sentence. Never start it with a comma, conjunction, or subordinate clause.
 4. PUBLIC_SECTOR (action: ADD):
   - FOCUS: Qualification Purpose (WissZeitVG).
@@ -50,14 +50,6 @@ INPUT TEXT:
 {jobDescription}
 ----------------------
 
-COMPLETENESS REQUIREMENT:
-Before returning the JSON, you MUST internally conduct 4 separate passes over the ENTIRE text:
-Pass 1: Check every sentence for implicit/explicit AGG and vague language skills.
-Pass 2: Check every sentence for uncontrolled data intake or external URLs (Minimization).
-Pass 3: Check every sentence for mentions of external collaborators without privacy clauses (Transparency).
-Pass 4: Check for WissZeitVG purpose.
-The output MUST contain the combined findings of all passes.
-
 OUTPUT:
   Return ONLY a valid JSON array. No markdown. No prose.
   Object fields must be exactly:

src/main/resources/prompts/SnippetMapping.st

@@ -1,18 +1,19 @@
-Map every numbered source issue to the exact phrase in TARGET that expresses the same issue.
-Return exactly {count} strings, one per issue, preserving order and duplicates.
-Every non-empty result MUST be copied verbatim from TARGET. Use "" only if no matching phrase exists.
-Do not analyze compliance. Output one JSON string array immediately, without reasoning, prose, or markdown.
+For each source issue, map its text to the exact phrase in TARGET that expresses the same issue.
+Directly after each mapped text, return that issue's existing suggestion translated into {targetLanguage} without changing its meaning.
+Return one flat JSON string array containing exactly two strings per issue, preserving order and duplicates.
+Every non-empty mapped text MUST be copied verbatim from TARGET. Use "" if no matching phrase or source suggestion exists.
+Do not create new suggestions or analyze compliance. Output the JSON array immediately, without reasoning, prose, or markdown.
 
 --- EXAMPLE ---
 TARGET: Wir suchen ein junges, dynamisches Team für unsere Arbeitsgruppe.
 ISSUES:
-1	young and dynamic team
-2	must hold a German passport
-OUTPUT: ["junges, dynamisches Team", ""]
+Text: young and dynamic team
+Suggestion: experienced team
+OUTPUT: ["junges, dynamisches Team", "erfahrenes und dynamisches Team"]
 
 --- INPUT ---
 TARGET:
 {translatedText}
 
 ISSUES:
-{snippets}
+{issues}

src/main/webapp/app/generated/model/map-compliance-issues-request-dto.ts

@@ -3,7 +3,7 @@
  * No description provided (generated by Openapi Generator https://github.com/openapitools/openapi-generator)
  *
  * API Version: v0
- * 
+ *
  *
  * NOTE: This file is auto-generated. Do not edit manually.
  */
@@ -13,6 +13,7 @@ import type { ComplianceIssue } from './compliance-issue';
 export interface MapComplianceIssuesRequestDTO {
     readonly complianceIssues: Array<ComplianceIssue>;
     readonly jobId: string;
+    readonly text: string;
     readonly toLang?: string;
     readonly translatedText: string;
 }

src/main/webapp/app/job/job-creation-form/job-creation-form.component.ts

@@ -1822,7 +1822,7 @@ export class JobCreationFormComponent {
     if (text === lastBaseline) {
       const targetHtml = targetLang === 'en' ? this.jobDescriptionEN() : this.jobDescriptionDE();
       try {
-        await this.mapIssuesToTargetLanguage(targetLang, targetHtml, sourceIssuesPromise, jobId);
+        await this.mapIssuesToTargetLanguage(text, targetLang, targetHtml, sourceIssuesPromise, jobId);
       } catch {
         // Silent mapping failure — the next analysis can retry without retranslating.
       }
@@ -1865,6 +1865,8 @@ export class JobCreationFormComponent {
         abortController.signal,
       );
 
+      if (this.translationAbortController !== abortController) return;
+
       let hasTranslation = false;
       let finalContent: string | undefined = '';
       if (accumulatedContent) {
@@ -1905,7 +1907,7 @@ export class JobCreationFormComponent {
           const saved = await firstValueFrom(this.jobApi.updateJob(jobId, currentData));
           this.lastSavedData.set(saved);
 
-          await this.mapIssuesToTargetLanguage(targetLang, finalContent ?? '', sourceIssuesPromise, jobId);
+          await this.mapIssuesToTargetLanguage(text, targetLang, finalContent ?? '', sourceIssuesPromise, jobId);
         } catch {
           // Silent save failure — will be caught by next autosave
         }
@@ -1921,6 +1923,7 @@ export class JobCreationFormComponent {
 
   /** Maps source issues to an existing target text and applies actions accepted while mapping was pending. */
   private async mapIssuesToTargetLanguage(
+    sourceText: string,
     targetLang: Language,
     targetHtml: string,
     sourceIssuesPromise: Promise<ComplianceIssue[] | undefined>,
@@ -1936,6 +1939,7 @@ export class JobCreationFormComponent {
         this.aiApi.mapComplianceIssues({
           toLang: targetLang,
           jobId,
+          text: extractTextFromHtml(sourceText),
           translatedText: extractTextFromHtml(targetHtml),
           complianceIssues: sourceIssues,
         }),

src/test/webapp/app/job/job-creation-form/job-creation-form.component.spec.ts

@@ -842,6 +842,7 @@ describe('JobCreationFormComponent', () => {
       expect(mapSpy).toHaveBeenCalledWith({
         toLang: 'de',
         jobId: 'job1',
+        text: 'Hello',
         translatedText: 'Hallo',
         complianceIssues: [sourceIssue],
       });
@@ -876,6 +877,7 @@ describe('JobCreationFormComponent', () => {
       expect(mapSpy).toHaveBeenCalledWith({
         toLang: 'de',
         jobId: 'job1',
+        text: 'Hello dynamic team.',
         translatedText: 'Hallo dynamisches Team.',
         complianceIssues: [sourceIssue],
       });