Skip to content

Commit 671038e

Browse files
committed
update to node 24
also improve a few aspects in the Dockerfile
1 parent dd7e3fe commit 671038e

2 files changed

Lines changed: 17 additions & 19 deletions

File tree

Dockerfile

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,25 @@
1-
FROM maven:3-eclipse-temurin-21
1+
FROM maven:3.9.11-eclipse-temurin-21
22

3-
MAINTAINER Stephan Krusche <krusche@in.tum.de>
3+
LABEL maintainer="Stephan Krusche <krusche@tum.de>"
44

55
RUN apt-get update && apt-get upgrade -y && apt-get install -y locales
66

77
# Set the locale
88
RUN locale-gen en_US.UTF-8
9-
ENV LANG en_US.UTF-8
10-
ENV LANGUAGE en_US:en
11-
ENV LC_ALL en_US.UTF-8
9+
10+
ENV LANG=en_US.UTF-8 \
11+
LANGUAGE=en_US:en \
12+
LC_ALL=en_US.UTF-8 \
13+
M2_HOME=/usr/share/maven
1214

1315
# Also install Java 17 (needed for running PE templates)
14-
RUN apt-get update && apt-get install -y \
15-
gnupg openjdk-17-jdk \
16-
&& curl -sL https://deb.nodesource.com/setup_22.x | bash - \
17-
&& apt-get update && apt-get install -y \
18-
nodejs \
19-
&& rm -rf /var/lib/apt/lists/*
16+
RUN apt-get update && apt-get install -y --no-install-recommends gnupg openjdk-17-jdk && \
17+
curl -sL https://deb.nodesource.com/setup_24.x | bash - && \
18+
apt-get update && apt-get install -y --no-install-recommends nodejs && \
19+
rm -rf /var/lib/apt/lists/*
2020

2121
# update npm to use the latest version
22-
RUN npm install -g npm@latest
23-
24-
ENV M2_HOME /usr/share/maven
22+
RUN npm install -g npm@11.4.2
2523

2624
RUN echo "$LANG -- $LANGUAGE -- $LC_ALL" \
2725
&& curl --version \

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# docker-jdk-node-yarn
22
Docker Container for Docker Hub
33

4-
docker build --platform linux/amd64 --no-cache -t openjdk-node-yarn .
4+
docker build --no-cache -t openjdk-node-yarn .
55

66
docker run -itd -p 80:80 --name openjdk-node-yarn openjdk-node-yarn /bin/bash
77

@@ -37,7 +37,7 @@ Try out if everything works correctly when testing a Spring Boot Application, e.
3737

3838
#### Example
3939

40-
git tag java17node16
40+
git tag java21node24-1
4141

4242
git push --tags
4343

@@ -50,11 +50,11 @@ Try out if everything works correctly when testing a Spring Boot Application, e.
5050

5151
docker rmi openjdk-node-yarn
5252

53-
docker rmi ls1tum/openjdk-node-yarn:java21node22-2
53+
docker rmi ls1tum/openjdk-node-yarn:java21node24-1
5454

55-
docker pull ls1tum/openjdk-node-yarn:java21node22-2
55+
docker pull ls1tum/openjdk-node-yarn:java21node22-1
5656

57-
docker run -itd -p 80:80 --name openjdk-node-yarn ls1tum/openjdk-node-yarn:java21node22-2 /bin/bash
57+
docker run -itd -p 80:80 --name openjdk-node-yarn ls1tum/openjdk-node-yarn:java21node24-1 /bin/bash
5858

5959
docker exec -it openjdk-node-yarn /bin/bash
6060

0 commit comments

Comments
 (0)