Merge branch 'develop' into renovate/postgres-18.x

Author: krusche

.github/workflows/e2e_tests.yml

@@ -169,15 +169,15 @@ jobs:
           KEYCLOAK_CLIENT_ID: thesis-management-app
 
       - name: Upload Playwright report
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         if: ${{ !cancelled() }}
         with:
           name: playwright-report
           path: client/playwright-report/
           retention-days: 14
 
       - name: Upload test results
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         if: ${{ !cancelled() }}
         with:
           name: playwright-results

.github/workflows/run_tests.yml

@@ -35,15 +35,15 @@ jobs:
           ./gradlew test jacocoTestReport
 
       - name: Upload Coverage Report
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         if: always()
         with:
           name: coverage-report
           path: server/build/reports/jacoco/test/html/
           retention-days: 14
 
       - name: Upload Test Results
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         if: always()
         with:
           name: test-results

client/e2e/application-review-workflow.spec.ts

@@ -1,5 +1,13 @@
 import { test, expect } from '@playwright/test'
 import { authStatePath, navigateToDetail, selectOption } from './helpers'
+import {
+  snapshotMailbox,
+  waitForNewMessages,
+  getBody,
+  getToAddresses,
+  assertSentFromApp,
+  findBySubject,
+} from './mailpit'
 
 const APPLICATION_REJECT_ID = '00000000-0000-4000-c000-000000000004' // student4 on topic 1, NOT_ASSESSED
 const APPLICATION_ACCEPT_ID = '00000000-0000-4000-c000-000000000005' // student5 on topic 2, NOT_ASSESSED
@@ -14,7 +22,6 @@ test.describe('Application Review Workflow', () => {
     if (!loaded) return // Application not accessible (may have been modified by a parallel test)
 
     // Check if application still has the review form (NOT_ASSESSED state)
-    // A prior test run may have rejected this application and DB wasn't re-seeded
     const thesisTitle = page.getByLabel('Thesis Title')
     const hasReviewForm = await thesisTitle.isVisible({ timeout: 5_000 }).catch(() => false)
     if (!hasReviewForm) {
@@ -28,24 +35,43 @@ test.describe('Application Review Workflow', () => {
 
     // Modal should open with "Reject Application" title
     await expect(page.getByRole('dialog')).toBeVisible({ timeout: 5_000 })
-    await expect(
-      page.getByRole('dialog').getByText('Reject Application').first(),
-    ).toBeVisible()
+    await expect(page.getByRole('dialog').getByText('Reject Application').first()).toBeVisible()
 
-    // "Topic requirements not met" should be the default selected reason for topic-based applications
+    // "Topic requirements not met" should be the default selected reason
     await expect(page.getByText('Topic requirements not met')).toBeVisible()
 
     // "Notify Student" checkbox should be checked by default
     const notifyCheckbox = page.getByRole('dialog').getByLabel('Notify Student')
     await expect(notifyCheckbox).toBeChecked()
 
+    // Snapshot mailbox before the action
+    const beforeIds = await snapshotMailbox('student4@test.local')
+
     // Click "Reject Application" button in the modal
     await page.getByRole('dialog').getByRole('button', { name: 'Reject Application' }).click()
 
     // Verify success notification
     await expect(page.getByText('Application rejected successfully')).toBeVisible({
       timeout: 10_000,
     })
+
+    // --- Email verification ---
+    // Rejection with "Notify Student" sends APPLICATION_REJECTED_TOPIC_REQUIREMENTS
+    const newEmails = await waitForNewMessages('student4@test.local', beforeIds)
+    expect(newEmails.length).toBeGreaterThanOrEqual(1)
+
+    const rejectionEmail = findBySubject(newEmails, 'Thesis Application Rejection')
+    expect(rejectionEmail, 'Rejection email with correct subject should be sent').toBeDefined()
+    assertSentFromApp(rejectionEmail!)
+    expect(getToAddresses(rejectionEmail!)).toContain('student4@test.local')
+
+    // Body should greet the student by first name and reference the topic title
+    const body = getBody(rejectionEmail!)
+    expect(body, 'Rejection email should greet the student').toContain('Student4')
+    expect(body, 'Rejection email should reference the topic title').toContain(
+      'Automated Code Review Using Large Language Models',
+    )
+    expect(body, 'Rejection email should mention requirements').toContain('requirements')
   })
 
   test('advisor can accept a NOT_ASSESSED application', async ({ page }) => {
@@ -54,7 +80,6 @@ test.describe('Application Review Workflow', () => {
     if (!loaded) return // Application not accessible
 
     // Check if application still has the review form (NOT_ASSESSED state)
-    // A prior test run may have accepted this application and DB wasn't re-seeded
     const thesisTitle = page.getByLabel('Thesis Title')
     const hasReviewForm = await thesisTitle.isVisible({ timeout: 5_000 }).catch(() => false)
     if (!hasReviewForm) {
@@ -63,8 +88,6 @@ test.describe('Application Review Workflow', () => {
 
     // Verify the acceptance form has pre-filled fields from the topic
     await expect(thesisTitle).not.toHaveValue('')
-
-    // Thesis Type should be pre-filled
     await expect(page.getByRole('textbox', { name: 'Thesis Type' })).toBeVisible()
 
     // Thesis Language may not be pre-filled — fill it if empty
@@ -89,6 +112,9 @@ test.describe('Application Review Workflow', () => {
       timeout: 10_000,
     })
 
+    // Snapshot mailbox for student5 before the action
+    const beforeIds = await snapshotMailbox('student5@test.local')
+
     // Click "Accept" button
     const acceptButton = page.getByRole('button', { name: 'Accept', exact: true })
     await expect(acceptButton).toBeEnabled({ timeout: 10_000 })
@@ -98,5 +124,34 @@ test.describe('Application Review Workflow', () => {
     await expect(page.getByText('Application accepted successfully')).toBeVisible({
       timeout: 30_000,
     })
+
+    // --- Email verification ---
+    // Acceptance sends APPLICATION_ACCEPTED + THESIS_CREATED both to student5
+    const newEmails = await waitForNewMessages('student5@test.local', beforeIds, 2, 30_000)
+
+    // Verify acceptance email was sent to student5 (APPLICATION_ACCEPTED template)
+    const acceptanceEmail = findBySubject(newEmails, 'Thesis Application Acceptance')
+    expect(acceptanceEmail, 'Acceptance email should be sent').toBeDefined()
+    assertSentFromApp(acceptanceEmail!)
+    expect(getToAddresses(acceptanceEmail!)).toContain('student5@test.local')
+
+    // Body should greet student, mention the advisor, and include a thesis link
+    const acceptBody = getBody(acceptanceEmail!)
+    expect(acceptBody, 'Should greet the student by first name').toContain('Student5')
+    expect(acceptBody, 'Should mention the advisor for coordination').toContain('advisor')
+    expect(acceptBody, 'Should contain a link to the thesis').toContain('/theses/')
+
+    // Verify thesis creation email was also sent to student5 (THESIS_CREATED template)
+    const thesisEmail = findBySubject(newEmails, 'Thesis Created')
+    expect(thesisEmail, 'Thesis creation email should be sent').toBeDefined()
+    assertSentFromApp(thesisEmail!)
+    expect(getToAddresses(thesisEmail!)).toContain('student5@test.local')
+
+    // Body should contain the thesis title and a link to the thesis
+    const thesisBody = getBody(thesisEmail!)
+    expect(thesisBody, 'Should contain the thesis title').toContain(
+      'Continuous Integration Pipeline Optimization',
+    )
+    expect(thesisBody, 'Should contain a link to the thesis').toContain('/theses/')
   })
 })

client/e2e/application-workflow.spec.ts

@@ -6,6 +6,14 @@ import {
   navigateTo,
   selectOption,
 } from './helpers'
+import {
+  snapshotMailbox,
+  waitForNewMessages,
+  getBody,
+  getToAddresses,
+  assertSentFromApp,
+  findBySubject,
+} from './mailpit'
 
 test.describe('Application Workflow - Student submits application', () => {
   test.use({ storageState: authStatePath('student') })
@@ -89,12 +97,39 @@ test.describe('Application Workflow - Student submits application', () => {
       'I am highly motivated to work on CI pipeline optimization because it aligns with my research interests in DevOps and continuous integration.',
     )
 
+    // Snapshot mailbox BEFORE submitting (safe for parallel execution)
+    const beforeIds = await snapshotMailbox('student@test.local')
+
     const submitButton = page.getByRole('button', { name: 'Submit Application' })
     await expect(submitButton).toBeEnabled({ timeout: 10_000 })
     await submitButton.click()
 
     // Verify we're still on the application page (no crash)
     await page.waitForTimeout(2_000)
     await expect(page).toHaveURL(/\/submit-application/)
+
+    // --- Email verification ---
+    // Application submission sends:
+    // 1. APPLICATION_CREATED_STUDENT → student (confirmation with application details)
+    // 2. APPLICATION_CREATED_CHAIR → research group members (optional, depends on notification preferences)
+    const newEmails = await waitForNewMessages('student@test.local', beforeIds)
+
+    // Verify student confirmation email (APPLICATION_CREATED_STUDENT template)
+    const studentEmail = findBySubject(newEmails, 'Thesis Application Confirmation')
+    expect(studentEmail, 'Student confirmation email should be sent').toBeDefined()
+    assertSentFromApp(studentEmail!)
+    expect(getToAddresses(studentEmail!)).toContain('student@test.local')
+
+    // Body should contain: greeting, topic title, applicant details, and motivation
+    const studentBody = getBody(studentEmail!)
+    expect(studentBody, 'Body should greet the student by first name').toContain('Student')
+    expect(studentBody, 'Body should contain the topic/thesis title').toContain(
+      'Continuous Integration Pipeline Optimization',
+    )
+    expect(studentBody, 'Body should contain applicant email').toContain('student@test.local')
+    expect(studentBody, 'Body should reference the motivation text').toContain('CI pipeline')
+
+    // Note: APPLICATION_CREATED_CHAIR may also be sent to research group members,
+    // but it is filtered by notification preferences and goes to different recipients.
   })
 })

client/e2e/applications.spec.ts

@@ -22,7 +22,9 @@ test.describe('Applications - Student', () => {
 
     await expect(page.getByRole('heading', { name: /dashboard/i })).toBeVisible({ timeout: 30_000 })
     // Student should see My Applications section
-    await expect(page.getByRole('heading', { name: /my applications/i })).toBeVisible({ timeout: 15_000 })
+    await expect(page.getByRole('heading', { name: /my applications/i })).toBeVisible({
+      timeout: 15_000,
+    })
   })
 })
 

client/e2e/auth.setup.ts

@@ -10,7 +10,11 @@ const TEST_USERS = [
   { name: 'supervisor2', username: 'supervisor2', password: 'supervisor2' },
   { name: 'admin', username: 'admin', password: 'admin' },
   { name: 'delete_old_thesis', username: 'delete_old_thesis', password: 'delete_old_thesis' },
-  { name: 'delete_recent_thesis', username: 'delete_recent_thesis', password: 'delete_recent_thesis' },
+  {
+    name: 'delete_recent_thesis',
+    username: 'delete_recent_thesis',
+    password: 'delete_recent_thesis',
+  },
   { name: 'delete_rejected_app', username: 'delete_rejected_app', password: 'delete_rejected_app' },
 ] as const
 
@@ -31,16 +35,19 @@ for (const user of TEST_USERS) {
     await expect(page).toHaveURL(/localhost:3000/, { timeout: 30_000 })
 
     // Wait for the app to fully initialize with the auth tokens
-    await page.waitForFunction(() => {
-      try {
-        const tokens = localStorage.getItem('authentication_tokens')
-        if (!tokens) return false
-        const parsed = JSON.parse(tokens)
-        return !!parsed.access_token && !!parsed.refresh_token
-      } catch {
-        return false
-      }
-    }, { timeout: 15_000 })
+    await page.waitForFunction(
+      () => {
+        try {
+          const tokens = localStorage.getItem('authentication_tokens')
+          if (!tokens) return false
+          const parsed = JSON.parse(tokens)
+          return !!parsed.access_token && !!parsed.refresh_token
+        } catch {
+          return false
+        }
+      },
+      { timeout: 15_000 },
+    )
 
     // Save the authenticated state (localStorage + cookies including Keycloak session)
     await page.context().storageState({ path: `e2e/.auth/${user.name}.json` })

client/e2e/auth.spec.ts

@@ -26,7 +26,9 @@ test.describe('Authentication - Unauthenticated', () => {
   test('about page is accessible without login', async ({ page }) => {
     await navigateTo(page, '/about')
 
-    await expect(page.getByRole('heading', { name: 'Thesis Management', exact: true })).toBeVisible()
+    await expect(
+      page.getByRole('heading', { name: 'Thesis Management', exact: true }),
+    ).toBeVisible()
   })
 })
 

client/e2e/interview-workflow.spec.ts

@@ -9,20 +9,15 @@ test.describe('Interview Workflow', () => {
 
   test('supervisor can view interview process and score an interviewee', async ({ page }) => {
     // Navigate directly to the interviewee assessment page
-    await navigateTo(
-      page,
-      `/interviews/${INTERVIEW_PROCESS_ID}/interviewee/${INTERVIEWEE_ID}`,
-    )
+    await navigateTo(page, `/interviews/${INTERVIEW_PROCESS_ID}/interviewee/${INTERVIEWEE_ID}`)
 
     // Wait for page to load with the interviewee name
-    await expect(
-      page.getByRole('heading', { name: /Interview - Student4 User/i }),
-    ).toBeVisible({ timeout: 15_000 })
+    await expect(page.getByRole('heading', { name: /Interview - Student4 User/i })).toBeVisible({
+      timeout: 15_000,
+    })
 
     // Verify "Interview Assessment" section title
-    await expect(
-      page.getByRole('heading', { name: 'Interview Assessment' }),
-    ).toBeVisible()
+    await expect(page.getByRole('heading', { name: 'Interview Assessment' })).toBeVisible()
 
     // Verify "Score" card title is visible
     await expect(page.getByRole('heading', { name: 'Score', exact: true })).toBeVisible()
@@ -31,13 +26,13 @@ test.describe('Interview Workflow', () => {
     await page.getByText('Great Candidate').click()
 
     // Verify score selection registered — Mantine SegmentedControl sets data-active on the label
-    const scoreLabel = page.getByText('Great Candidate').locator('xpath=ancestor::label[@data-active]')
+    const scoreLabel = page
+      .getByText('Great Candidate')
+      .locator('xpath=ancestor::label[@data-active]')
     await expect(scoreLabel).toBeVisible({ timeout: 5_000 })
 
     // Verify "Interview Note" card title is visible
-    await expect(
-      page.getByRole('heading', { name: 'Interview Note', exact: true }),
-    ).toBeVisible()
+    await expect(page.getByRole('heading', { name: 'Interview Note', exact: true })).toBeVisible()
 
     // Fill interview note using the ProseMirror editor
     // (InterviewNoteCard uses DocumentEditor without a Mantine InputWrapper label,
@@ -46,7 +41,9 @@ test.describe('Interview Workflow', () => {
     await noteEditor.click()
     const modifier = process.platform === 'darwin' ? 'Meta' : 'Control'
     await page.keyboard.press(`${modifier}+a`)
-    await page.keyboard.type('Good understanding of streaming concepts and anomaly detection methods.')
+    await page.keyboard.type(
+      'Good understanding of streaming concepts and anomaly detection methods.',
+    )
 
     // Wait for auto-save (debounced at 1000ms) — look for "Saved" indicator
     await expect(page.getByText('Saved')).toBeVisible({ timeout: 10_000 })
@@ -56,14 +53,14 @@ test.describe('Interview Workflow', () => {
     await navigateTo(page, `/interviews/${INTERVIEW_PROCESS_ID}`)
 
     // Wait for interview management page to load
-    await expect(
-      page.getByRole('heading', { name: /interview management/i }),
-    ).toBeVisible({ timeout: 15_000 })
+    await expect(page.getByRole('heading', { name: /interview management/i })).toBeVisible({
+      timeout: 15_000,
+    })
 
     // Verify interviewees section is visible
-    await expect(
-      page.getByRole('heading', { name: 'Interviewees', exact: true }),
-    ).toBeVisible({ timeout: 10_000 })
+    await expect(page.getByRole('heading', { name: 'Interviewees', exact: true })).toBeVisible({
+      timeout: 10_000,
+    })
 
     // Click "Add Slot" button to open the modal
     await page.getByRole('button', { name: /Add Slot|^Add$/i }).click()