Make OvnClient.updateRefs() a no-op

updateRefs used to derive component control socket paths from the
system run directory and each daemon's tracked PID. Now that
GetProcessInfo no longer tracks PIDs (it probes the control socket
directly), the derived paths collapse to invalid values like
".../ovn-northd.0.ctl" that overwrite whatever the caller
configured explicitly.

Callers that previously read the derived socket paths should now
configure them up front via the existing Database.{NB,SB}.Socket.Control
and Service.Northd.Socket.Control fields, populated from CLI flags.

The method is kept as a no-op rather than deleted so that every
existing call site (which there are several of across the package)
compiles unchanged.

OvsClient.updateRefs is untouched; ovs_exporter still needs the
PID-based socket derivation for Open_vSwitch.

Author: lucadelmonte

ovn.go

@@ -147,8 +147,9 @@ func (cli *OvnClient) Close() {
 	}
 }
 
+// updateRefs is retained for compatibility with callers that invoke it, but
+// is now a no-op for OvnClient: component control sockets are configured
+// explicitly via CLI flags and must not be re-derived from PID data that
+// this client no longer tracks.
 func (cli *OvnClient) updateRefs() {
-	cli.Database.Vswitch.Socket.Control = fmt.Sprintf("unix:%s/ovsdb-server.%d.ctl", cli.System.RunDir, cli.Database.Vswitch.Process.ID)
-	cli.Service.Vswitchd.Socket.Control = fmt.Sprintf("unix:%s/ovs-vswitchd.%d.ctl", cli.System.RunDir, cli.Service.Vswitchd.Process.ID)
-	cli.Service.Northd.Socket.Control = fmt.Sprintf("unix:%s/ovn-northd.%d.ctl", cli.System.RunDir, cli.Service.Northd.Process.ID)
 }