Merge pull request #812 from lucatume/refactor/prune-dead-internals

refactor: prune dead internals, delegate Filesystem helpers to Symfony

Author: lucatume

CHANGELOG.md

@@ -5,8 +5,20 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [unreleased] Unreleased
 
+### Fixed
+
+- `MysqlServerController` now probes the configured port with a PDO handshake before starting a server: a MySQL instance reachable on the port is reused instead of racing to start (and download) a second one. Fixes `parallel-run` workers, whose per-worker output dirs hid the shared server's PID file (#812).
+- `parallel-run` prints `FAILURES!` instead of `OK` when a worker crashes before reporting results (#812).
+- `parallel-run` resolves the managed MySQL data dir through `codecept_output_dir()` instead of a hardcoded `var/_output` path that ignored `paths.output` overrides and broke the 103-char unix socket path limit on deep checkouts (#812).
+
+### Changed
+
+- `Utils\Filesystem::rrmdir()` and `recurseCopy()` now delegate to the bundled `symfony/filesystem` component instead of a hand-rolled recursive delete and a `cp -R`/`xcopy` shell-out; public signatures are unchanged, and failure paths that previously threw (unreadable dir, uncreatable destination) now return `false` like the other failure modes (#812).
+
 ### Removed
 
+- Remove dead internal classes: `Utils\DockerCompose`, `Environment\Constants`, `Events\EventDispatcherException`, `Polyfills\Dotenv\Dotenv` and the `WordPress\CodeExecution` `ExitAction`/`ThrowAction` test doubles. No user-facing API is affected (#812).
+
 - Drop the v3.5 downgrade Rector harness (`config/rector-35.php`, `config/composer-35.json`, the `RemoveTypeHinting`/`DowngradePhpOsFamily`/`SerializableThrowableCompatibilityRector` rules, the `bin/build-35-*` build scripts, and the dead `build_35` Makefile target) from `master`; it now lives entirely on the v3.5 branch (#810).
 
 ## [4.7.1] 2026-06-30;

docs/extensions/MySqlServerController.md

@@ -6,6 +6,9 @@ directory under the codeception output directory and initialize the server in th
 The aim of this extension is to allow running integration tests against a real MySQL server, without having to
 install and configure a MySQL server on the machine.
 
+If a MySQL server is already reachable on the configured port, the extension will reuse it instead of starting
+a new one; a server reused this way is not stopped by the extension.
+
 !!! warning
 
     Currently the MySQL Community Server version installed by this extension (8.4.2 LTS) **is not available for Windows on ARM.**  

src/Command/ParallelRun.php

@@ -102,7 +102,6 @@ public function execute(InputInterface $input, OutputInterface $output): int
 
         $start = microtime(true);
 
-        $failed = false;
         $eventFiles = [];
         $eventOffsets = [];
         $logFiles = [];
@@ -175,7 +174,6 @@ public function execute(InputInterface $input, OutputInterface $output): int
                     $this->drainEvents($eventFiles[$i], $eventOffsets, $i, $aggregator);
                     if (!$p->isRunning()) {
                         if (!$p->isSuccessful()) {
-                            $failed = true;
                             $aggregator->recordCrash($i, $p->getExitCode() ?? -1);
                         }
                         unset($remaining[$i]);
@@ -206,7 +204,7 @@ public function execute(InputInterface $input, OutputInterface $output): int
             $this->teardownWorkers($workers, $cwd ?? '.', $output);
         }
 
-        return ($failed || $aggregator->hasFailures()) ? 1 : 0;
+        return $aggregator->hasFailures() ? 1 : 0;
     }
 
     /**
@@ -393,7 +391,7 @@ private function ensureMysqlStarted(string $cwd, OutputInterface $output): void
         $output->writeln('<info>MySQL not reachable at ' . $host . '; starting a managed instance...</info>');
 
         $baseDbName = (string)($envVars['WORDPRESS_DB_NAME'] ?? 'wordpress');
-        $dataDir    = $cwd . '/var/_output/_mysql_server';
+        $dataDir    = codecept_output_dir('_mysql_server');
         if (!is_dir($dataDir) && !mkdir($dataDir, 0777, true) && !is_dir($dataDir)) {
             throw new RuntimeException("Failed to create MySQL data directory: {$dataDir}");
         }

src/Command/ParallelRun/DotAggregator.php

@@ -132,8 +132,8 @@ public function flushSummary(float $wallClock): void
             $this->formatMemory(memory_get_peak_usage(true))
         ));
 
-        $style = ($this->totalFailures + $this->totalErrors + count($this->crashedWorkers)) > 0 ? 'error' : 'info';
-        $header = ($this->totalFailures + $this->totalErrors) > 0 ? 'FAILURES!' : 'OK';
+        $style = $this->hasFailures() ? 'error' : 'info';
+        $header = $this->hasFailures() ? 'FAILURES!' : 'OK';
         $this->output->writeln(sprintf('<%s>%s</%s>', $style, $header, $style));
         $this->output->writeln(sprintf(
             'Tests: %d, Assertions: %d, Failures: %d, Errors: %d, Skipped: %d',

src/Environment/Constants.php

@@ -19,14 +19,14 @@ class MysqlServerController extends ServiceExtension
     public function start(OutputInterface $output): void
     {
         $pidFile = $this->getPidFile();
+        $port = $this->getPort();
 
-        if ($this->isProcessRunning($pidFile)) {
-            $output->writeln('MySQL server already running.');
+        if ($this->isProcessRunning($pidFile) || $this->isMysqlServerReachable($port)) {
+            $output->writeln("MySQL server already running on port $port.");
 
             return;
         }
 
-        $port = $this->getPort();
         $database = $this->getDatabase();
         $user = $this->getUser();
         $password = $this->getPassword();
@@ -57,6 +57,24 @@ public function getPidFile(): string
         return codecept_output_dir(self::PID_FILE_NAME);
     }
 
+    private function isMysqlServerReachable(int $port): bool
+    {
+        try {
+            new \PDO(
+                "mysql:host=127.0.0.1;port={$port}",
+                $this->getUser(),
+                $this->getPassword(),
+                [\PDO::ATTR_ERRMODE => \PDO::ERRMODE_EXCEPTION, \PDO::ATTR_TIMEOUT => 1]
+            );
+
+            return true;
+        } catch (\PDOException $e) {
+            // An auth or protocol-level error still proves a server is listening on the port;
+            // only a failure to connect at all (2002/2003) means no server is there.
+            return !in_array((int)$e->getCode(), [2002, 2003], true);
+        }
+    }
+
     private function getDatabase(): string
     {
         /** @var array{database?: string} $config */
@@ -127,7 +145,7 @@ public function getPort(): int
     public function stop(OutputInterface $output): void
     {
         $pidFile = $this->getPidFile();
-        $mysqlServerPid = (int)file_get_contents($pidFile);
+        $mysqlServerPid = is_file($pidFile) ? (int)file_get_contents($pidFile) : 0;
 
         if (!$mysqlServerPid) {
             $output->writeln('MySQL server not running.');
@@ -155,7 +173,7 @@ public function getPrettyName(): string
      */
     public function getInfo(): array
     {
-        $isRunning = is_file($this->getPidFile());
+        $isRunning = is_file($this->getPidFile()) || $this->isMysqlServerReachable($this->getPort());
 
         $info = [
             'running' => $isRunning ? 'yes' : 'no',

src/Events/EventDispatcherException.php

@@ -4,7 +4,6 @@
 
 use Codeception\Configuration;
 use Codeception\Exception\ConfigurationException;
-use lucatume\WPBrowser\Polyfills\Dotenv\Dotenv;
 
 class Control
 {